0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

3758 Commits

Author SHA1 Message Date
Paolo D'Amico
ad7866743d
Release Nailing Funnels (#5605)
Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-08-18 08:44:28 -07:00
Karl-Aksel Puulmann
b1f5cd38e3
Display 0% instead of NaN when 0 out of 0 people complete a step (#5634)
Closes https://github.com/PostHog/posthog/issues/5633
2021-08-18 17:51:51 +03:00
Karl-Aksel Puulmann
f2bd6d7f1f
Try fix flaky tests (#5642)
For some reason, this test has been failing reliably the past day,
returning 2 people instead of 1.

The culprit should be https://github.com/PostHog/posthog/pull/5572 but
not sure why tests passed on that branch?
2021-08-18 10:29:46 -04:00
Karl-Aksel Puulmann
59c7efdebe
Migrate person_distinct_id table to CollapsingMergeTree (#5563)
* WIP: Migration to migrate person_distinct_id to CollapsingMergeTree

* Improve migrations

* Another attempt at migration

Using nullable otherwise it defaults without the default 😅

* Linter approved

* Update test code

* Fix testing issues
2021-08-18 17:25:02 +03:00
Karl-Aksel Puulmann
323f82bd2b
Add loading state to InsightsTable (#5601)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-17 20:04:09 +00:00
Michael Matloka
49c8ec58b0
Add "KEEP CLICKHOUSE-SERVER VERSION IN SYNC" comment (#5623) 2021-08-17 21:54:47 +02:00
Eric Duong
c79c270f5f
Cumulative person bug (#5572)
* add test and only handle interval if it's non cumulative

* add cumulative to tests that have specific date range
2021-08-17 15:13:24 -04:00
Li Yi Yu
742ad33252
prevent sessions to trends white screen death bug (#5620) 2021-08-17 15:00:29 -04:00
PostHog bot
64de1f0d86
Update plugin server to 1.2.0 (#5621)
Co-authored-by: posthog-bot <posthog-bot@users.noreply.github.com>
2021-08-17 19:13:34 +02:00
Yakko Majuri
a4b183a950
Hide bot users from org members (#5596)
* Hide bot users from org members

* Revert "Hide bot users from org members"

This reverts commit cb0fd412ac.

* do backend filtering
2021-08-17 16:29:57 +02:00
Karl-Aksel Puulmann
c29ffb016d
Fix dev.Dockerfile (#5613)
* Fix dev.Dockerfile

See https://github.com/PostHog/posthog/pull/5609 for why this broke

Bullseye has libpq-dev version 13 and apt doesn't support version ranges
so removing the package version seems all we can do 😅

* Pin version to bypass linter
2021-08-17 16:24:49 +02:00
Marius Andra
95dafc9a62
Insight & dashboard loading issues (#5612)
* load the funnel after the logic mounts, not after the component

* move logicFromInsight to another file to avoid recursive imports of funnelLogic and insightLogic

* take last applied filters directly from results

* fix type

* more meaningful default key

* add some props (WIP)

* only run insight query start/end tracking if on insights

* fix some types

* load the funnel only if valid to do so; prevents initial "loaded, but error" state

* remove debug

* still call startQuery/endQuery on insightLogic

* convert dashboardLogic to TS

* fix more ts errors

* fix more TS errors

* save last used filters with results

* fix type import path for typegen
2021-08-17 16:19:17 +02:00
Yakko Majuri
1bfb20f85e
Show search bar for plugin config choice field (#5578) 2021-08-17 09:33:49 +00:00
Karl-Aksel Puulmann
4ba8249cb5
Handle materialized properties in more cases (#5523)
* Extract method from funnels code

* Add failing test case for using denormalized property in a funnel breakdown

* Handle materialized event properties in funnel breakdown

* Refactor property lookups

* Use denormalized properties in paths

* Update validation tests

* Update validation tests

* Fix a broken test

* Move test around
2021-08-17 12:30:28 +03:00
Karl-Aksel Puulmann
9a6516aa94
Use Literal type to type Filter/Property/Entity objects better (#5608)
* Type python Property.type

* Type Filter.breakdown_type in python

* Fix typing issue in actions view

* Type python Filter.insight

* Type python Filter.display

* Type python Filter.interval, fix resulting typing errors

* Type python funnel Filter.layout

* Type python funnel Filter.funnel_window_interval_unit

* Type python Filter.retention_type

* Type python funnel Filter.funnel_window_interval_unit_ch

* Type python path Filter.path_type

* Type python path Filter.target_event

* Type Entity.type

* Type python Property.operator
2021-08-17 12:13:14 +03:00
Karl-Aksel Puulmann
11e2b33225
Fix docker dev build (#5611) 2021-08-17 12:10:59 +03:00
Karl-Aksel Puulmann
8acb0e2242
Fix docker build (#5609) 2021-08-17 10:55:40 +03:00
posthog-contributions-bot[bot]
2e818ecdf2
🤖: Add 7MIMIRA as a contributor 🎉 (#5602) 2021-08-16 20:46:08 +01:00
Alex Gyujin Kim
51918efe35
Add delays to tooltip + Typing Actions (#5591)
* custom tooltip component and typing for actions

* change delay to 500ms

* cautionary comment

* debouncing visible

* dont introduce new html element into tooltip, use cloneElement instead

* add prop types and default override prop to tooltip
2021-08-16 19:33:04 +00:00
Karl-Aksel Puulmann
5517cead23
Fix refreshing funnels (#5597)
https://github.com/PostHog/posthog/pull/5576 broke funnels refreshing
due to an added equality check
2021-08-16 09:07:12 -07:00
PostHog bot
1fd0fd7f14
Update plugin server to 1.1.15 (#5599) 2021-08-16 16:56:10 +01:00
Alex Gyujin Kim
344aab3ee7
Patch for dashboardLogic crashing home page (#5522) 2021-08-16 08:59:50 -05:00
PostHog bot
dfca81b66a
Update plugin server to 1.1.14 (#5595) 2021-08-16 13:04:06 +01:00
Yakko Majuri
e5a9c3b04e
merge people test (#5567)
* do all merge_people ops in plugin server

* add integration test

* flip call order

* allow calls in any order

* update test approach
2021-08-16 10:53:52 +03:00
Karl-Aksel Puulmann
46f43bc247
Fix empty element filtering (#5504)
* Refactor event_query class

* Don't error when filtering by empty elements array

"Solves" https://github.com/PostHog/posthog/issues/5501

* Solve same copy-pasted solution consistently

* Behave consistently with return values

See also issue https://github.com/PostHog/posthog/issues/5503 - maybe we
shouldn't even allow non-empty?
2021-08-16 10:51:12 +03:00
Li Yi Yu
3ad9ad2158
Fix retention filters (#5590)
* fix filter params

* add comment

* clean up with selector
2021-08-13 18:30:38 -07:00
Alex Gyujin Kim
db1def7c6d
Revert "Fix white screen bug for sessions table navigation to trends (#5569)" (#5592)
This reverts commit 2bc3281d05.
2021-08-14 00:46:59 +00:00
Paolo D'Amico
bb458edbff
Report properties on insight viewed (#5511) 2021-08-13 17:59:51 +00:00
Alex Gyujin Kim
d945bb3b3c
PEMDAS, Performance Optimization, and a small UI bug (#5576)
* pemdas, performance improvement

* descriptive comment

* no bools today
2021-08-13 09:09:40 -07:00
Li Yi Yu
2bc3281d05
Fix white screen bug for sessions table navigation to trends (#5569)
* do not render line graph for wrong data types

* data of undefined fix
2021-08-13 09:40:33 -04:00
Michael Matloka
18bd79ee41
Insights refresh improved (#5530)
* Improve insight refreshing UX

* Clean up

* Make sure `ComputationTimeAndRefresh` is on the right in Trends too

* Fix typing and some inconsistencies

* Remove unused const

* Update test_clickhouse_insights.py

* Update decorators.py

* Refactor `ComputationTimeWithRefresh` into own file
2021-08-13 03:31:54 +02:00
Michael Matloka
336fd16709
Fix issue with importing PropertyKeyInfo.scss in Jest test (#5577) 2021-08-13 00:45:19 +00:00
Li Yi Yu
64afebd643
Insight tags and description (#5480)
* pull description into its own reuseable component

* working object tags for insights

* refactor editing toast and add insight description editing

* insight name editing and split up huge insights component

* fix toast bug

* typing

* test fixes and clean up

* test something

* add cypress tests

* bug fixes

* test with user logic dashboard collab instead

* history is now a link button

* hide under saved insights feature flag

* skip tests for now

* prettier

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-12 17:55:11 -04:00
Yakko Majuri
304033c01f
Add Sessions tooltip (#5564)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-12 21:11:19 +00:00
Kunal
3d1875efe1
Add link to ingestion docs to helper dropdown (#5571)
* add ingestion doc link

* copy tweak

Co-authored-by: kunal <kunal@kunals-MacBook-Pro.local>
2021-08-12 20:30:46 +00:00
Eric Duong
27a8944413
Match docker compose file clickhouse version to cloud prod version (#5573)
* match docker compose file clickhouse version to cloud prod version

* trigger tests
2021-08-12 16:06:47 -04:00
Karl-Aksel Puulmann
57d8826150
Proposal: Hide people count (#5560)
See https://github.com/PostHog/posthog/issues/5559 for context
2021-08-12 13:22:24 -05:00
Alex Gyujin Kim
5c4630f7e6
New funnel uncalculated state (#5554) 2021-08-12 12:31:29 -05:00
Yakko Majuri
81348a0428
Execute merge_people in plugin server (#5452)
* do all merge_people ops in plugin server

* allow calls in any order
2021-08-12 13:58:04 +00:00
Neil Kakkar
a245c15c94
Group reamining breakdown values into "Other" for funnels (#5538)
* breakdown grouping

* resolve pagination woes

* explain the offset override

* document assumption
2021-08-12 13:38:28 +00:00
Li Yi Yu
19c68ed697
Hide funnel step table when graphs are errored (#5549) 2021-08-12 12:44:31 +02:00
PostHog bot
73d603a1b5
Update plugin server to 1.1.13 (#5561) 2021-08-12 10:51:10 +01:00
dependabot[bot]
c8a971ee4f
Bump path-parse from 1.0.6 to 1.0.7 (#5558)
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-12 04:12:32 +00:00
Alex Gyujin Kim
a2f48a873d
add docker compose down to remove network (#5555) 2021-08-11 17:25:12 -07:00
Alex Gyujin Kim
247d2c05e2
Custom conversion window sizes (#5453)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-11 18:27:58 -05:00
Li Yi Yu
37f1498410
Sort insights table total sum (#5521)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-11 14:35:18 -05:00
Li Yi Yu
79e74aebba
Replace retention tab with new filters (#5536)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-11 19:29:30 +00:00
Eric Duong
0ef17984b4
only send breakdown value when there's a valid value (#5529) 2021-08-11 14:45:33 -04:00
Eric Duong
de7ff476c5
Allow cohort breakdown to show on funnel (#5495)
* allow cohort breakdown to show

* Sanitize `order` in `Entity.__init__`

* Remove kludge from #5485 by making `entity.order` useful in practice

* Use synthetic `index` instead of user-provided `order`

* Fix `processed_entities` sorting

* Update frontend/src/scenes/funnels/funnelLogic.ts

Co-authored-by: Karl-Aksel Puulmann <macobo@users.noreply.github.com>

* change type guard and add number back

* remove typeguard and add correct types for cohorts

* remove type change

* working cohort breakdowns ui

* one more type fix

* adjust tests

* adjust tests

* more test adjustmenet

* minor syntax change

* use breakdown type

* add comment

* remove leakover

Co-authored-by: Michael Matloka <dev@twixes.com>
Co-authored-by: Karl-Aksel Puulmann <macobo@users.noreply.github.com>
Co-authored-by: Sam Winslow <sammywinslow@gmail.com>
2021-08-11 13:56:49 -04:00
Tim Glaser
a6cc0f0aa7
Use official rrweb version again and update (#5004)
* Use official rrweb version again and update

* Bump rrweb to 1.0.2 (from 1.0.1)

* Use updated `@posthog/react-rrweb-player`

Co-authored-by: Michael Matloka <dev@twixes.com>
2021-08-11 13:00:08 +02:00