0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

3758 Commits

Author SHA1 Message Date
Michael Matloka
ab57d9b321
Fix drawer z-index (#5533) 2021-08-11 08:51:45 +00:00
Yakko Majuri
1021e02031
Respect disabled toolbar (#5526)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-11 04:06:11 +00:00
Paolo D'Amico
3478213acf
Improvements to insights table & funnel logic cleanup (#5505) 2021-08-10 19:11:27 -05:00
dependabot[bot]
235e855cc5
Bump path-parse from 1.0.6 to 1.0.7 in /plugins (#5535)
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-10 23:21:27 +00:00
Paolo D'Amico
cc005ddd9a
Update Clickhouse upgrade message (#5520) 2021-08-10 15:09:56 -07:00
Paolo D'Amico
0e13a1e597
Add clear-ch-dev command (#5525) 2021-08-10 15:08:50 -07:00
Karl-Aksel Puulmann
9c083da182
Drop python 3.7 support (#5483)
Issue: https://github.com/PostHog/posthog/issues/5482
2021-08-10 09:54:42 +03:00
Karl-Aksel Puulmann
d0cfe88fd4
Don't fail if capture_internal fails (#5514)
If we have badly-configured metrics this can cause trouble, instead just
notify sentry
2021-08-10 09:52:04 +03:00
Sam Winslow
1561cbb932
Add HUBSPOT_API_KEY secrets manager arn (#5517)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-09 22:18:34 +00:00
Michael Matloka
984cdd547d
Remove kludge from #5485 by using entity.index (#5497)
* Sanitize `order` in `Entity.__init__`

* Remove kludge from #5485 by making `entity.order` useful in practice

* Use synthetic `index` instead of user-provided `order`

* Fix `processed_entities` sorting

* Add `index` comment
2021-08-09 20:23:36 +00:00
Karl-Aksel Puulmann
3984ae2279
Handle person having no distinct_ids in events table (#5500)
Sentry error: https://sentry.io/organizations/posthog/issues/2297864788/?project=1899813&referrer=github_integration
Closes https://github.com/PostHog/posthog/issues/5385

Not 100% sure how this happens (race condition with user getting
identified?) but the same guard exists in the postgresql-based codebase.
2021-08-09 22:21:53 +03:00
Karl-Aksel Puulmann
41baed2594
Fix sentry metrics capture (#5513)
https://sentry.io/organizations/posthog/issues/2563780334/?project=1899813&referrer=slack
2021-08-09 15:43:34 +03:00
Karl-Aksel Puulmann
3900970cab
Fix filtering actions by people (#5490)
Closes issue https://github.com/PostHog/posthog/issues/5477
2021-08-09 13:23:55 +01:00
Karl-Aksel Puulmann
dac770ae45
Gather info on response codes in API (#5499)
Using that to add metrics to endpoints-based dashboard, making sure we
don't e.g. 400 too often. :)
2021-08-09 13:06:39 +01:00
Li Yi Yu
16481a82d8
Fix preserve of dashboard name when navigating insights (#5502) 2021-08-09 07:01:36 -05:00
Karl-Aksel Puulmann
82056d2f05
Add migration to index person by team_id, id DESC (#5489)
Closes https://github.com/PostHog/posthog/issues/4941
2021-08-09 13:57:24 +03:00
PostHog bot
fdb7253750
Update plugin server to 1.1.12 (#5508) 2021-08-09 09:16:30 +01:00
Karl-Aksel Puulmann
a860da9e90
Dynamic materialized columns (#5458)
* Add migration marking existing columns as materialized with a comment

* Add method to allow looking up materialized columns

* Add test for fetching and creating materialized columns

* Disable caching in tests

* Remove some callsites to CLICKHOUSE_DENORMALIZED_PROPERTIES

* Fixup caching logic

* Add (currently broken) test for denormalizing person properties

* Update funnel event query to work with new functionality

* Update other tests/queries

* Remove now-unused setting
2021-08-09 10:11:36 +03:00
Karl-Aksel Puulmann
cd18cf88cd
Show error instead of timeout message when query fails with non-500 (#5498) 2021-08-08 18:09:00 -05:00
Li Yi Yu
12f5b76f2c
Show only spinner when loading for funnels (#5449)
* return only spinner or warning

* add some white space
2021-08-06 20:02:15 +00:00
Eric Duong
f14ed0bb2b
Only replace top level distinct_id when formatting cohort subquery (#5493)
* only replace top level distinct_id

* type

* change name and type
2021-08-06 15:32:14 -04:00
Karl-Aksel Puulmann
f25ae0a879
Generate clickhouse query error class dynamically (#5492)
This helps with not grouping sentry errors together.

See issue for more context

Closes https://github.com/PostHog/posthog/issues/5491
2021-08-06 16:31:42 +01:00
Paolo D'Amico
9b3e130737
Update README - Aug 5 (#5474) 2021-08-06 08:24:24 -07:00
Karl-Aksel Puulmann
baa89a1386
Sanitize entity.math_property (#5485)
* Sanitize `entity.math_property`

Was refactoring related code and stumbled upon this issue. Yikes!

* WIP

* Improve breakdowns
2021-08-06 17:43:21 +03:00
Neil Kakkar
da0edb87d8
Clarify how Filtering out internal users works (#5486)
Got feedback that it was very confusing whether the filter is applied as is, or in negation. (as is makes sense for properties, but makes very little sense for cohorts, since internal users cohort size <<< external users cohort size)
2021-08-06 11:51:01 +00:00
Michael Matloka
2ce4acb85b
Sync SUPPORTED_INTERVAL_TYPES with rest of query-building (#5484) 2021-08-06 09:58:20 +00:00
Michael Matloka
c2bc2fecd0
Use proper interval calculation in the funnel trends query (#5467)
* Use proper interval calculation in the funnel trends query

* Add some comments

* Update `test_filter`

* Rework `NULL_SQL` to use CH `INTERVAL` too

* Fix week-based relative `date_from` support not existing

* Make use of `toInterval*` functions and inject less

* Add fallback for `date_from` in `ClickhouseSessionsAvg`
2021-08-06 11:29:35 +02:00
James Greenhill
397d10a9d8
Have migration task bypass pgbouncer and connect direct to pg for session stickiness (#5479)
* Have migration task bypass pgbouncer and connect direct to pg for session stickiness

* change USING_PGBOUNCER to false and remove duplicate
2021-08-06 09:27:49 +03:00
Karl-Aksel Puulmann
049c41868e
Hide time-to-convert when using breakdown (#5476) 2021-08-05 14:05:17 -07:00
Karl-Aksel Puulmann
a1dd96e47d
Improve cached_property typing (#5465)
* Improve cached_property typing

Noticed that e.g. `filter.breakdown` was getting inferred to be `Any`
which is not correct. Added generics to fix it :)

* Proposed fix: make filter_test_accounts return a bool always

* Fix warning in clickhouse_sessions.py

* Cast in session.events

* Cast 2x in funnel queries

* Ignore error in session recording

We know the valid values here

* Add assertions in stickiness filters

* Cast in more funnel queries

* Untyped dict where inferred type is wrong

* Add types to abstract methods

* Type prop_vals

* Add a lot of casts

These are correct. We should really validate while parsing instead

* Add more casts to funnel trends

* Last fixes
2021-08-05 22:31:31 +03:00
Michael Matloka
5c1408fac7
Provide more informational invalid regex message (#5456)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-05 19:10:05 +00:00
Michael Matloka
fd0ff16c9b Fix link to building a plugin
Glossed over in #5448.
2021-08-05 17:44:48 +02:00
Yakko Majuri
1f2458eaaf
Add more contrast between official and community plugins (#5448)
* update plugins repo tab

* Make it clear when plugins are built by the community
2021-08-05 17:37:11 +02:00
posthog-contributions-bot[bot]
b6f325f263
🤖: Add jredl-va as a contributor 🎉 (#5470)
* docs: update README.md

* docs: update .all-contributorsrc

Co-authored-by: posthog-contributions-bot[bot] <80958034+posthog-contributions-bot[bot]@users.noreply.github.com>
2021-08-05 17:06:11 +02:00
Li Yi Yu
cd94321cba
Saved insights default page (#5416) 2021-08-05 07:38:07 -07:00
Karl-Aksel Puulmann
4260cc868f
Make timer safe (#5469)
Supercedes https://github.com/PostHog/posthog/pull/5468
2021-08-05 16:58:21 +03:00
Karl-Aksel Puulmann
bc49811e06
Update query metrics (#5460)
Previous change made it really hard to calculate failure %, fixing...
2021-08-05 13:12:52 +03:00
Marcus Hyett (PostHog)
cca46b2f80
Automatically Persist Filter Value on Blur (#5373)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
Co-authored-by: Alex Kim <alexgkim205@gmail.com>
2021-08-05 10:04:33 +00:00
Michael Matloka
e48bd8b08b
Allow "new member" email opt-out (#5430) 2021-08-04 18:09:41 -07:00
Michael Matloka
a163b84974
Hotfix crashing Home (#5454) 2021-08-05 01:00:34 +02:00
Paolo D'Amico
76bbf7f4df
Better insights instrumentation (#5432)
* report from dashboard on insight viewed

* report person modal

* abstract filter sanitization and report cohort creation

* report insight viewed after 10s

* change to insight analyzed
2021-08-04 14:45:14 -07:00
Alex Gyujin Kim
5d8bc03e29
Beef up warning funnel empty state message (#5434)
* standardize warning funnel empty state

* change color and icon
2021-08-04 13:16:42 -07:00
Marius Andra
3f70dcd857
Add urls to programmatically create routes (#4656)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-04 12:31:14 -07:00
PostHog bot
1a8d14010a
Update posthog-js to 1.12.3 (#5446)
Co-authored-by: posthog-bot <posthog-bot@users.noreply.github.com>
2021-08-04 19:34:03 +02:00
Karl-Aksel Puulmann
d4f246ecab
Make breakdowns + formulas work (#5444)
* Use f-strings in trends/formula

* Make formulas and breakdowns work

Closes issue https://github.com/PostHog/posthog/issues/5390

Previously the query returned a 500 for some breakdowns, with the error
`Arrays passed to arrayMap must have equal size: while executing 'FUNCTION arrayMap`

The issue came from the different subqueries having different breakdowns
- some would break down with values A and B and other would have B and C

After the full outer join, arrays for breakdown values A and C would be empty in some cases. Filling them with zeroes fixes the issue.
2021-08-04 19:32:00 +03:00
dependabot[bot]
cd2dcddc9a
Bump tar from 6.1.0 to 6.1.3 in /plugins (#5436)
Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.3.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.1.0...v6.1.3)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-04 09:27:34 -07:00
Alex Gyujin Kim
c22f66ca33
Synchronous dashboard refreshes (#5407)
* add synchronous dashboard refresh all items

* add auto reload dropdown

* fix trigger bounds

* small fixes

* refresh width

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-04 08:48:00 -07:00
Eric Duong
24a708c259
Funnel trends all date range (#5420)
* implementation and test

* change to escape params
2021-08-04 10:33:39 -04:00
Karl-Aksel Puulmann
d25fa2c2d5
Fix "filter test accounts via cohort" filter (#5442)
Closes https://github.com/PostHog/posthog/issues/5441
2021-08-04 11:44:45 +01:00
PostHog bot
92f5f9f831
Update plugin server to 1.1.11 (#5435) 2021-08-03 22:19:37 +01:00