smartyellow/docx-js
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify multiple addXXX methods into a single add method for Footer

Browse Source
This commit is contained in:
Dolan
2019-06-25 01:58:09 +01:00
parent 384d144a85
commit b566b0f765
5 changed files with 15 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/file/footer-wrapper.spec.ts
View File

@ -7,21 +7,19 @@ import { Paragraph } from "./paragraph";
import { Table } from "./table";
describe("FooterWrapper", () => {
describe("#addParagraph", () => {
describe("#add", () => {
it("should call the underlying footer's addParagraph", () => {
const file = new FooterWrapper(new Media(), 1);
const spy = sinon.spy(file.Footer, "addParagraph");
file.addParagraph(new Paragraph({}));
const spy = sinon.spy(file.Footer, "add");
file.add(new Paragraph({}));
expect(spy.called).to.equal(true);
});
});
describe("#addTable", () => {
it("should call the underlying footer's addParagraph", () => {
const file = new FooterWrapper(new Media(), 1);
const spy = sinon.spy(file.Footer, "addTable");
file.addTable(
const spy = sinon.spy(file.Footer, "add");
file.add(
new Table({
rows: 1,
columns: 1,
@ -30,12 +28,10 @@ describe("FooterWrapper", () => {
expect(spy.called).to.equal(true);
});
});
describe("#addImage", () => {
it("should call the underlying footer's addImage", () => {
const file = new FooterWrapper(new Media(), 1);
const spy = sinon.spy(file.Footer, "addParagraph");
const spy = sinon.spy(file.Footer, "add");
// tslint:disable-next-line:no-any
file.addImage({} as any);

12
src/file/footer-wrapper.ts
View File

@ -22,16 +22,12 @@ export class FooterWrapper {
this.relationships = new Relationships();
}
public addParagraph(paragraph: Paragraph): void {
this.footer.addParagraph(paragraph);
}
public addTable(table: Table): void {
this.footer.addTable(table);
public add(item: Paragraph | Table): void {
this.footer.add(item);
}
public addImage(image: Image): FooterWrapper {
this.footer.addParagraph(image.Paragraph);
this.footer.add(image.Paragraph);
return this;
}
@ -47,7 +43,7 @@ export class FooterWrapper {
): Paragraph {
const image = Media.addImage(this, buffer, width, height, drawingOptions);
const paragraph = new Paragraph(image);
this.addParagraph(paragraph);
this.add(paragraph);
return paragraph;
}

10
src/file/footer/footer.ts
View File

@ -36,13 +36,7 @@ export class Footer extends InitializableXmlComponent {
return this.refId;
}
public addParagraph(paragraph: Paragraph): Footer {
this.root.push(paragraph);
return this;
}
public addTable(table: Table): void {
this.root.push(table);
public add(item: Paragraph | Table): void {
this.root.push(item);
}
}

4
src/file/header-wrapper.spec.ts
View File

@ -10,7 +10,7 @@ describe("HeaderWrapper", () => {
describe("#add", () => {
it("should call the underlying header's addChildElement for Paragraph", () => {
const wrapper = new HeaderWrapper(new Media(), 1);
const spy = sinon.spy(wrapper.Header, "addChildElement");
const spy = sinon.spy(wrapper.Header, "add");
wrapper.add(new Paragraph({}));
expect(spy.called).to.equal(true);
@ -18,7 +18,7 @@ describe("HeaderWrapper", () => {
it("should call the underlying header's addChildElement for Table", () => {
const wrapper = new HeaderWrapper(new Media(), 1);
const spy = sinon.spy(wrapper.Header, "addChildElement");
const spy = sinon.spy(wrapper.Header, "add");
wrapper.add(
new Table({
rows: 1,

2
src/file/header-wrapper.ts
View File

@ -23,7 +23,7 @@ export class HeaderWrapper {
}
public add(item: Paragraph | Table): HeaderWrapper {
this.header.addChildElement(item);
this.header.add(item);
return this;
}