smartyellow/docx-js
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rename methods from addXXX to createXXX

Browse Source 
addXXX sounds like the argument should be XXX
This commit is contained in:
felipe
2017-03-08 17:49:41 +01:00
parent 0b2de737de
commit a3d2323254
2 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ts/numbering/index.ts
View File

@ -34,7 +34,7 @@ export class Numbering extends MultiPropertyXmlComponent {
this.nextId = 0; this.nextId = 0;
const abstractNumbering = this.addAbstractNumbering(); const abstractNumbering = this.createAbstractNumbering();
const level0 = new Level(0, "bullet", "•", "left"); const level0 = new Level(0, "bullet", "•", "left");
level0.addParagraphProperty(new Indent(720, 360)); level0.addParagraphProperty(new Indent(720, 360));
@ -81,16 +81,16 @@ export class Numbering extends MultiPropertyXmlComponent {
level8.addRunProperty(new RunFonts("Wingdings", "default")); level8.addRunProperty(new RunFonts("Wingdings", "default"));
abstractNumbering.addLevel(level8); abstractNumbering.addLevel(level8);
this.addConcreteNumbering(abstractNumbering); this.createConcreteNumbering(abstractNumbering);
} }
public addAbstractNumbering(): AbstractNumbering { public createAbstractNumbering(): AbstractNumbering {
const num = new AbstractNumbering(this.nextId++); const num = new AbstractNumbering(this.nextId++);
this.root.push(num); this.root.push(num);
return num; return num;
} }
public addConcreteNumbering(abstractNumbering: AbstractNumbering): Num { public createConcreteNumbering(abstractNumbering: AbstractNumbering): Num {
const num = new Num(this.nextId++, abstractNumbering.id); const num = new Num(this.nextId++, abstractNumbering.id);
this.root.push(num); this.root.push(num);
return num; return num;

20
ts/tests/numberingTest.ts
View File

@ -46,32 +46,32 @@ describe("Numbering", () => {
}); });
}); });
describe("#addAbstractNumbering", () => { describe("#createAbstractNumbering", () => {
it("returns a new AbstractNumbering instance", () => { it("returns a new AbstractNumbering instance", () => {
const a2 = numbering.addAbstractNumbering(); const a2 = numbering.createAbstractNumbering();
expect(a2).to.be.instanceof(AbstractNumbering); expect(a2).to.be.instanceof(AbstractNumbering);
}); });
it("assigns a unique ID to each abstract numbering it creates", () => { it("assigns a unique ID to each abstract numbering it creates", () => {
const a2 = numbering.addAbstractNumbering(); const a2 = numbering.createAbstractNumbering();
const a3 = numbering.addAbstractNumbering(); const a3 = numbering.createAbstractNumbering();
expect(a2.id).not.to.equal(a3.id); expect(a2.id).not.to.equal(a3.id);
}); });
}); });
describe("#addConcreteNumbering", () => { describe("#createConcreteNumbering", () => {
it("returns a new Num instance with its abstract ID set to the AbstractNumbering's ID", () => { it("returns a new Num instance with its abstract ID set to the AbstractNumbering's ID", () => {
const a2 = numbering.addAbstractNumbering(); const a2 = numbering.createAbstractNumbering();
const n = numbering.addConcreteNumbering(a2); const n = numbering.createConcreteNumbering(a2);
expect(n).to.be.instanceof(Num); expect(n).to.be.instanceof(Num);
const tree = new Formatter().format(numbering); const tree = new Formatter().format(numbering);
expect(n.id).to.equal(a2.id); expect(n.id).to.equal(a2.id);
}); });
it("assigns a unique ID to each concrete numbering it creates", () => { it("assigns a unique ID to each concrete numbering it creates", () => {
const a2 = numbering.addAbstractNumbering(); const a2 = numbering.createAbstractNumbering();
const n = numbering.addConcreteNumbering(a2); const n = numbering.createConcreteNumbering(a2);
const n2 = numbering.addConcreteNumbering(a2); const n2 = numbering.createConcreteNumbering(a2);
expect(n.id).not.to.equal(n2.id); expect(n.id).not.to.equal(n2.id);
}); });
}); });