From a3d2323254967b80cb13012d54b0e345761ab24c Mon Sep 17 00:00:00 2001 From: felipe Date: Wed, 8 Mar 2017 17:49:41 +0100 Subject: [PATCH] rename methods from addXXX to createXXX addXXX sounds like the argument should be XXX --- ts/numbering/index.ts | 8 ++++---- ts/tests/numberingTest.ts | 20 ++++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/ts/numbering/index.ts b/ts/numbering/index.ts index 93acc3e3b6..d840e8cfe5 100644 --- a/ts/numbering/index.ts +++ b/ts/numbering/index.ts @@ -34,7 +34,7 @@ export class Numbering extends MultiPropertyXmlComponent { this.nextId = 0; - const abstractNumbering = this.addAbstractNumbering(); + const abstractNumbering = this.createAbstractNumbering(); const level0 = new Level(0, "bullet", "•", "left"); level0.addParagraphProperty(new Indent(720, 360)); @@ -81,16 +81,16 @@ export class Numbering extends MultiPropertyXmlComponent { level8.addRunProperty(new RunFonts("Wingdings", "default")); abstractNumbering.addLevel(level8); - this.addConcreteNumbering(abstractNumbering); + this.createConcreteNumbering(abstractNumbering); } - public addAbstractNumbering(): AbstractNumbering { + public createAbstractNumbering(): AbstractNumbering { const num = new AbstractNumbering(this.nextId++); this.root.push(num); return num; } - public addConcreteNumbering(abstractNumbering: AbstractNumbering): Num { + public createConcreteNumbering(abstractNumbering: AbstractNumbering): Num { const num = new Num(this.nextId++, abstractNumbering.id); this.root.push(num); return num; diff --git a/ts/tests/numberingTest.ts b/ts/tests/numberingTest.ts index fef296f69d..bdd1452073 100644 --- a/ts/tests/numberingTest.ts +++ b/ts/tests/numberingTest.ts @@ -46,32 +46,32 @@ describe("Numbering", () => { }); }); - describe("#addAbstractNumbering", () => { + describe("#createAbstractNumbering", () => { it("returns a new AbstractNumbering instance", () => { - const a2 = numbering.addAbstractNumbering(); + const a2 = numbering.createAbstractNumbering(); expect(a2).to.be.instanceof(AbstractNumbering); }); it("assigns a unique ID to each abstract numbering it creates", () => { - const a2 = numbering.addAbstractNumbering(); - const a3 = numbering.addAbstractNumbering(); + const a2 = numbering.createAbstractNumbering(); + const a3 = numbering.createAbstractNumbering(); expect(a2.id).not.to.equal(a3.id); }); }); - describe("#addConcreteNumbering", () => { + describe("#createConcreteNumbering", () => { it("returns a new Num instance with its abstract ID set to the AbstractNumbering's ID", () => { - const a2 = numbering.addAbstractNumbering(); - const n = numbering.addConcreteNumbering(a2); + const a2 = numbering.createAbstractNumbering(); + const n = numbering.createConcreteNumbering(a2); expect(n).to.be.instanceof(Num); const tree = new Formatter().format(numbering); expect(n.id).to.equal(a2.id); }); it("assigns a unique ID to each concrete numbering it creates", () => { - const a2 = numbering.addAbstractNumbering(); - const n = numbering.addConcreteNumbering(a2); - const n2 = numbering.addConcreteNumbering(a2); + const a2 = numbering.createAbstractNumbering(); + const n = numbering.createConcreteNumbering(a2); + const n2 = numbering.createConcreteNumbering(a2); expect(n.id).not.to.equal(n2.id); }); });