Since it's unspecified where these are output on the page - and they get rendered once for each panel - there's no reason why we can't just output them as part of the panel rendering itself.
- add documentation for WAGTAILADMIN_BASE_URL
- ensure that WAGTAILADMIN_BASE_URL is used via a util so that it can fallback from request
- resolves #3248
- remove settings URL from pagination template - not required for query string URLs
let's revisit this optimization in a different PR, since there is no
explicit requirements.txt in the project as such. We will need a slighly
different approach with this.
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Github actions have a new release and pip cache was not enabled.
Both of these will make the CI run faster.
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This improves the CI experience as it will run the github checks in a
group and at the same time cancel in progress jobs if a new commit is
pushed for the pull request.
No only does it makes the contributing experience nice, but it also
saves tonnes of energy.
- Github Issue: #8276
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This creates an explicit demarcation between methods/properties that are only valid on fully bound panels (such as render_as_field) and those that should be called when only the model is bound (such as get_form_options). This surfaces two bugs where this was not enforced properly:
* in the create_log_entries_from_revisions scheduled task, we were calling get_comparison on an unbound EditHandler; we don't have a form or request to pass here, but we still need to call bind_to (with None for those values);
* BaseCompositeEditHandler overwrites its `children` attribute with the bound versions, so calling get_form_options is invalid after that point. Maintain distinct children and unbound_children attributes instead.
