0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Commit Graph

11195 Commits

Author SHA1 Message Date
jacobtoppm
2db89a08d4 Add missing comment management form data to tests 2021-04-20 18:25:30 +01:00
jacobtoppm
4980de37f6 Import formatting 2021-04-20 18:25:30 +01:00
jacobtoppm
54ce2f067f Remove 'SHOW_RESOLVED_COMMENTS' string 2021-04-20 18:25:30 +01:00
jacobtoppm
2079e65001 Add tests for CommentPanel and reformat 2021-04-20 18:25:30 +01:00
jacobtoppm
2cc4bfdc27 Remove references to revision_resolved 2021-04-20 18:25:30 +01:00
jacobtoppm
59e8a9fd36 Extract comment instances from the form, not the page instance, so unsaved comments are not lost in case the form was invalid and didn't save 2021-04-20 18:25:30 +01:00
jacobtoppm
a482cf2cea Make comments output themselves in a formset in the edit view 2021-04-20 18:25:30 +01:00
jacobtoppm
15e58f38a7 Add user to comment instance when cleaning data, rather than when saving. This will allow comment instances with users to be extracted from the form instances, should the form fail to save 2021-04-20 18:25:30 +01:00
jacobtoppm
83167456b5 Update revision_created when saving new comments 2021-04-20 18:25:30 +01:00
jacobtoppm
a7a92a3106 Load comments from database to frontend. Ensure annotations are shown correctly by removing u-hidden class 2021-04-20 18:25:30 +01:00
jacobtoppm
c8278956b3 Remove hardcoded comments div 2021-04-20 18:25:30 +01:00
jacobtoppm
1ca48eb31f Add structure of CommentPanel to initialize the comment app in the frontend, and add forms to validate comments on save. (Comments are not yet output or written to the db) 2021-04-20 18:25:30 +01:00
jacobtoppm
9a48221d66 Change comments to use ParentalKeys, so they can easily be saved with the page. Ensure they are treated on the 'page' rather than 'revision' level. Remove unnecessary revision_resolved field, as resolved comments will now simply be deleted 2021-04-20 18:25:30 +01:00
Jacob Topp-Mugglestone
2ab917bc92 Feature/field comment frontend (#6530)
* Initial working version of comment frontend in edit view

* Make comment js text translatable

* Add comment icon

* Basic hardcoded comment adding widget

* Create widget object and register it with the comment app to subscribe to updates about related annotations and whether comments are shown

* Add data-contentpath attributes to field (and data-contentpath-disabled to fields which prevent a stable contentpath existing at this point - ie ListBlock block positions are not uniquely identified), and to ensure newly generated streamfield blocks also have a stable contentpath identifiable from the frontend, make streamfield uuids generate clientside

* Make comments detect new contentpaths, and move hardcoded comment widget on chooser template into js initialisation, also making new comment buttons init properly in new streamfield blocks

* Fix tests to expect contentpaths

* Remove two step comment widget initialisation, and replace with stored callbacks for widgets that try to initialise themselves before the comment app itself. Refactor widgets to receive the makeComment function directly from the commenting system via an onRegister method to accommodate this

* Use object argument instead of positional for FieldLevelCommentWidget constructor

* Use json_script to pass author to the comments system
2021-04-20 18:25:30 +01:00
jacobtoppm
ab3c8d7d3d [Comments] Initial models (#6405)
Add initial comment models, tests, and logic for updating comment foreignkeys when revisions are deleted
2021-04-20 18:25:30 +01:00
Tom Dyson
b48c6dab58 Replace Divio with Gitpod
The Divio demo environment no longer exists, as far as I can tell.
2021-04-20 17:19:33 +01:00
Coen van der Kamp
3b24868bf2 Add release note about reporting theme issues 2021-04-20 12:31:26 +02:00
Coen van der Kamp
3b3ae52509 Add Sphinx theme changelog and release notes 2021-04-20 11:45:19 +02:00
Coen van der Kamp
ed4ed7a338
Add Sphinx Wagtail Theme (#6930)
Add Sphinx Wagtail Theme
2021-04-20 11:24:17 +02:00
Matt Westcott
7a741d770f Fix draftail focus test to use a fake timer 2021-04-20 09:46:45 +01:00
Matt Westcott
f26f65a755 Convert NodeList to array before running forEach
Makes it work on IE11. Fix borrowed from https://github.com/wagtail/wagtail/pull/6109/files#r435561917
2021-04-20 09:46:45 +01:00
Matt Westcott
b1c8142181 Delay focus on draftail widget for 50ms
This avoids an IndexSizeError on IE11 https://github.com/wagtail/wagtail/pull/6968#issuecomment-822591161 , apparently due to the focus triggering a field update before it has been fully initialised.
2021-04-20 09:46:45 +01:00
Matt Westcott
f8299885aa Remove deprecated providing_args options on signals 2021-04-19 12:03:39 +01:00
Matt Westcott
db1305f94c Fix API tests with an empty order_by clause
This works around a Django bug apparently introduced in 779e615e36
2021-04-19 12:03:39 +01:00
Matt Westcott
8d008bcfaf Ignore noise from warnings in test_check_invalid_base_form_class 2021-04-19 12:03:39 +01:00
Matt Westcott
b455c659b7 Add default_auto_field to appconfigs to silence warnings 2021-04-19 12:03:38 +01:00
Matt Westcott
38f0cb44a4 Fix github action syntax 2021-04-19 12:03:38 +01:00
Matt Westcott
e99c07a42e upgrade circleci python image to see if it fixes sqlite compatibility 2021-04-19 12:03:38 +01:00
Matt Westcott
8f5a2a8fe9 Formalise support for Django 3.2
Fixes #6981
2021-04-19 12:03:38 +01:00
Ihor Marhitych
deeb771032 Save revision when restart workflow (#6990) 2021-04-19 11:02:49 +01:00
Dan Braghis
b21557319c Release notes for #6946 2021-04-19 10:49:55 +01:00
Ihor Marhitych
37f4d4bab1 Do not instantiate PagePermissionTester for every ActionMenuItem 2021-04-19 10:44:30 +01:00
Ihor Marhitych
3bf8d12298 Use fewer db queries when checking current_workflow_task 2021-04-19 10:43:18 +01:00
Matt Westcott
00aea17030 Fill in release date for 2.12.4 2021-04-19 10:10:42 +01:00
Matt Westcott
b3f3df2764 Release note for CVE-2021-29434 in 2.11.7 2021-04-19 10:09:57 +01:00
Matt Westcott
a44312f48f Release note for CVE-2021-29434 in 2.12.4 2021-04-19 09:59:01 +01:00
Matt Westcott
57ccd4a86c Disallow links with unrecognised protocols in contentstate 2021-04-19 09:49:46 +01:00
Matt Westcott
177bc51cd6 Add release notes for 2.12.4 2021-04-19 09:45:19 +01:00
Scott Cranfill
42ddd8ad55
Apply chevron padding fix to all applicable select elements (#6980)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2021-04-16 21:02:36 +01:00
Matt Westcott
f2be408f62
Fix wagtailembeds thumbnail_url migration for MySQL 8.0.13 (#6999)
* Upgrade mysql to 8.0.23 for github actions

* Fix thumbnail_url migration to work on Django 3 / MySQL 8.0.13+

Work around https://code.djangoproject.com/ticket/32503 by applying the not-null constraint before converting to TextField.
2021-04-16 21:41:32 +02:00
Thibaud Colas
88cebcd43a
Make all Collection form fields translate-able (#6739) 2021-04-16 17:31:38 +01:00
Storm Heg
e7942a05ad
Choosers: refactor to use SVG icons (#6998)
* Choosers: refactor to use SVG icons

Refactored non-deprecated choosers to use SVG icons. Custom choosers can
also supply their own svg icons using the `chosen_icon` and
`unchosen_icon` blocks.

We are keeping the relevant icon font css for custom choosers around to
prevent breaking existing custom choosers.

Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2021-04-16 15:43:13 +01:00
Matt Westcott
02ad797673 Support slicing on StreamValue (#7013)
Fixes #7012
2021-04-16 14:41:49 +01:00
Thibaud Colas
ca48709e5c
Lock nav and page scroll together only when search autocomplete is open. Fix #6935 (#7015) 2021-04-16 14:18:59 +01:00
Matt Westcott
cc9310220a Fix documentation build warnings 2021-04-15 17:17:11 +01:00
Matt Westcott
1b451ae001 placate isort 2021-04-15 16:47:27 +01:00
Martin Sandström
c0a84975e7 Add ability to export redirects using reports (#6305) 2021-04-15 16:37:05 +01:00
Karl Hobley
7423d72efe Raise an error on save if a LogEntry is created with invalid action
This is just to catch mistakes as they're made. Not intended for database consistency.
2021-04-15 14:17:22 +01:00
Karl Hobley
f2f6167f5d Allow different registries to be created for different object types 2021-04-15 14:17:17 +01:00
Karl Hobley
8a80196456 Moved LogActionRegistry into wagtailcore
Since logs are generated and stored in wagtailcore, I think it makes
sense for the list of available actions to be managed there too.
2021-04-15 13:58:02 +01:00