0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

3682 Commits

Author SHA1 Message Date
Michael Matloka
c2bc2fecd0
Use proper interval calculation in the funnel trends query (#5467)
* Use proper interval calculation in the funnel trends query

* Add some comments

* Update `test_filter`

* Rework `NULL_SQL` to use CH `INTERVAL` too

* Fix week-based relative `date_from` support not existing

* Make use of `toInterval*` functions and inject less

* Add fallback for `date_from` in `ClickhouseSessionsAvg`
2021-08-06 11:29:35 +02:00
James Greenhill
397d10a9d8
Have migration task bypass pgbouncer and connect direct to pg for session stickiness (#5479)
* Have migration task bypass pgbouncer and connect direct to pg for session stickiness

* change USING_PGBOUNCER to false and remove duplicate
2021-08-06 09:27:49 +03:00
Karl-Aksel Puulmann
049c41868e
Hide time-to-convert when using breakdown (#5476) 2021-08-05 14:05:17 -07:00
Karl-Aksel Puulmann
a1dd96e47d
Improve cached_property typing (#5465)
* Improve cached_property typing

Noticed that e.g. `filter.breakdown` was getting inferred to be `Any`
which is not correct. Added generics to fix it :)

* Proposed fix: make filter_test_accounts return a bool always

* Fix warning in clickhouse_sessions.py

* Cast in session.events

* Cast 2x in funnel queries

* Ignore error in session recording

We know the valid values here

* Add assertions in stickiness filters

* Cast in more funnel queries

* Untyped dict where inferred type is wrong

* Add types to abstract methods

* Type prop_vals

* Add a lot of casts

These are correct. We should really validate while parsing instead

* Add more casts to funnel trends

* Last fixes
2021-08-05 22:31:31 +03:00
Michael Matloka
5c1408fac7
Provide more informational invalid regex message (#5456)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-05 19:10:05 +00:00
Michael Matloka
fd0ff16c9b Fix link to building a plugin
Glossed over in #5448.
2021-08-05 17:44:48 +02:00
Yakko Majuri
1f2458eaaf
Add more contrast between official and community plugins (#5448)
* update plugins repo tab

* Make it clear when plugins are built by the community
2021-08-05 17:37:11 +02:00
posthog-contributions-bot[bot]
b6f325f263
🤖: Add jredl-va as a contributor 🎉 (#5470)
* docs: update README.md

* docs: update .all-contributorsrc

Co-authored-by: posthog-contributions-bot[bot] <80958034+posthog-contributions-bot[bot]@users.noreply.github.com>
2021-08-05 17:06:11 +02:00
Li Yi Yu
cd94321cba
Saved insights default page (#5416) 2021-08-05 07:38:07 -07:00
Karl-Aksel Puulmann
4260cc868f
Make timer safe (#5469)
Supercedes https://github.com/PostHog/posthog/pull/5468
2021-08-05 16:58:21 +03:00
Karl-Aksel Puulmann
bc49811e06
Update query metrics (#5460)
Previous change made it really hard to calculate failure %, fixing...
2021-08-05 13:12:52 +03:00
Marcus Hyett (PostHog)
cca46b2f80
Automatically Persist Filter Value on Blur (#5373)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
Co-authored-by: Alex Kim <alexgkim205@gmail.com>
2021-08-05 10:04:33 +00:00
Michael Matloka
e48bd8b08b
Allow "new member" email opt-out (#5430) 2021-08-04 18:09:41 -07:00
Michael Matloka
a163b84974
Hotfix crashing Home (#5454) 2021-08-05 01:00:34 +02:00
Paolo D'Amico
76bbf7f4df
Better insights instrumentation (#5432)
* report from dashboard on insight viewed

* report person modal

* abstract filter sanitization and report cohort creation

* report insight viewed after 10s

* change to insight analyzed
2021-08-04 14:45:14 -07:00
Alex Gyujin Kim
5d8bc03e29
Beef up warning funnel empty state message (#5434)
* standardize warning funnel empty state

* change color and icon
2021-08-04 13:16:42 -07:00
Marius Andra
3f70dcd857
Add urls to programmatically create routes (#4656)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-04 12:31:14 -07:00
PostHog bot
1a8d14010a
Update posthog-js to 1.12.3 (#5446)
Co-authored-by: posthog-bot <posthog-bot@users.noreply.github.com>
2021-08-04 19:34:03 +02:00
Karl-Aksel Puulmann
d4f246ecab
Make breakdowns + formulas work (#5444)
* Use f-strings in trends/formula

* Make formulas and breakdowns work

Closes issue https://github.com/PostHog/posthog/issues/5390

Previously the query returned a 500 for some breakdowns, with the error
`Arrays passed to arrayMap must have equal size: while executing 'FUNCTION arrayMap`

The issue came from the different subqueries having different breakdowns
- some would break down with values A and B and other would have B and C

After the full outer join, arrays for breakdown values A and C would be empty in some cases. Filling them with zeroes fixes the issue.
2021-08-04 19:32:00 +03:00
dependabot[bot]
cd2dcddc9a
Bump tar from 6.1.0 to 6.1.3 in /plugins (#5436)
Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.3.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.1.0...v6.1.3)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-04 09:27:34 -07:00
Alex Gyujin Kim
c22f66ca33
Synchronous dashboard refreshes (#5407)
* add synchronous dashboard refresh all items

* add auto reload dropdown

* fix trigger bounds

* small fixes

* refresh width

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-04 08:48:00 -07:00
Eric Duong
24a708c259
Funnel trends all date range (#5420)
* implementation and test

* change to escape params
2021-08-04 10:33:39 -04:00
Karl-Aksel Puulmann
d25fa2c2d5
Fix "filter test accounts via cohort" filter (#5442)
Closes https://github.com/PostHog/posthog/issues/5441
2021-08-04 11:44:45 +01:00
PostHog bot
92f5f9f831
Update plugin server to 1.1.11 (#5435) 2021-08-03 22:19:37 +01:00
Paolo D'Amico
5e0fe12471
View graph in dashboards is now a link (#5418) 2021-08-03 17:15:35 +00:00
posthog-contributions-bot[bot]
95263945bf
🤖: Add purcell3a as a contributor 🎉 (#5429)
* docs: update README.md

* docs: update .all-contributorsrc

Co-authored-by: posthog-contributions-bot[bot] <80958034+posthog-contributions-bot[bot]@users.noreply.github.com>
2021-08-03 17:56:28 +02:00
Michael Matloka
30508bada4
Fix days-before-pr-close 2021-08-03 16:38:09 +02:00
Neil Kakkar
5d3eb59807
Update default breakdown limit in funnels (#5426)
* Update default breakdown limit in funnels

https://github.com/PostHog/posthog/issues/5341#issuecomment-891743574

* update test

* add default to breakdown limit property

* address comments
2021-08-03 14:18:20 +01:00
Karl-Aksel Puulmann
420e1f4938
Simplify debugging funnels via sentry (#5424)
Sentry lists local variables (including self) in the query. To debug
anything you need a simple way to get to the query, which this now
exposes.

Not the prettiest solution - other ideas welcome!
2021-08-03 15:06:44 +02:00
Karl-Aksel Puulmann
e8a429c9ed
Quality-of-life: Autoimport filter + sync_execute into shell_plus (#5425)
This saves some typing every time one opens `python manage.py
shell_plus`
2021-08-03 11:15:30 +00:00
Karl-Aksel Puulmann
2940dfee96
Fix "ambigious column distinct_id" (#5423)
* Fix "ambigious column distinct_id"

The problem came in a trends query:
1. Which filters by action having person property filters
2. The overall query having a person property filter

See also the regression test

Closes https://github.com/PostHog/posthog/issues/5388

* Add calculate_events call
2021-08-03 11:55:02 +01:00
Neil Kakkar
a5d9953dc1
Make Breakdown limit customizable and Allow empty breakdown value in trends and funnels (#5357)
* breakdown limits update

* include null in limit

* clean breakdowns for trends & peeps
2021-08-03 10:59:09 +01:00
Karl-Aksel Puulmann
37753fed89
Kill api/person/references method (#5365)
This was added in https://github.com/PostHog/posthog/pull/1202, but
seems to be dead.

The usecase seems to have been removed in https://github.com/PostHog/posthog/pull/2669
2021-08-03 10:20:10 +03:00
Michael Matloka
077f6f13bb
Complete move to 4px border radius (#5414) 2021-08-02 19:57:08 -07:00
Alex Gyujin Kim
a797e5d09c
Add an empty state for funnels and property filter arrow fix (#5422)
* refactor render function

* fix extra arrow in property filters

* remove consoles
2021-08-03 01:54:17 +00:00
Michael Matloka
cc499d8fbc
Show sortable webhook status column in ActionsTable (#5415) 2021-08-02 21:44:25 +00:00
Paolo D'Amico
617ded5b80
Don't pin dashboards by default (#5419)
* Don't pin dashboards by default

* E2E test
2021-08-02 20:27:39 +00:00
Michael Matloka
91aa0b15c1
Remove AsyncActionMappingNotice (#5417) 2021-08-02 16:48:53 -03:00
Alex Gyujin Kim
2c1cf157f2
Center person uuids in modals (#5413) 2021-08-02 19:32:03 +00:00
Paolo D'Amico
a30d3e92e8
Funnel improvements - Graph type, identical steps, UI updates (#5384)
Co-authored-by: Alex Kim <alexgkim205@gmail.com>
2021-08-02 18:57:46 +00:00
Neil Kakkar
73d85c9aa0
Allow mix-n-matching Funnel types in cache update (#5399)
* allow mix-n-matching in cache update

* tests for cache calling
2021-08-02 17:55:31 +01:00
Paolo D'Amico
ce2c9a2f90
Random insights improvements (#5406) 2021-08-02 09:44:44 -07:00
Paolo D'Amico
0a46442b3d
Fix session recording navigation from persons page (#5404)
* fix close recording player from persons

* set proper tab when watching a recording
2021-08-02 07:31:05 -07:00
Neil Kakkar
796fa106fe
Add missing interval value (#5398) 2021-08-02 14:25:13 +01:00
PostHog bot
7f82ebff51
Update posthog-js to 1.12.2 (#5408) 2021-08-02 12:54:56 +01:00
Alex Gyujin Kim
58706cc68d
Add bin counts dropdown to Funnel Time Conversion (#5246)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-30 19:35:43 +00:00
Alex Gyujin Kim
105f99f5ef
Fix SI units less than 1 on time to convert (#5403) 2021-07-30 12:19:21 -07:00
Li Yi Yu
e245cfbd93
Allow formulas for single graph series again (#5400)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-30 19:06:36 +00:00
Kunal
92642421aa
Add a syntax example for HTML attribute based actions (#5362)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-30 17:40:27 +00:00
Paolo D'Amico
0470359f1c
Maintain default feature flags behavior on cloud (#5296) 2021-07-30 10:37:29 -07:00