0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-22 08:40:03 +01:00
Commit Graph

3585 Commits

Author SHA1 Message Date
Marius Andra
19d9fcc9ed
Funnel default event (#5280)
* get default event name directly from django

* default event name in the backend

* fix "~/" urls in jest tests

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-22 17:57:41 +02:00
Li Yi Yu
bfb1a001b1
do not allow persons modal opening on dashboard item view (#5286) 2021-07-22 15:45:07 +00:00
Li Yi Yu
d7e4563065
Show funnel empty state on Steps if less than 2 steps (#5284)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-22 15:17:52 +00:00
Neil Kakkar
ca724e1f81
Resolve errors with time to convert bins (#5283)
* time to convert test

* rworkaround for time to convert bins

* address comment
2021-07-22 14:04:05 +00:00
Marius Andra
9d5dd47ef9
Add PERSISTED_FEATURE_FLAGS env (#5273)
* add PERSIST_FEATURE_FLAGS env

* improve handling of persisted flags

* release three flags

* add missing feature flag constants

* rename to PERSISTED feature flags

* remove flags
2021-07-22 13:12:32 +00:00
Li Yi Yu
9b69a71e6d
Fix persons modal load more people (#5271)
* count display update

* do not reload list of people when loading more people

* Revert "do not reload list of people when loading more people"

This reverts commit eb9ef11690.

* fix flag

* separate initial loading state

* update title with "+", fix person/persons

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-22 13:49:57 +02:00
Neil Kakkar
b8c946cf99
Fix Funnel Trends Persons with month/week granularity (#5277)
* resolve #5275

* address comment
2021-07-22 11:49:15 +00:00
Karl-Aksel Puulmann
211c6e762f
Add migration for distinct_id column on clickhouse person table (#5276)
* Add migration for `distinct_id` column on clickhouse

Note that code under ee/clickhouse/models/person.py does not work
anymore since it does not populate the column correctly. That is fine -
will be handled when doing the actual migration, rather than for this
experiment.

* Update plugin server to 1.1.8

Co-authored-by: posthog-bot <posthog-bot@users.noreply.github.com>
2021-07-22 14:30:12 +03:00
Alex Gyujin Kim
e1a2420801
Fix funnels time to convert dashboard item height (#5259)
* improve funnel dashboards

* histogram fits dashboard

* cache time conversion results

* fix histograms on dashboard

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-22 09:47:37 +00:00
Neil Kakkar
a0b99facec
Fix issues with step conversion times (#5174)
* general conversion time cases

* clean cases

* remove ch bug test for now
2021-07-22 09:31:47 +01:00
Marius Andra
4b97398650
Fix Mix - z-index & multiple cohorts in breakdown (#5270)
* improve popup z-index

* fix popup and other antd z-indices

* extract button from component

* can select multiple numbers for breakdown

* taxonomic breakdown supports multiple cohorts
2021-07-22 10:06:11 +02:00
Eric Duong
39416b7e94
Revert "Run broken down analyses with a single SQL query (#5186)" (#5272)
This reverts commit 3e5b073ade.
2021-07-21 19:29:27 -04:00
Paolo D'Amico
75d50e30a3
Release new tooltips #4156 (#5267)
* release InsightsTableV2

* release graphs new UI
2021-07-21 22:48:51 +02:00
Paolo D'Amico
326453975b
Update global button styles (#5266) 2021-07-21 13:36:38 -05:00
Paolo D'Amico
700f5bc0b5
Improvements to Persons Modal (#5264) 2021-07-21 13:08:52 -05:00
Michael Matloka
3e5b073ade
Run broken down analyses with a single SQL query (#5186)
* Remove unused imports

* Rework breakdowns for CTEs instead of separate queries

* Increase happiness of mypy

* Fix formula trends

* remove repeated team_condition

* remove print

Co-authored-by: eric <eeoneric@gmail.com>
2021-07-21 14:00:34 -04:00
Li Yi Yu
d4f965d8cf
Unblock funnel persons table for non clickhouse (#5263) 2021-07-21 12:45:08 -05:00
Marius Andra
61ee7e7bbf
Fix feature flag proxy JSON serialization bug (#5257) 2021-07-21 11:46:48 -05:00
Li Yi Yu
4f30c89293
funnel trends doesn't have average time conversion? (#5256) 2021-07-21 16:32:05 +00:00
Marius Andra
802ccf3e47
fix white screen when directly opening funnels (#5258) 2021-07-21 16:22:35 +00:00
Tim Glaser
c442bf9812
Remove Pie as an option for stickiness (#5254) 2021-07-21 16:04:19 +00:00
Li Yi Yu
e899491507
Funnel trends is clickhouse only (#5252)
* funnel trends is clickhouse only

* don't show graph type if there's only one option

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-21 15:32:49 +00:00
Marius Andra
a414250866
Improve funnel dashboards (#5253) 2021-07-21 10:28:34 -05:00
Marius Andra
3764ea22c9
carry event and action filters between tabs (#5250) 2021-07-21 16:27:29 +02:00
Marius Andra
11476f5f0a
More funnel fixes (#5248)
* fix funnel reload bug with changed filters

* remove the type so we could autocomplete feature flag strings

* hide breakdown from time & trends graphs, remove the param when switching to them for safety

* positive check

* clarify arg name

* remove needless flag

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-21 15:55:25 +02:00
Li Yi Yu
bd36c7f82a
Handle persons modal navigation better (#5236)
* handle persons modal navigation better

* clean up excess pesronModal actions/values, move people to loader

* fix person modal not opening on funnels

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-21 15:12:28 +02:00
Paolo D'Amico
6b11dcf7b3
Nail funnels on dashboards (#5228)
* steps with breakdown is already validated

* finally make dashboards render 🙌

* abstract new funnels from FunnelViz component

* refactor basic styles

* post-merge fix

* fix text overflow in event name

* funnels base UI on dashboard

* disable bar tooltip on dashboard

* Revert "disable bar tooltip on dashboard"

This reverts commit 4ba814ff2e.

* fix auto height on dashboards

* colored dashboards support

* full color support

* set layout as a filter param

* save funnel layout on backend

* proper scrolling in dashboards

* restore average conversion time

* only one layout for histograms

* fix bar graph margin that's causing a scrollbar

* fix person modal not opening on funnels

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-21 13:27:32 +02:00
Alex Gyujin Kim
54eefdfb90
Fixes various time conversion bugs (#5243)
* various time conversion bugs

* pass real network "Error"s to endQuery in order to show an error on 500

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-21 09:47:34 +00:00
Pankaj Patil
c6080bd6b6
Fix: Funnel drop off user list title is confusing (/buggy?) (#5227)
* Fix:Funnel drop off user list title is confusing (/buggy?)

* Handle Negative Step

* Conditionally Render The String

* Update frontend/src/scenes/funnels/funnelLogic.ts

Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>

* prettier

Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-21 10:17:55 +02:00
Alex Gyujin Kim
f9cd157ca8
Revert "Fix CH no data blocker (#5238)" (#5239)
This reverts commit babf93b413.
2021-07-21 06:38:08 +00:00
Alex Gyujin Kim
babf93b413
Fix CH no data blocker (#5238) 2021-07-21 05:23:35 +00:00
Eric Duong
9bb66c53bd
Engagement cohorts UI (#4574)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-20 20:49:35 -05:00
Tim Glaser
4e3faae3ee
Change global filters to filters (#5117)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-20 17:48:20 -05:00
Marius Andra
752e331709
Small frontend undefined fixes (#5222)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-20 12:47:55 -05:00
Tim Glaser
f6ed4f9a65
Warn when exiting plugin source edit with changes (#5226) 2021-07-20 12:41:11 -05:00
Eric Duong
cedf33c891
Add median time for funnel conversion data (#5203)
* add median time for conversion steps

* patch tests

* fix time to convert funnel query

* fix strict and unordered

* add median conversion time to base

* fix

* more tests
2021-07-20 13:36:22 -04:00
Li Yi Yu
13cbf9f2a7
Enable persons modal on funnel trends (#5133)
* funnel trends persons call

* hide nonfunctioning funnel graph display options

* undo date year conversion

* avoid forced typing

* clean up and add comment

* use funnel_viz_type param for funnel graphs

* fix funnel_viz_type param router replacement bug

* fix types and potential display param bug

* funnel trends should not be an option for non-clickhouse

* reuse existing filters

* patch white screen death bug

* type predicate

* undo prettier
2021-07-20 13:21:35 -04:00
Eric Duong
993278ad46
Fix single cohort bug (#5225)
* fix single cohort bug

* fix test name
2021-07-20 16:27:41 +00:00
Eric Duong
8b6b6ae9bb
Fix broken funnel pagination (#5178)
* fix broken funnel pagination

* account for both return results

* add limit param

* move order

* move the check

* change magic number

* adjust more tests
2021-07-20 11:34:15 -04:00
Sam Winslow
5392aabb23
Hotfix for funnel historical trends & histogram being always hidden (#5224)
* selector for showBarGraph

* use Funnel component
2021-07-20 14:18:13 +00:00
PostHog bot
24b78ef1ff
Update plugin server to 1.1.7 (#5221) 2021-07-20 14:03:28 +01:00
Sam Winslow
60cbf2e7c1
Trigram fuzzy search for property definitions (#5039)
* Trigram fuzzy search for property definitions

* support empty search param

* Only use pg_trgm search if pg extension is installed

* suppress exceptions if migration does not succeed

* checks for index

* troubleshooting

* wip: change migration number; strip out conditionals

* wip: copy code from #4110

* remove is_pg_trgm_installed

* try ngram search on CH

* add AND before ngram

* correct some check failures

* remove ordering

* remove ordering from tests

* fix ordering

* rewrite queries for psql, add test bypass for EE features

* remove ordering filter bc of bugs

* remove test code

* check if isinstance of RawQuerySet

* cleanup sql

* add ordering

* typing

* test for ee prop definition

* adjustments to test_ee_property_definition

* add test_ee_event_definition

* restore this prop

* convert to simple term filter

* use term search in EE

* fix EE tests

* fix non-EE tests

* fix test

* fix filter types

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-07-20 14:58:16 +02:00
Tim Glaser
9282c9a5f5
Reload actions once one is created (#5219) 2021-07-20 14:11:57 +02:00
Tim Glaser
5afb7e5129
Upgrade Django to 3.2.5 (#5198) 2021-07-20 12:09:12 +02:00
Michael Matloka
72f67b1fc4
Fix funnel trends step indexes (#5172)
* Fix funnel trends `to_step` default

* Make steps 0-indexed in funnel trends too
2021-07-20 11:06:24 +01:00
James Greenhill
1c1d4a11cd
bump clickhouse_orm version (#5217) 2021-07-19 20:59:56 -07:00
Karl-Aksel Puulmann
fc5c6476a0
Revert "Revert "Add is_deleted column to person_distinct_id"" (#5194)
* Revert "Revert "Add is_deleted column to person_distinct_id (#5151)" (#5193)"

This reverts commit 401268bdba.

* A tweak for docker-compose builds

Co-authored-by: James Greenhill <fuziontech@gmail.com>
2021-07-19 19:47:41 -07:00
Paolo D'Amico
02a09adef1
Funnel improvements IV (#5205) 2021-07-19 19:29:16 -05:00
Alex Gyujin Kim
5b4dd777e1
fix global filters dropdown (#5214) 2021-07-19 22:58:39 +00:00
Alex Gyujin Kim
39303ebf69
Fix no funnel time conversion (#5212)
* remove duplicate timeConversionBins kea value and always end query

* put back isbreakpoint check
2021-07-19 22:55:20 +00:00