mirror of https://github.com/nodejs/node.git synced 2024-11-25 08:19:38 +01:00

Gabriel Schulhof 7a216d5fd6

node-api: segregate nogc APIs from rest via type system

We define a new type called `node_api_nogc_env` as the `const` version
of `napi_env` and `node_api_nogc_finalize` as a variant of
`napi_finalize` that accepts a `node_api_nogc_env` as its first
argument.

We then modify those APIs which do not affect GC state as accepting a
`node_api_nogc_env`. APIs accepting finalizer callbacks are modified to
accept `node_api_nogc_finalize` callbacks. Thus, the only way to attach
a `napi_finalize` callback, wherein Node-APIs affecting GC state may be
called is to call `node_api_post_finalizer` from a
`node_api_nogc_finalize` callback.

In keeping with the process of introducing new Node-APIs, this feature
is guarded by `NAPI_EXPERIMENTAL`. Since this feature modifies APIs
already marked as stable, it is additionally guared by
`NODE_API_EXPERIMENTAL_NOGC_ENV`, so as to provide a further buffer to
adoption. Nevertheless, both guards must be removed upon releasing a
new version of Node-API.

PR-URL: https://github.com/nodejs/node/pull/50060
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

2023-12-19 07:37:15 +00:00

7.1 KiB

Raw Blame History

Node.js Node-API version release process

This document describes the technical aspects of the Node.js Node-API version release process.

How to create a release

How to create a release

Notes:

Version strings are listed below as "vx" or "x". Substitute for the release version.
Examples will use the integer release version 10.

0. Pre-release steps

Before preparing a Node.js Node-API version release, the Node-API Working Group must be notified at least one business day in advance of the expected release.

Node-API Working Group can be contacted best by opening up an issue on the abi-stable-node issue tracker.

1. Update the main Branch

Checkout the staging branch locally.

git remote update
git checkout main
git reset --hard upstream/main

If the staging branch is not up to date relative to main, bring the appropriate PRs and commits into it.

2. Create a new branch for the release

Create a new branch named node-api-x-proposal, off the main branch.

git checkout -b node-api-10-proposal upstream/main

3. Update `NODE_API_SUPPORTED_VERSION_MAX`

Set the version for the proposed release using the following macros, which are already defined in src/node_version.h:

#define NODE_API_SUPPORTED_VERSION_MAX x

Note: Do not update the NAPI_VERSION defined in src/js_native_api.h. It is a fixed constant baseline version of Node-API.

4. Define `addon_context_register_func`

For each new version of Node-API an else if case must be added to get_node_api_context_register_func in src/node_api.cc and the numeric literal used in the static_assert statement in that function must be updated to the new Node-API version.

5. Update version guards

Step 1. Update define version guards

If this release includes new Node-APIs that were first released in this version, the relevant commits should already include the NAPI_EXPERIMENTAL define guards on the declaration of the new Node-API. Check for these guards with:

grep                           \
  -E                           \
  'N(ODE_)?API_EXPERIMENTAL'   \
  src/js_native_api{_types,}.h \
  src/node_api{_types,}.h

and update the define version guards with the release version:

- #ifdef NAPI_EXPERIMENTAL
+ #if NAPI_VERSION >= 10

  NAPI_EXTERN napi_status NAPI_CDECL
  node_api_function(napi_env env);

- #endif  // NAPI_EXPERIMENTAL
+ #endif  // NAPI_VERSION >= 10

Remove any feature flags of the form NODE_API_EXPERIMENTAL_HAS_<FEATURE>.

Remove any additional NODE_API_EXPERIMENTAL_* guards along with NAPI_EXPERIMENTAL.

Also, update the Node-API version value of the napi_get_version test in test/js-native-api/test_general/test.js with the release version x:

  // Test version management functions
- assert.strictEqual(test_general.testGetVersion(), 9);
+ assert.strictEqual(test_general.testGetVersion(), 10);

Step 2. Update runtime version guards

If this release includes runtime behavior version guards, the relevant commits should already include NAPI_VERSION_EXPERIMENTAL guard for the change. Check for these guards with:

grep NAPI_VERSION_EXPERIMENTAL src/js_native_api_v8* src/node_api.cc

and substitute this guard version with the release version x.

Step 3. Update test version guards

If this release includes add-on tests for the new Node-APIs, the relevant commits should already include NAPI_EXPERIMENTAL definition for the tests. Check for these definitions with:

grep                                    \
  -E                                    \
  'N(ODE_)?API_EXPERIMENTAL'            \
  test/node-api/*/{*.{h,c},binding.gyp} \
  test/js-native-api/*/{*.{h,c},binding.gyp}

and substitute the NAPI_EXPERIMENTAL with the release version NAPI_VERSION x;

- #define NAPI_EXPERIMENTAL
+ #define NAPI_VERSION 10

Remove any NODE_API_EXPERIMENTAL_* flags.

Step 4. Update document

If this release includes new Node-APIs that were first released in this version and are necessary to document, the relevant commits should already have documented the new Node-API.

For all Node-API functions and types with define guards updated in Step 1, in doc/api/n-api.md, add the napiVersion: x metadata to the Node-API types and functions that are released in the version, and remove the experimental stability banner:

  #### node_api_function
  <!-- YAML
  added:
    - v1.2.3
+ napiVersion: 10
  -->

- > Stability: 1 - Experimental

Step 5. Update change history

If this release includes new Node-APIs runtime version guards that were first released in this version and are necessary to document, the relevant commits should already have documented the new behavior in a "Change History" section.

For all runtime version guards updated in Step 2, check for these definitions with:

grep NAPI_EXPERIMENTAL doc/api/n-api.md

In doc/api/n-api.md, update the experimental change history item to be the released version x:

  Change History:

- * experimental (`NAPI_EXPERIMENTAL` is defined):
+ * version 10:

6. Create release commit

When committing these to git, use the following message format:

node-api: define version x

7. Propose release on GitHub

Create a pull request targeting the main branch. These PRs should be left open for at least 24 hours, and can be updated as new commits land.

If you need any additional information about any of the commits, this PR is a good place to @-mention the relevant contributors.

Tag the PR with the notable-change label, and @-mention the GitHub team @nodejs/node-api and @nodejs/node-api-implementer.

8. Ensure that the release branch is stable

Run a node-test-pull-request test run to ensure that the build is stable and the HEAD commit is ready for release.

9. Land the release

See the steps documented in Collaborator Guide - Landing a PR to land the PR.

10. Backport the release

Consider backporting the release to all LTS versions following the steps documented in the backporting guide.

7.1 KiB Raw Blame History