mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity
6ba5af2c2c
nodejs/lib
History
Rich Trott 6ba5af2c2c console: check that stderr is writable 
`Console` constructor checks that `stdout.write()` is a function but
does not do an equivalent check for `stderr.write()`. If `stderr` is not
specified in the constructor, then `stderr` is set to be `stdout`.
However, if `stderr` is specified, but `stderr.write()` is not a
function, then an exception is not thrown until `console.error()` is
called.

This change adds the same check for 'stderr' in the constructor that is
there for `stdout`. If `stderr` fails the check, then a `TypeError` is
thrown.

Took the opportunity to copyedit the `console` doc a little too.

PR-URL: https://github.com/nodejs/node/pull/5635
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
2016-03-15 19:10:55 -07:00
..
internal lib: wrap tick_processor scripts in IIFE 2016-03-03 20:35:20 -08:00
_debug_agent.js debugger: assert test before accessing this.binding 2016-02-10 08:28:30 -08:00
_debugger.js debugger: remove unneeded callback check 2016-02-19 14:54:08 -08:00
_http_agent.js http: allow async createConnection() 2016-02-11 12:52:46 -05:00
_http_client.js lib: copy arguments object instead of leaking it 2016-03-10 18:45:08 -08:00
_http_common.js http: strictly forbid invalid characters from headers 2016-02-09 09:22:09 -08:00
_http_incoming.js http: remove old, confusing comment 2016-02-15 07:52:21 -08:00
_http_outgoing.js http: remove unnecessary check 2016-02-15 07:52:17 -08:00
_http_server.js http,util: fix typos in comments 2016-02-17 08:43:40 -08:00
_linklist.js lib,test: deprecate _linklist 2015-10-08 17:32:08 -07:00
_stream_duplex.js
_stream_passthrough.js
_stream_readable.js stream: fix no data on partial decode 2016-02-17 14:15:47 -05:00
_stream_transform.js stream: prevent object map change in TransformState 2016-02-02 13:05:04 -06:00
_stream_wrap.js stream_wrap: error if stream has StringDecoder 2015-12-06 21:55:25 -05:00
_stream_writable.js streams: 5% throughput gain when sending small chunks 2016-02-09 09:30:12 +00:00
_tls_common.js tls: scope loop vars with let 2016-01-26 20:53:05 +01:00
_tls_legacy.js lib: fix style issues after eslint update 2016-01-13 23:16:05 +01:00
_tls_wrap.js lib: copy arguments object instead of leaking it 2016-03-10 18:45:08 -08:00
.eslintrc tools: apply custom buffer lint rule to /lib only 2016-02-24 20:09:52 -08:00
assert.js lib: copy arguments object instead of leaking it 2016-03-10 18:45:08 -08:00
buffer.js buffer: add encoding parameter to fill() 2016-02-10 12:06:20 -07:00
child_process.js child_process: add shell option to spawn() 2016-01-26 19:40:43 -05:00
cluster.js cluster: emit worker as first 'message' event arg 2016-02-25 12:46:37 +01:00
console.js console: check that stderr is writable 2016-03-15 19:10:55 -07:00
constants.js
crypto.js crypto: simplify Certificate class bindings 2016-03-05 12:29:46 +01:00
dgram.js dgram: default send address to 127.0.0.1 or ::1 2016-03-05 19:20:31 +01:00
dns.js dns: add resolvePtr to query plain DNS PTR records 2016-02-08 17:30:38 +01:00
domain.js domains: clear stack when no error handler 2016-01-13 10:55:15 -08:00
events.js events: add eventNames() method 2016-03-15 09:25:35 -07:00
fs.js fs: improve error message for invalid flag 2016-03-09 12:27:54 -08:00
http.js lib,src: remove usage of events.EventEmitter 2015-09-23 00:23:08 +05:30
https.js https: evict cached sessions on error 2016-02-01 21:52:04 -05:00
module.js module: refactor redeclared variable 2016-01-31 19:16:09 +01:00
net.js net: make isIPv4 and isIPv6 more efficient 2016-03-15 08:32:32 -07:00
os.js lib: remove unused modules 2015-12-25 13:05:23 -08:00
path.js path: fix normalize for absolutes 2016-03-07 14:48:49 -06:00
process.js
punycode.js
querystring.js querystring: improve escape() performance 2016-02-12 20:00:22 -05:00
readline.js readline: Remove XXX and output debuglog 2016-01-18 07:57:55 -08:00
repl.js repl: fix stack trace column number in strict mode 2016-02-29 10:46:31 +01:00
stream.js lib,src: remove usage of events.EventEmitter 2015-09-23 00:23:08 +05:30
string_decoder.js string_decoder: fix performance regression 2016-02-11 10:41:49 -05:00
sys.js
timers.js timers: greatly improve code comments 2016-02-26 18:07:36 -05:00
tls.js lib,test: remove extra semicolons 2016-01-16 19:54:25 +01:00
tty.js lib: remove unused modules 2015-12-25 13:05:23 -08:00
url.js url: group slashed protocols by protocol name 2016-02-29 20:26:59 -06:00
util.js util: improve format() performance further 2016-03-04 17:27:21 -06:00
v8.js v8,src: expose statistics about heap spaces 2016-01-18 11:44:00 -05:00
vm.js
zlib.js zlib: only apply drain listener if given callback 2015-11-14 08:11:28 -08:00