0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-29 23:16:30 +01:00
nodejs/test
João Reis 2b4b600660 test: fix test-debug-port-from-cmdline
This test was failing because the spawned process was terminated before
anything could be done, by calling child.stdin.end. With this change,
the child's stdin is no longer closed. When the stdin is not a tty,
io.js waits for the whole input before starting, so the child must be
run with --interactive to process the command sent by the parent. The
child is killed explicitly by the parent before it exits.

This test was failing silently because the asserts were not called if
nothing was received from the child. This fix moves assertOutputLines to
always run on exit.

Fixes: https://github.com/nodejs/io.js/issues/2177
Refs: https://github.com/nodejs/io.js/issues/2094
PR-URL: https://github.com/nodejs/io.js/pull/2186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
2015-07-15 21:52:16 -04:00
..
addons test: remove smalloc add-on test 2015-06-01 23:17:52 +02:00
cctest deps: check in gtest, add util unit test 2015-04-01 22:35:56 +02:00
debugger debugger: improve ESRCH error message 2015-06-05 05:54:19 +02:00
disabled test: purge stale disabled tests 2015-06-25 11:21:41 -07:00
fixtures util: prepend '(node) ' to deprecation messages 2015-07-03 16:32:29 +02:00
gc test: enable linting for tests 2015-05-19 21:21:27 +02:00
internet test: add missing crypto checks 2015-07-08 10:48:47 +10:00
message test: remove stray copyright notices 2015-05-26 17:17:40 +02:00
parallel test: fix test-debug-port-from-cmdline 2015-07-15 21:52:16 -04:00
pummel lib,test: fix whitespace issues 2015-06-15 16:37:37 +02:00
sequential test: properly clean up temp directory 2015-07-12 01:09:25 +02:00
testpy test: create temp dir in common.js 2015-06-12 10:27:29 +10:00
timers test: enable linting for tests 2015-05-19 21:21:27 +02:00
.eslintrc tools: enable/add additional eslint rules 2015-06-11 20:27:35 +02:00
common.js test: tmpdir creation failures should fail tests 2015-06-16 17:19:19 -07:00