mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

test: fix test-debug-port-from-cmdline

Browse Source 
This test was failing because the spawned process was terminated before
anything could be done, by calling child.stdin.end. With this change,
the child's stdin is no longer closed. When the stdin is not a tty,
io.js waits for the whole input before starting, so the child must be
run with --interactive to process the command sent by the parent. The
child is killed explicitly by the parent before it exits.

This test was failing silently because the asserts were not called if
nothing was received from the child. This fix moves assertOutputLines to
always run on exit.

Fixes: https://github.com/nodejs/io.js/issues/2177
Refs: https://github.com/nodejs/io.js/issues/2094
PR-URL: https://github.com/nodejs/io.js/pull/2186
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
This commit is contained in:
João Reis 2015-07-15 13:19:56 +01:00 committed by cjihrig
parent f95f9ef6ea
commit 2b4b600660
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-debug-port-from-cmdline.js
View File

@ -4,11 +4,11 @@ var assert = require('assert');
var spawn = require('child_process').spawn;
var debugPort = common.PORT;
var args = ['--debug-port=' + debugPort];
var args = ['--interactive', '--debug-port=' + debugPort];
var childOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] };
var child = spawn(process.execPath, args, childOptions);
child.stdin.end("process.send({ msg: 'childready' });");
child.stdin.write("process.send({ msg: 'childready' });\n");
child.stderr.on('data', function(data) {
var lines = data.toString().replace(/\r/g, '').trim().split('\n');
@ -23,6 +23,7 @@ child.on('message', function onChildMsg(message) {
process.on('exit', function() {
child.kill();
assertOutputLines();
});
var outputLines = [];
@ -31,7 +32,6 @@ function processStderrLine(line) {
outputLines.push(line);
if (/Debugger listening/.test(line)) {
assertOutputLines();
process.exit();
}
}