mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity
1a2cf6696f
nodejs/doc/api
History
Andreas Madsen 1a2cf6696f
async_hooks: remove promise object from resource 
While it doesn't make any difference now. In the future PromiseHooks
could be refactored to provide an asyncId instead of the promise object.
That would make escape analysis on promises possible.

Escape analysis on promises could lead to a more efficient destroy hook,
if provide by PromiseHooks as well. But at the very least would allow
the destroy hook to be emitted earlier. The destroy hook not being
emitted on promises frequent enough is a known and reported issue.
See https://github.com/nodejs/node/issues/14446 and
https://github.com/Jeff-Lewis/cls-hooked/issues/11.

While all this is speculation for now, it all depends on the promise
object not being a part of the PromiseWrap resource object.

Ref: https://github.com/nodejs/node/issues/14446
Ref: https://github.com/nodejs/diagnostics/issues/188

PR-URL: https://github.com/nodejs/node/pull/23443
Refs: https://github.com/nodejs/node/issues/14446
Refs: https://github.com/nodejs/diagnostics/issues/188
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
2018-10-15 19:40:51 +01:00
..
addons.md test: fix compiler warning in doc/api/addons.md 2018-10-11 05:18:11 +02:00
assert.md doc: improve assert documentation 2018-09-07 22:42:08 +01:00
async_hooks.md async_hooks: remove promise object from resource 2018-10-15 19:40:51 +01:00
buffer.md errors: use ERR_OUT_OF_RANGE for index errors 2018-09-26 19:36:50 -07:00
child_process.md 2018-09-06, Version 10.10.0 (Current) 2018-09-06 23:57:43 +02:00
cli.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
cluster.md doc: specify cluster worker.kill() caveat 2018-10-04 09:02:47 -04:00
console.md 2018-07-18, Version 10.7.0 (Current) 2018-07-18 20:17:23 +02:00
crypto.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
debugger.md inspector: use js_app.html as the landing page for chrome devtools 2018-06-28 09:24:02 -03:00
deprecations.md doc: wrap links in <> 2018-10-15 05:51:18 +02:00
dgram.md doc: remove redundant 'Example:' and similar notes 2018-08-29 16:53:03 +03:00
dns.md doc: add missing metadata for dns.lookup 2018-09-19 21:11:51 +02:00
documentation.md doc: make Stability Index more concise 2018-08-30 20:15:40 +01:00
domain.md doc: remove personal pronoun from domain.md 2018-10-10 20:11:24 -07:00
errors.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
esm.md esm: provide named exports for builtin libs 2018-05-11 12:06:18 -05:00
events.md doc: declare all parameter types 2018-07-15 23:57:35 +03:00
fs.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
globals.md doc: add WebAssembly to globals 2018-10-10 14:02:35 -07:00
http2.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
http.md doc: improve metadata for http.request 2018-09-19 21:12:45 +02:00
https.md doc: improve metadata for http.request 2018-09-19 21:12:45 +02:00
index.md doc: prevent some redirections 2018-07-14 22:57:03 +03:00
inspector.md doc: fix structure and formatting in inspector.md 2018-07-08 21:56:10 +03:00
intl.md doc: bump ICU version to avoid confusion 2018-08-14 22:44:58 +03:00
modules.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
n-api.md benchmark,doc,lib,src,test,tools: fix typos 2018-10-09 16:53:12 +03:00
net.md doc: remove redundant 'Example:' and similar notes 2018-08-29 16:53:03 +03:00
os.md doc, win: improve os.setPriority documentation 2018-09-19 08:02:18 +02:00
path.md doc: remove redundant 'Example:' and similar notes 2018-08-29 16:53:03 +03:00
perf_hooks.md perf_hooks: remove less useful bootstrap marks 2018-06-15 09:05:19 -07:00
process.md doc: edit for minor fixes to prcoess.md 2018-10-10 20:11:27 -07:00
punycode.md doc: prevent some redirections 2018-07-14 22:57:03 +03:00
querystring.md doc: remove redundant 'Example:' and similar notes 2018-08-29 16:53:03 +03:00
readline.md doc: add warning to readline's close() method 2018-09-06 20:11:31 -04:00
repl.md doc: fix pr-url in repl.md 2018-10-15 05:51:28 +02:00
stream.md doc: fix minor typo in streams.md 2018-10-08 20:25:32 -07:00
string_decoder.md string_decoder: support typed array or data view 2018-09-17 17:48:44 +02:00
synopsis.md doc: match program and console output in synopsis.md 2018-09-22 00:49:25 +03:00
timers.md doc: prevent some redirections 2018-07-14 22:57:03 +03:00
tls.md doc: wrap links in <> 2018-10-15 05:51:18 +02:00
tracing.md doc: remove redundant 'Example:' and similar notes 2018-08-29 16:53:03 +03:00
tty.md tty: document WriteStream.cursorTo() and others 2018-10-06 01:36:03 +03:00
url.md doc: fix url example to match behavior 2018-10-15 05:51:41 +02:00
util.md 2018-10-10, Version 10.12.0 (Current) 2018-10-10 23:18:55 +02:00
v8.md doc: update a link in v8.md 2018-09-03 17:47:28 +03:00
vm.md vm: pass parsing_context to ScriptCompiler::CompileFunctionInContext 2018-10-11 08:42:49 +02:00
worker_threads.md doc: remove personal pronoun from worker_threads 2018-10-10 20:11:25 -07:00
zlib.md doc: unify optional arguments format in headings 2018-08-19 21:45:39 +03:00