mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
1a2cf6696f
While it doesn't make any difference now. In the future PromiseHooks could be refactored to provide an asyncId instead of the promise object. That would make escape analysis on promises possible. Escape analysis on promises could lead to a more efficient destroy hook, if provide by PromiseHooks as well. But at the very least would allow the destroy hook to be emitted earlier. The destroy hook not being emitted on promises frequent enough is a known and reported issue. See https://github.com/nodejs/node/issues/14446 and https://github.com/Jeff-Lewis/cls-hooked/issues/11. While all this is speculation for now, it all depends on the promise object not being a part of the PromiseWrap resource object. Ref: https://github.com/nodejs/node/issues/14446 Ref: https://github.com/nodejs/diagnostics/issues/188 PR-URL: https://github.com/nodejs/node/pull/23443 Refs: https://github.com/nodejs/node/issues/14446 Refs: https://github.com/nodejs/diagnostics/issues/188 Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> |
||
|---|---|---|
| .. | ||
| api | ||
| api_assets | ||
| changelogs | ||
| guides | ||
| .eslintrc.yaml | ||
| first_timer_badge.png | ||
| full-white-stripe.jpg | ||
| node.1 | ||
| offboarding.md | ||
| onboarding-extras.md | ||
| onboarding.md | ||
| osx_installer_logo.png | ||
| releases.md | ||
| STYLE_GUIDE.md | ||
| template.html | ||
| thin-white-stripe.jpg | ||
