0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
nodejs/src
Ben Noordhuis 6bdc18c592 src: don't touch js object in Http2Session dtor
Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage collector invokes the destructor when the object is
collected and is not necessarily in a valid state anymore.

PR-URL: https://github.com/nodejs/node/pull/18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2018-02-21 15:24:18 +01:00
..
res
tracing src: update trace event macros to v8 6.4 version 2018-02-14 10:59:49 -08:00
aliased_buffer.h async_hooks: use typed array stack as fast path 2017-12-27 19:48:07 +01:00
async_wrap-inl.h src: rename base-object -> base_object 2017-11-17 12:49:10 +01:00
async_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
async_wrap.h async_hooks: clean up usage in internal code 2018-02-16 14:23:14 -05:00
backtrace_posix.cc src: remove superfluous check in backtrace_posix.cc 2017-11-18 20:58:12 +01:00
backtrace_win32.cc src: implement backtrace-on-abort for windows 2017-11-15 19:28:13 +01:00
base64.h src: make base64.h self-contained 2017-11-27 07:21:08 +01:00
base_object-inl.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
base_object.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
cares_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
CNNICHashWhitelist.inc
connect_wrap.cc src: rename req-wrap -> req_wrap 2017-11-17 12:49:20 +01:00
connect_wrap.h src: rename req-wrap -> req_wrap 2017-11-17 12:49:20 +01:00
connection_wrap.cc src: refactor stream callbacks and ownership 2018-02-01 10:53:26 +01:00
connection_wrap.h src: rename StreamWrap to LibuvStreamWrap 2017-10-13 13:05:49 -07:00
env-inl.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
env.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
env.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
freelist.h http2: introducing HTTP/2 2017-08-04 12:55:44 -07:00
fs_event_wrap.cc src: make FSEventWrap/StatWatcher::Start more robust 2017-12-13 06:32:55 +01:00
handle_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
handle_wrap.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
inspector_agent.cc src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
inspector_agent.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
inspector_io.cc src: add "icu::" prefix before ICU symbols 2018-02-09 18:09:08 -08:00
inspector_io.h inspector: Fix crash for WS connection 2017-12-11 15:53:21 -08:00
inspector_js_api.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
inspector_socket_server.cc src: fix compile warnings introduced in 73ad3f9bea 2017-12-15 07:47:11 +01:00
inspector_socket_server.h inspector: Fix crash for WS connection 2017-12-11 15:53:21 -08:00
inspector_socket.cc inspector: make Coverity happy 2017-12-27 19:41:08 +01:00
inspector_socket.h inspector: Fix crash for WS connection 2017-12-11 15:53:21 -08:00
js_stream.cc src: refactor WriteWrap and ShutdownWraps 2018-02-14 10:00:29 +01:00
js_stream.h src: remove redundant JSStream::DoAfterWrite 2017-12-21 20:56:13 +01:00
module_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
module_wrap.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
node_api_types.h n-api: add methods to open/close callback scope 2018-02-05 17:10:19 -05:00
node_api.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_api.h n-api: add methods to open/close callback scope 2018-02-05 17:10:19 -05:00
node_buffer.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_buffer.h src: do not include internals from node_buffer.h 2017-09-22 16:28:52 +02:00
node_config.cc vm: add modules 2018-01-30 17:00:57 -08:00
node_constants.cc fs: move type checking to js 2017-12-22 12:49:10 -08:00
node_constants.h
node_contextify.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_contextify.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_counters.cc src: do not include x.h if x-inl.h is included 2017-10-30 18:56:38 +08:00
node_counters.h src: refactor #include handling 2017-09-14 17:38:38 +02:00
node_crypto_bio.cc crypto: remove BIO_set_shutdown 2017-12-11 07:19:55 +01:00
node_crypto_bio.h crypto: make node_crypto_bio compat w/ OpenSSL 1.1 2017-11-11 20:42:49 +11:00
node_crypto_clienthello-inl.h crypto: add ocsp_request ClientHelloParser::Reset 2017-12-27 19:46:48 +01:00
node_crypto_clienthello.cc src: do not include x.h if x-inl.h is included 2017-10-30 18:56:38 +08:00
node_crypto_clienthello.h crypto: remove unused header in clienthello.h 2017-12-19 14:36:55 +01:00
node_crypto_groups.h
node_crypto.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_crypto.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_debug_options.cc src,lib,test,doc: correct misspellings 2017-06-17 19:17:46 +02:00
node_debug_options.h inspector: allow --inspect=host:port from js 2017-06-06 14:41:17 -07:00
node_domain.cc domain: further abstract usage in C++ 2018-01-29 11:37:29 -05:00
node_dtrace.cc src: do not include x.h if x-inl.h is included 2017-10-30 18:56:38 +08:00
node_dtrace.h src: refactor #include handling 2017-09-14 17:38:38 +02:00
node_file.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_file.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
node_http2_state.h http2: use aliased buffer for perf stats, add stats 2018-01-09 12:33:13 -08:00
node_http2.cc src: don't touch js object in Http2Session dtor 2018-02-21 15:24:18 +01:00
node_http2.h src: add nullptr check for session in DEBUG macro 2018-02-19 08:17:41 +01:00
node_http_parser.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
node_i18n.cc src: add "icu::" prefix before ICU symbols 2018-02-09 18:09:08 -08:00
node_i18n.h src: refactor #include handling 2017-09-14 17:38:38 +02:00
node_internals.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
node_javascript.h src: refactor #include handling 2017-09-14 17:38:38 +02:00
node_lttng_provider.h
node_lttng_tp.h
node_lttng.cc src: do not include x.h if x-inl.h is included 2017-10-30 18:56:38 +08:00
node_lttng.h
node_main.cc src: remove duplicate words in comments 2018-01-02 00:31:03 +01:00
node_mutex.h
node_object_wrap.h
node_os.cc src: use nullptr instead of NULL 2017-12-01 07:45:00 +01:00
node_perf_common.h http2,perf_hooks: perf state using AliasedBuffer 2018-01-24 17:29:45 -08:00
node_perf.cc src: remove unused variable 2018-01-27 19:17:16 -05:00
node_perf.h http2: perf_hooks integration 2018-01-02 08:56:30 -08:00
node_persistent.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
node_platform.cc src: implement getting current time in NodePlatform 2017-12-06 12:52:07 +01:00
node_platform.h src: implement getting current time in NodePlatform 2017-12-06 12:52:07 +01:00
node_postmortem_metadata.cc src: do not redefine private for GenDebugSymbols 2018-02-14 03:55:15 -05:00
node_provider.d
node_revert.h meta: merge TSC and CTC back into a single body 2017-08-29 08:39:25 -07:00
node_root_certs.h crypto: update root certificates 2017-05-29 08:45:07 -07:00
node_serdes.cc src: rename base-object -> base_object 2017-11-17 12:49:10 +01:00
node_stat_watcher.cc fs: use AliasedBuffer for fs_stats_field_array 2018-01-24 03:54:37 +08:00
node_stat_watcher.h src: rename async-wrap -> async_wrap 2017-11-17 12:49:00 +01:00
node_trace_events.cc trace_events: add executionAsyncId to init events 2017-11-24 21:52:11 +01:00
node_url.cc src: free memory before re-setting URLHost value 2018-02-01 11:05:45 +01:00
node_url.h src: improve module loader readability 2017-11-03 01:10:31 +01:00
node_util.cc lib,src: audit process.env in lib/ for setuid binary 2018-02-16 17:42:21 +01:00
node_v8.cc src: explicitly register built-in modules 2017-11-13 23:17:34 +00:00
node_version.h src: update NODE_MODULE_VERSION to 61 2018-01-24 15:02:33 -08:00
node_watchdog.cc src: refactor #include handling 2017-09-14 17:38:38 +02:00
node_watchdog.h vm: fix race condition with timeout param 2017-05-23 21:00:40 +02:00
node_win32_etw_provider-inl.h tools: add cpplint rule for NULL usage 2017-12-01 07:45:05 +01:00
node_win32_etw_provider.cc src: fix etw provider include on Windows 2017-10-31 07:53:49 -07:00
node_win32_etw_provider.h
node_win32_perfctr_provider.cc src: fix size of CounterSet 2017-11-18 20:53:38 +01:00
node_win32_perfctr_provider.h
node_wrap.h src: remove unused includes from node_wrap.h 2017-10-15 15:18:08 -07:00
node_zlib.cc src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
node.cc src: set thread local env in CreateEnvironment 2018-02-16 07:27:08 +01:00
node.d
node.h src: deprecate legacy node::MakeCallback 2018-02-15 17:44:48 -08:00
node.stp
nolttng_macros.py
noperfctr_macros.py src: rename perfctr_macros.py->noperfctr_macros.py 2017-10-11 07:42:02 +02:00
notrace_macros.py
pipe_wrap.cc src: refactor stream callbacks and ownership 2018-02-01 10:53:26 +01:00
pipe_wrap.h async_wrap: add provider types for net server 2017-11-28 02:50:54 +01:00
process_wrap.cc src: refactor stream callbacks and ownership 2018-02-01 10:53:26 +01:00
req_wrap-inl.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
req_wrap.h src: refactor WriteWrap and ShutdownWraps 2018-02-14 10:00:29 +01:00
signal_wrap.cc src: rename async-wrap -> async_wrap 2017-11-17 12:49:00 +01:00
spawn_sync.cc src: make ownership of stdio_pipes explicit 2017-11-16 16:54:00 +01:00
spawn_sync.h src: make ownership of stdio_pipes explicit 2017-11-16 16:54:00 +01:00
StartComAndWoSignData.inc
stream_base-inl.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
stream_base.cc src: refactor WriteWrap and ShutdownWraps 2018-02-14 10:00:29 +01:00
stream_base.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
stream_wrap.cc src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
stream_wrap.h src: refactor WriteWrap and ShutdownWraps 2018-02-14 10:00:29 +01:00
string_bytes.cc src: fix fs.write() externalized string handling 2018-01-23 19:17:39 +01:00
string_bytes.h src: fix fs.write() externalized string handling 2018-01-23 19:17:39 +01:00
string_decoder-inl.h string_decoder: reimplement in C++ 2018-02-10 14:38:56 +01:00
string_decoder.cc string_decoder: reimplement in C++ 2018-02-10 14:38:56 +01:00
string_decoder.h string_decoder: reimplement in C++ 2018-02-10 14:38:56 +01:00
string_search.cc
string_search.h module: speed up package.json parsing more 2017-11-15 12:01:20 +01:00
tcp_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
tcp_wrap.h src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
timer_wrap.cc timers: refactor timer list processing 2018-02-09 14:59:07 -05:00
tls_wrap.cc src: remove unnecessary Reset() calls 2018-02-21 15:24:18 +01:00
tls_wrap.h src: refactor WriteWrap and ShutdownWraps 2018-02-14 10:00:29 +01:00
tty_wrap.cc src: refactor stream callbacks and ownership 2018-02-01 10:53:26 +01:00
tty_wrap.h src: remove unused include in tty_wrap.h 2017-10-25 07:43:41 +02:00
udp_wrap.cc async_hooks: use scope for defaultTriggerAsyncId 2017-12-19 18:04:52 +01:00
udp_wrap.h src: replace SetAccessor w/ SetAccessorProperty 2017-12-17 12:45:39 -05:00
util-inl.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
util.cc src: use uv_os_getpid() to get process id 2017-12-04 10:34:28 -05:00
util.h src: prevent persistent handle resource leaks 2018-02-21 15:24:18 +01:00
uv.cc util: implement util.getSystemErrorName() 2018-01-20 08:51:47 +08:00
v8abbr.h src: update postmortem constant name 2018-01-24 15:02:43 -08:00
v8ustack.d src: update ustack offset identifiers 2017-10-18 17:03:11 -07:00