mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 21:19:50 +01:00
Code Issues Releases Activity

tools: don't print gold linker warning w/o flag

Browse Source 
Currently warning is printed called even if the selection ordering flag
has not been passed.

Only print warning if `--limit-configure-section-file`
has been passed to configure.

Fixes: https://github.com/nodejs/node/issues/35872

PR-URL: https://github.com/nodejs/node/pull/35955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Myles Borins 2020-11-03 22:07:34 -05:00 committed by Node.js GitHub Bot
parent cef144421c
commit 115722b553
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure.py
View File

@ -1761,7 +1761,8 @@ def configure_section_file(o):
proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE,
stdout = subprocess.PIPE, stderr = subprocess.PIPE)
except OSError:
warn('''No acceptable ld.gold linker found!''')
if options.node_section_ordering_info != "":
warn('''No acceptable ld.gold linker found!''')
return 0
match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$",