From 115722b553a6d547815d8df30d819326db6a7eb7 Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Tue, 3 Nov 2020 22:07:34 -0500 Subject: [PATCH] tools: don't print gold linker warning w/o flag Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: https://github.com/nodejs/node/issues/35872 PR-URL: https://github.com/nodejs/node/pull/35955 Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Rich Trott --- configure.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.py b/configure.py index d68d8fc96ab..eb78598d9d3 100755 --- a/configure.py +++ b/configure.py @@ -1761,7 +1761,8 @@ def configure_section_file(o): proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE, stdout = subprocess.PIPE, stderr = subprocess.PIPE) except OSError: - warn('''No acceptable ld.gold linker found!''') + if options.node_section_ordering_info != "": + warn('''No acceptable ld.gold linker found!''') return 0 match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$",