Updated lint rules

package.json

@@ -80,7 +80,7 @@
     "rimraf": "^2.5.2",
     "shelljs": "^0.7.7",
     "sinon": "^5.0.7",
-    "tslint": "^5.1.0",
+    "tslint": "^5.11.0",
     "typedoc": "^0.11.1",
     "typescript": "2.9.2",
     "webpack": "^3.10.0"

src/export/packer/buffer-stream.ts

@@ -1,7 +1,7 @@
 import { Writable } from "stream";
 
 export class BufferStream extends Writable {
-    private data: Buffer[];
+    private readonly data: Buffer[];
 
     constructor() {
         super();
@@ -10,7 +10,7 @@ export class BufferStream extends Writable {
     }
 
     // tslint:disable-next-line:no-any
-    public _write(chunk: any, encoding: string, next: (err?: Error) => void): void {
+    public _write(chunk: any, _: string, next: (err?: Error) => void): void {
         this.data.push(Buffer.from(chunk));
         next();
     }

src/export/packer/compiler.ts

@@ -8,9 +8,9 @@ import { Formatter } from "../formatter";
 
 export class Compiler {
     protected archive: archiver.Archiver;
-    private formatter: Formatter;
+    private readonly formatter: Formatter;
 
-    constructor(private file: File) {
+    constructor(private readonly file: File) {
         this.formatter = new Formatter();
         this.archive = archiver.create("zip", {});
 

src/file/document/body/body.ts

@@ -3,9 +3,9 @@ import { Paragraph, ParagraphProperties } from "../..";
 import { SectionProperties, SectionPropertiesOptions } from "./section-properties";
 
 export class Body extends XmlComponent {
-    private defaultSection: SectionProperties;
+    private readonly defaultSection: SectionProperties;
 
-    private sections: SectionProperties[] = [];
+    private readonly sections: SectionProperties[] = [];
 
     constructor(sectionPropertiesOptions?: SectionPropertiesOptions) {
         super("w:body");

src/file/document/body/section-properties/section-properties.ts

@@ -23,7 +23,8 @@ export type SectionPropertiesOptions = IPageSizeAttributes &
     IPageNumberTypeAttributes;
 
 export class SectionProperties extends XmlComponent {
-    private options: SectionPropertiesOptions;
+    private readonly options: SectionPropertiesOptions;
+
     constructor(options?: SectionPropertiesOptions) {
         super("w:sectPr");
 

src/file/drawing/drawing.ts

@@ -28,7 +28,7 @@ const defaultDrawingOptions: IDrawingOptions = {
 };
 
 export class Drawing extends XmlComponent {
-    private inline: Inline;
+    private readonly inline: Inline;
 
     constructor(imageData: IMediaData, drawingOptions?: IDrawingOptions) {
         super("w:drawing");

src/file/drawing/extent/extent.ts

@@ -2,7 +2,7 @@ import { XmlComponent } from "file/xml-components";
 import { ExtentAttributes } from "./extent-attributes";
 
 export class Extent extends XmlComponent {
-    private attributes: ExtentAttributes;
+    private readonly attributes: ExtentAttributes;
 
     constructor(x: number, y: number) {
         super("wp:extent");

src/file/drawing/inline/graphic/graphic-data/graphic-data.ts

@@ -3,7 +3,7 @@ import { GraphicDataAttributes } from "./graphic-data-attribute";
 import { Pic } from "./pic";
 
 export class GraphicData extends XmlComponent {
-    private pic: Pic;
+    private readonly pic: Pic;
 
     constructor(referenceId: number, x: number, y: number) {
         super("a:graphicData");

src/file/drawing/inline/graphic/graphic-data/pic/pic.ts

@@ -6,7 +6,7 @@ import { PicAttributes } from "./pic-attributes";
 import { ShapeProperties } from "./shape-properties/shape-properties";
 
 export class Pic extends XmlComponent {
-    private shapeProperties: ShapeProperties;
+    private readonly shapeProperties: ShapeProperties;
 
     constructor(referenceId: number, x: number, y: number) {
         super("pic:pic");

src/file/drawing/inline/graphic/graphic-data/pic/shape-properties/form/extents/extents.ts

@@ -3,7 +3,7 @@ import { XmlComponent } from "file/xml-components";
 import { ExtentsAttributes } from "./extents-attributes";
 
 export class Extents extends XmlComponent {
-    private attributes: ExtentsAttributes;
+    private readonly attributes: ExtentsAttributes;
 
     constructor(x: number, y: number) {
         super("a:ext");

src/file/drawing/inline/graphic/graphic-data/pic/shape-properties/form/form.ts

@@ -4,7 +4,7 @@ import { Extents } from "./extents/extents";
 import { Offset } from "./offset/off";
 
 export class Form extends XmlComponent {
-    private extents: Extents;
+    private readonly extents: Extents;
 
     constructor(x: number, y: number) {
         super("a:xfrm");

src/file/drawing/inline/graphic/graphic-data/pic/shape-properties/shape-properties.ts

@@ -7,7 +7,7 @@ import { PresetGeometry } from "./preset-geometry/preset-geometry";
 import { ShapePropertiesAttributes } from "./shape-properties-attributes";
 
 export class ShapeProperties extends XmlComponent {
-    private form: Form;
+    private readonly form: Form;
 
     constructor(x: number, y: number) {
         super("pic:spPr");

src/file/drawing/inline/graphic/graphic.ts

@@ -12,7 +12,7 @@ class GraphicAttributes extends XmlAttributeComponent<IGraphicProperties> {
 }
 
 export class Graphic extends XmlComponent {
-    private data: GraphicData;
+    private readonly data: GraphicData;
 
     constructor(referenceId: number, x: number, y: number) {
         super("a:graphic");

src/file/drawing/inline/inline.ts

@@ -9,10 +9,10 @@ import { Graphic } from "./../inline/graphic";
 import { InlineAttributes } from "./inline-attributes";
 
 export class Inline extends XmlComponent {
-    private extent: Extent;
-    private graphic: Graphic;
+    private readonly extent: Extent;
+    private readonly graphic: Graphic;
 
-    constructor(referenceId: number, private dimensions: IMediaDataDimensions) {
+    constructor(referenceId: number, private readonly dimensions: IMediaDataDimensions) {
         super("wp:inline");
 
         this.root.push(

src/file/footer/footer.ts

@@ -5,7 +5,8 @@ import { Table } from "../table";
 import { FooterAttributes } from "./footer-attributes";
 
 export class Footer extends XmlComponent {
-    private refId: number;
+    private readonly refId: number;
+
     constructor(referenceNumber: number) {
         super("w:ftr");
         this.refId = referenceNumber;

src/file/header/header.ts

@@ -5,9 +5,11 @@ import { Table } from "../table";
 import { HeaderAttributes } from "./header-attributes";
 
 export class Header extends XmlComponent {
-    private refId: number;
+    private readonly refId: number;
+
     constructor(referenceNumber: number) {
         super("w:hdr");
+
         this.refId = referenceNumber;
         this.root.push(
             new HeaderAttributes({

src/file/numbering/numbering.ts

@@ -7,8 +7,8 @@ import { Num } from "./num";
 export class Numbering extends XmlComponent {
     private nextId: number;
 
-    private abstractNumbering: XmlComponent[] = [];
-    private concreteNumbering: XmlComponent[] = [];
+    private readonly abstractNumbering: XmlComponent[] = [];
+    private readonly concreteNumbering: XmlComponent[] = [];
 
     constructor() {
         super("w:numbering");

src/file/paragraph/paragraph.ts

@@ -19,7 +19,7 @@ import { ParagraphProperties } from "./properties";
 import { PictureRun, Run, TextRun } from "./run";
 
 export class Paragraph extends XmlComponent {
-    private properties: ParagraphProperties;
+    private readonly properties: ParagraphProperties;
 
     constructor(text?: string) {
         super("w:p");

src/file/paragraph/run/picture-run.ts

@@ -4,7 +4,7 @@ import { IMediaData } from "../../media/data";
 import { Run } from "../run";
 
 export class PictureRun extends Run {
-    private drawing: Drawing;
+    private readonly drawing: Drawing;
 
     constructor(imageData: IMediaData, drawingOptions?: IDrawingOptions) {
         super();

src/file/table/table.ts

@@ -144,7 +144,8 @@ export class TableCell extends XmlComponent {
 }
 
 export class TableCellProperties extends XmlComponent {
-    private cellBorder: TableCellBorders;
+    private readonly cellBorder: TableCellBorders;
+
     constructor() {
         super("w:tcPr");
         this.cellBorder = new TableCellBorders();

tsconfig.json

@@ -10,6 +10,7 @@
         "module": "commonjs",
         "declaration": true,
         "noUnusedLocals": true,
+        "noUnusedParameters": true,
         "baseUrl": "./src",
         "paths" : {
           "/*": [

tslint.json

@@ -32,12 +32,10 @@
         "max-classes-per-file": [
             false
         ],
-        "no-unused-variable": [
-            true
-        ],
         "no-implicit-dependencies": false,
         "no-submodule-imports": false,
         "no-null-keyword": true,
-        "return-undefined": true
+        "return-undefined": true,
+        "prefer-readonly": true
     }
 }