0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
wagtail/docs/contributing/ui_guidelines.md
2023-06-01 16:50:03 +01:00

7.9 KiB
Raw Blame History

UI Guidelines

Wagtails user interface is built with:

Linting and formatting

Here are the available commands:

  • make lint will run all linting, make lint-server lints templates, and make lint-client lints JS/CSS.
  • make format will run all formatting and fixing of linting issues. There is also make format-server and make format-client.

Have a look at our Makefile tasks and package.json scripts if you prefer more granular options.

HTML guidelines

We use djhtml for formatting and Curlylint for linting.

CSS guidelines

We use Prettier for formatting and Stylelint for linting.

  • We follow BEM and ITCSS, with a large amount of utilities created with Tailwind.
  • Familiarise yourself with our stylelint-config-wagtail configuration, which details our preferred code style.
  • Use rems for font-size, because they offer absolute control over text. Additionally, unit-less line-height is preferred because it does not inherit a percentage value of its parent element, but instead is based on a multiplier of the font-size.
  • Always use variables for design tokens such as colours or font sizes, rather than hard-coding specific values.
  • We use the w- prefix for all styles intended to be reusable by Wagtail site implementers.

JavaScript guidelines

We use Prettier for formatting and ESLint for linting.

(ui_guidelines_stimulus)=

Stimulus

Wagtail uses Stimulus as a lightweight framework to attach interactive behaviour to DOM elements via data- attributes.

Why Stimulus

Stimulus is a lightweight framework that allows developers to create interactive UI elements in a simple way. It makes it easy to do small-scale reactivity via changes to data attributes and does not require developers to 'init' things everywhere, unlike JQuery. It also provides an alternative to using inline script tag usage and window globals which reduces complexity in the codebase.

When to use Stimulus

Stimulus is our preferred library for simple client-side interactivity. Its a good fit when:

  • The interactivity requires JavaScript. Otherwise, consider using HTML and CSS only.
  • Some of the logic is defined via HTML templates, not just JavaScript.
  • The interactivity is simple, and doesnt require usage of more heavyweight libraries like React.

Wagtails admin interface also leverages jQuery for similar scenarios. This is considered legacy and will eventually be removed. For new features, carefully consider whether existing jQuery code should be reused, or whether a rebuild with Stimulus is more appropriate.

How to build a Stimulus controller

First think of how to name the controller. Keep it concise, one or two words ideally. Then,

  1. Start with the HTML templates, build as much of the UI as you can in HTML alone. Ensure it is accessible and follows the CSS guidelines.
  2. Create the controller file in our client/src/controllers folder, along with its tests (see ) and Storybook stories.
  3. For initialisation, consider which controller lifecycle methods to use, if any (connect, initialize).
  4. If relevant, also consider how to handle the controlled element being removed from the DOM disconnect lifecycle method.
  5. Document controller classes and methods with JSDoc annotations.
  6. Use values to provide options and also reactive state, avoiding instance properties if possible. Prefer falsey or empty defaults and avoid too much usage of the Object type when using values.
  7. Build the behaviour around small, discrete, methods and use Stimulus actions declared in HTML to drive when they are called.

Helpful tips

  • Prefer controllers that do a small amount of 'work' that is collected together, instead of lots of large or specific controllers.
  • Lean towards dispatching events for key behaviour in the UI interaction as this provides a great way for custom code to hook into this without an explicit API, but be sure to document these.
  • Multiple controllers can be attached to one DOM element for composing behaviour, where practical split out behaviour to separate controllers.
  • Consider when to document controller usage for non-contributors.
  • When writing unit tests, note that DOM updates triggered by data attribute changes are completed async (next microtick) so will require a await Promise or similar to check for the changes in JSDom.
  • Avoid hard-coding a controller's identifier, instead reference it with this.identifier if adjusting attributes. This way the controller can be used easily with a changed identifier or extended by other classes in the future.

Multilingual support

This is an area of active improvement for Wagtail, with ongoing discussions.

  • Always use the trimmed attribute on blocktranslate tags to prevent unnecessary whitespace from being added to the translation strings.

SVG icons

We use inline SVG elements for Wagtails icons, for performance and so icons can be styled with CSS. View for information on how icons are set up for Wagtail users.

Adding icons

Icons are SVG files in the Wagtail admin template folder.

When adding or updating an icon,

  1. Run it through SVGO with appropriate compression settings.
  2. Manually remove any unnecessary attributes.
  3. Manually add its id attribute with a prefix of icon- and the icon name matching the file name. Keep the icon as named from its source if possible.
  4. Add or preserve licensing information as a HTML comment starting with an exclamation mark: <!--! Icon license -->. For Font Awesome, we want: <!--! [icon name] ([icon style]): Font Awesome [version] -->. For example, <!--! triangle-exclamation (solid): Font Awesome Pro 6.4.0 -->.
  5. Add the icon to Wagtails own implementation of the register_icons hook, in alphabetical order.
  6. Go to the styleguide and copy the Wagtail icons table according to instructions in the template, pasting the result in wagtail_icons_table.txt.