0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-29 09:33:54 +01:00
wagtail/docs/contributing/javascript_guidelines.rst
Martey Dodoo 229103ff2e Update links in documentation. (#5689)
Use HTTPS links instead of non-secure HTTP links wherever possible in
documentation.
2019-11-08 09:15:01 +00:00

54 lines
1.7 KiB
ReStructuredText

JavaScript coding guidelines
============================
Write JavaScript according to the `Airbnb Styleguide <https://github.com/airbnb/javascript>`_, with some exceptions:
- Use soft-tabs with a four space indent. Spaces are the only way to
guarantee code renders the same in any person's environment.
- We accept ``snake_case`` in object properties, such as
``ajaxResponse.page_title``, however camelCase or UPPER_CASE should be used
everywhere else.
Linting and formatting code
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Wagtail uses the `ESLint <https://eslint.org/>`_ linter to help check your code meets the
styleguide. You'll need node.js and npm on your development machine.
Ensure project dependencies are installed by running ``npm install --no-save``
Linting code
------------
.. code-block:: console
$ npm run lint:js
This will lint all the JS in the wagtail project, excluding vendor
files and compiled libraries.
Some of the modals are generated via server-side scripts. These include
template tags that upset the linter, so modal workflow JavaScript is
excluded from the linter.
Formatting code
---------------
.. code-block:: console
$ npm run lint:js -- --fix
This will perform safe edits to conform your JS code to the styleguide.
It won't touch the line-length, or convert quotemarks from double to single.
Run the linter after you've formatted the code to see what manual fixes
you need to make to the codebase.
Changing the linter configuration
---------------------------------
The configuration for the linting rules is managed in an external
repository so that it can be easily shared across other Wagtail projects
or plugins. This configuration can be found at
`eslint-config-wagtail <https://github.com/wagtail/eslint-config-wagtail>`_.