- add documentation for WAGTAILADMIN_BASE_URL
- ensure that WAGTAILADMIN_BASE_URL is used via a util so that it can fallback from request
- resolves #3248
- remove settings URL from pagination template - not required for query string URLs
let's revisit this optimization in a different PR, since there is no
explicit requirements.txt in the project as such. We will need a slighly
different approach with this.
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Github actions have a new release and pip cache was not enabled.
Both of these will make the CI run faster.
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This improves the CI experience as it will run the github checks in a
group and at the same time cancel in progress jobs if a new commit is
pushed for the pull request.
No only does it makes the contributing experience nice, but it also
saves tonnes of energy.
- Github Issue: #8276
Authored-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
Signed-off-by: Vinit Kumar <vinit.kumar@kidskonnect.nl>
This creates an explicit demarcation between methods/properties that are only valid on fully bound panels (such as render_as_field) and those that should be called when only the model is bound (such as get_form_options). This surfaces two bugs where this was not enforced properly:
* in the create_log_entries_from_revisions scheduled task, we were calling get_comparison on an unbound EditHandler; we don't have a form or request to pass here, but we still need to call bind_to (with None for those values);
* BaseCompositeEditHandler overwrites its `children` attribute with the bound versions, so calling get_form_options is invalid after that point. Maintain distinct children and unbound_children attributes instead.
This version avoids writing to the child's `classes` attribute, which a parent panel shouldn't be doing (and may become invalid shortly as we start delegating methods / properties between BoundPanel and EditHandler instances)
All view code now passes all three parameters to bind_to, so we can make this a hard requirement and eliminate the distinct on_form_bound / on_request_bound / on_instance_bound handlers (because they're all triggered at the same time).
It's testing a workflow that's been superseded by #8060 and relies on binding the request before retrieving the form class, which won't be the case any more
- global font family on some elements set by normalize.css would override the desired font
- font stack was not correctly used across some elements
- fixes #8016
