0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Commit Graph

16724 Commits

Author SHA1 Message Date
Matt Westcott
7fd4e14f8e Set datetimepicker events to bubble so that they trigger a filter form refresh 2024-01-17 15:33:07 +00:00
Thibaud Colas
be14465c4e
Improve CSS authoring guidelines (#10049)
Co-authored-by: sag​e <laymonage@gmail.com>
2024-01-17 07:40:47 +00:00
Rohit Sharma
6f93b1a2c4 Fix long comment UI issues (scroll shaking & comment overflow)
- Includes PR #11322
- Fixes #10984 (scrolling issues with long initial comments)
- Fixes #11324 (overflow of comment reply with long words)
2024-01-17 17:34:48 +10:00
nandini584
a88a775aea Ensure the sidebar account toggle has no duplicate accessible labels
- Remove the integration test for this element as it was failing even though the element has valid content.
- Fixes #11372
2024-01-17 12:43:38 +10:00
nandini584
e91cdb47da Update Jest version (package.json) 2024-01-17 12:43:38 +10:00
Neeraj P Yetheendran
3faeabb4d7 Allow admin backend login URL to be customised (#11415)
Fixes #10882
2024-01-16 23:50:31 +00:00
nandini584
daf0c96841 Fix close button visibility in new dialog non-message variant
- Add w-dialog root classname to support overall styling of the dialog if a message is provided
- Fix up layout of dynamic classes to avoid additional spaces
- Fixes #11306
2024-01-17 09:27:50 +10:00
DevilsAutumn
fe1a306285 Move to a select field for determining the way TableBlock will use headers
- Make the new table_header_choice select backwards compatible with tables stored before Wagtail 6.0
- Built on previous PRs #9673 & #6763
- Fixes #5989
2024-01-17 08:37:40 +10:00
Tommaso Amici
a4c18b4957 Add optional caption field to TypedTableBlock
- Closes #8507
- Make caption default to "" for tables that predate adding the caption field
- Update the html generated in JS so the rendered form matches our new styles
- Use a consistent period (full stop) at the end of the help text sentence (including table fields)
2024-01-17 08:15:35 +10:00
LB Johnston
0ec50f0d82 Migrate Styleguide ad-hoc JS to use styles only 2024-01-16 19:03:45 +10:00
LB Johnston
fdad793a50 Fix up contributor name for #11294 2024-01-16 18:59:41 +10:00
Rohit Sharma
33fbbed19d Resolve error when specifying 'slug' as a read-only field (#11447) 2024-01-15 19:19:40 +00:00
Matt Westcott
67f495bb4c Rewrite recent edits panel to use audit log
As per https://github.com/wagtail/wagtail/issues/11323#issuecomment-1889520913

Fixes #11323. Thanks to @elhussienalmasri for the initial investigation and proposed fix.
2024-01-15 19:08:28 +00:00
LB Johnston
15f7486e67 Add changelog for #11294 2024-01-15 09:01:26 +10:00
Aman Pandey
3de0eca7e4 Remove inline script usage for enabling commenting
- Fixes #11287
- Add basic unit tests for form element data attributes showing/not showing based on commenting configs
2024-01-15 09:01:26 +10:00
LB Johnston
b93508f4ce Enhance Stimulus InitController to support additional custom event dispatching 2024-01-15 09:01:26 +10:00
LB Johnston
0ee97d45de Add upgrade considerations for data-tippy attribute deprecation 2024-01-11 16:23:09 +00:00
LB Johnston
edc5991f50 Remove initTooltips util & move plugins to controller files
- Fully remove initTooltips util and replace with Controller usage
- Move plugins to their used Controller files
- Export hideTooltipOnEsc as it's used by other code
- Add unit tests for plugin behaviour in the controller tests
- Fixes #10668
- Built on #10869
2024-01-11 16:23:09 +00:00
Neeraj P Yetheendran
f0a67975db Add ability to override a Page's copy form
- Documentation added for Customising Copy Form with an auto-incrementing slug example
- Add tests
- Resolves #10147
2024-01-11 08:35:53 +10:00
vaishnav dasari
3680e32ca8 Fix a few grammar issues in code inline docs/comments
Closes #11429
2024-01-11 07:47:29 +10:00
LB Johnston
235f217fee Add changelog for #11419 2024-01-11 07:43:16 +10:00
Thibaud Colas
445773a2a6 Reorder and rewrite CONTRIBUTING.md to be more actionable
Add link to issue tracking page
2024-01-11 07:43:16 +10:00
Thibaud Colas
2706a4c0ce Add a new "first-time contributor" section at the top of contribution guidelines 2024-01-11 07:43:16 +10:00
Thibaud Colas
75efe99ed2 Reword first contribution guide for readability 2024-01-11 07:43:16 +10:00
Thibaud Colas
1c063da0bc Update issue templates with a new "Who can work on this" section 2024-01-11 07:43:16 +10:00
Matt Westcott
a099cf7ac3 Release note for #11436 2024-01-10 16:18:14 +00:00
Matt Westcott
785f79a184 Remove redundant paginate_queryset method 2024-01-10 16:17:10 +00:00
Matt Westcott
0135b3c27f Replace calls to BaseListingView.get_ordering elsewhere with self.ordering 2024-01-10 16:16:05 +00:00
Matt Westcott
4d435c5ec9 Make self.ordering into a cached property so that we don't have to explicitly call get_ordering 2024-01-10 16:16:05 +00:00
Matt Westcott
1428307e3d Don't pass ordering as a parameter to order_queryset
We can now rely on self.ordering instead.
2024-01-10 16:16:05 +00:00
Matt Westcott
bc48d56ee0 Move remaining annotation/ordering logic from generic IndexView into order_queryset
This means we don't have to repeat the get_base_queryset / get_queryset split from BaseListingView.
2024-01-10 16:16:05 +00:00
Matt Westcott
5fa66980b3 Move get_base_queryset / order_queryset to generic BaseListingView.
Also handle the 'no ordering specified' case in the base order_queryset implementation, for consistency with filter_queryset and search_queryset.
2024-01-10 16:16:05 +00:00
Matt Westcott
6bf6e893fe Remove now fully generic get_queryset method from pages BaseIndexView 2024-01-10 16:16:05 +00:00
Matt Westcott
83b4de267b Ensure that BaseListingView and generic IndexView are consistently setting self.ordering from get_ordering() 2024-01-10 16:16:05 +00:00
Matt Westcott
1c8ec9a21f Move handling of construct_explorer_page_queryset hook into search_queryset
This makes get_queryset more-or-less generic. It's a bit of a hack to put it here, but it's reasonable to say that this should happen immediately before the search logic (so that the queryset passed to the hook is as close as possible to the final result, while still actually being a queryset and not a SearchResults object).
2024-01-10 16:16:05 +00:00
Matt Westcott
f270bba78c Move search logic into a search_queryset method 2024-01-10 16:16:05 +00:00
Matt Westcott
386be51f4e Refine logic for applying order to search results
Introduce an is_explicitly_ordered method to check whether an ordering URL parameter is present; if it is, search will use it, and if not, search will be ordered by relevance.
2024-01-10 16:16:05 +00:00
Matt Westcott
d31b7931f2 Move custom ordering logic into a dedicated order_queryset method 2024-01-10 16:16:05 +00:00
Matt Westcott
235de22424 Move various prefetches into get_base_queryset
These do not change based on parameters (filtering/search/ordering/pagination) so can logically go here.
2024-01-10 16:16:05 +00:00
Matt Westcott
92fdd5913d Simplify handling of search_queryset
Rather than making it the first step of get_context_data, make it the last step of get_queryset.
2024-01-10 16:16:05 +00:00
Matt Westcott
66731b14c2 Move initial page listing queryset construction into get_base_queryset 2024-01-10 16:16:05 +00:00
Sage Abdullah
29fd83493d
Release note for #11432 2024-01-10 09:30:11 +00:00
Sage Abdullah
fd6a415bc1
Check for WAGTAIL_I18N_ENABLED before adding locale filter
Change the override from get_filters to __init__. The get_filters method
is a classmethod and gets called at import time due to how django-filter
sets up its FilterSets. This prevents override_settings from taking
effect in tests. Moving the override to __init__ defers the locale
filter instantiation to runtime as part of the view's lifecycle.
2024-01-10 09:28:49 +00:00
Sage Abdullah
dc3d1baab3
Remove legacy locale selector fallback in generic IndexView
This means that for index views that don't use the breadcrumbs,
locale selection is now done using the filters on the right side.

Remove the locale filtering from get_queryset(), as it's been
handled by filter_queryset() using django-filter.

Also remove the get_translations() method as it was only used to
generate links for the legacy locale selector.
2024-01-10 09:28:49 +00:00
Sage Abdullah
5a79261b1c
Migrate forms index view to use slim header (breadcrumbs)
This is an example of how a view that uses the legacy header and locale
selector can be migrated to use the slim header (which means the locale
selector is now a filter).
2024-01-10 09:28:48 +00:00
Sage Abdullah
73e4c5e639
Do not show add button in generic IndexView if add url is undefined
Prevent the button from showing with href="None"
2024-01-10 09:28:48 +00:00
Sage Abdullah
3f60969b8e
Move locale selector in generic IndexView to a filter
Ensure the locale filter is always included by overriding
WagtailFilterSet.get_filters(), so if developers use a custom
filterset_class, the locale filter will automatically be added.

Adding an initial default value for a filter is not recommended as it
prevents users from skipping the filter:

https://django-filter.readthedocs.io/en/stable/guide/tips.html#using-initial-values-as-defaults

For this reason, add the option to filter by "All" locales instead,
which is applied when the locale filter is empty.

This means that the default state of the IndexView (before a locale is
specifically selected) is now to show objects from all locales instead
of only those of the default locale.

All this is only done if breadcrumbs are used, which means that the slim
header (along with its search+filter components) is used.

If breadcrumbs are not used i.e. the legacy header is still in use,
keep the old logic with the legacy locale selector for now.
2024-01-10 09:28:48 +00:00
dependabot[bot]
c0d958dc44 Bump follow-redirects from 1.14.9 to 1.15.4
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.9 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.9...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-10 17:10:43 +10:00
Thibaud Colas
633004e61b Release notes for #11365 / #8947 2024-01-09 15:42:08 +00:00
Thibaud Colas
bf9d062484 Prevent future issues with icon.html end-of-file newlines 2024-01-09 15:42:08 +00:00