0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-29 09:33:54 +01:00
Commit Graph

1660 Commits

Author SHA1 Message Date
sag​e
aef6de8a2f
Universal listings: Add LinkController to apply filter URL params to header buttons (#11522) 2024-01-24 12:43:54 +00:00
Sage Abdullah
e8b34ededd Implement active filter button to open drilldown for specific filter 2024-01-24 09:43:42 +00:00
Sage Abdullah
2adda186a0 Add cancelable w-dropdown:clickaway event for closing dropdown on click away 2024-01-24 09:43:42 +00:00
Sage Abdullah
3cedd02994 Render filter count by counting the active filters client-side 2024-01-24 09:32:28 +00:00
Sage Abdullah
a8bf1ab868 Run scripts inside teleported element in TeleportController 2024-01-24 09:32:28 +00:00
Sage Abdullah
981c1ac36a Fix drilldown component closing when interacting with datetime pickers 2024-01-24 09:32:28 +00:00
Sage Abdullah
0fb80e8aa0 Use get reference() instead of getReference() in DropdownController 2024-01-24 09:32:28 +00:00
Sage Abdullah
f1c4a495cc Do not reflect filter_fragment param in the browser
Also move the insertion of the param to get_url_without_foo methods to avoid the param getting applied multiple times and to avoid having to parse the URL again.

Rename the filter_fragment to _w_filter_fragment to avoid clashes
2024-01-24 09:32:28 +00:00
Sage Abdullah
bc381be264 Reset filters' w-drilldown state on close
This fixes the issue where the state is stuck at the last opened filter when the drilldown's contents are replaced
2024-01-24 09:32:28 +00:00
Sage Abdullah
238cbf3cd2 Dispatch w-dropdown:hidden event in DropdownController on tippy hide 2024-01-24 09:32:28 +00:00
Sage Abdullah
2b8d39ab0d Add 'reset' value to TeleportController to allow resetting the target element 2024-01-24 09:32:28 +00:00
Alex Morega
c4ef290859 Explicitly set triggerElement when invoking save (with publish) button on pages
Fixes #11420

Two issues existed;
1. Safari will not set `document.activeElement` as expected in all other browsers, instead, when a button is clicked it will keep the activeElement as `body`. This meant that the reset of the disabled button (before the confirm triggers a click) was not working.
2. Visually the button still had the loading spinner due to w-progress controller having triggered the loading visuals, this did not block the behaviour but looked broken.

See Safari behaviour docs:
- https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#clicking_and_focus
- https://bugs.webkit.org/show_bug.cgi?id=22261
2024-01-24 08:17:37 +10:00
elhussein almasri
d1b1fa638d Make TableBlock cells reachable using keyboard
Fixes #8893
2024-01-24 07:48:20 +10:00
Sage Abdullah
dbf3c7c586
Adjust margin-bottom of w-field__wrapper in drilldown component
Prevent the focus outline from being cut-off
2024-01-23 09:43:08 +00:00
Thibaud Colas
f1520bfcdd
Clean up unfinished aspects of DrilldownController 2024-01-23 09:22:30 +00:00
Sage Abdullah
7ba218a094
Use data-action to listen to w-swap:success in DrilldownController
and rename the method to updateParamsCount
2024-01-23 09:22:30 +00:00
Thibaud Colas
68df8a0ba3
Add drilldown filters interface for universal listings 2024-01-23 09:22:30 +00:00
Thibaud Colas
4790b44ba1
Move accessibility checker inside the editor (#11478). Fix #10136 2024-01-23 08:15:34 +00:00
Sage Abdullah
1ab78fc5c1 Fix first column padding in page listings when custom ordering is active 2024-01-23 06:50:07 +00:00
Sage Abdullah
bbd22d8c43 Use bulk actions header's checkbox to detect bulk actions in listing styles
bulk-action-checkbox is the checkbox in the <td> elements. On page
listings, if you're searching and there are no results, the table will
still be displayed (to give you the option to search the whole site).
The table has no data rows, which means there are no elements with
bulk-action-checkbox class.

Change the selector to target the bulk-actions-filter-checkbox class
instead, which is the bulk action's <th> checkbox. This element (in the
header cell) is always available even when there are no results.
2024-01-23 06:50:07 +00:00
Rohit Sharma
50bdb724b5 Fix chooser buttons focus color is too dark in dark mode
Fixes #10875
2024-01-23 12:30:41 +10:00
Thibaud Colas
76d91d55af
Update color variables documentation and tests 2024-01-22 16:04:06 +00:00
Thibaud Colas
90ca9b7001
Roll out new theme tokens where appropriate 2024-01-22 16:04:06 +00:00
Thibaud Colas
95e763ca2e
Introduce new border-button-outline-hover and text-button-outline-hover theming tokens 2024-01-22 16:04:05 +00:00
Thibaud Colas
c70a4da5cb
Add new color tokens for Wagtail and update existing tokens, dark theme 2024-01-22 16:04:05 +00:00
Thibaud Colas
e022625187
Set the color-scheme property based on Wagtail theming support. Fix #11309 2024-01-22 16:04:05 +00:00
Thibaud Colas
bd8c38ed49 Only apply set widths to actions styles within footer 2024-01-22 11:48:10 +00:00
Thibaud Colas
57d75e2870 Add text ellipsis styles and shorten wording in title header search results label 2024-01-22 11:48:10 +00:00
Thibaud Colas
90ecdb4928 Force title listing header cell to wrap 2024-01-22 11:48:10 +00:00
Thibaud Colas
ec65511eb0 Use tighter horizontal spacing for listing columns 2024-01-22 11:48:10 +00:00
Nandini Arora
8a5d228d37
Remove unused SCSS variable -button-size-mobile (#11507)
Missed on original #11411 changes
2024-01-22 18:35:42 +10:00
nandini584
c99c74cc7e Ensure panel anchor sizes meet minimum accessible size
Fixes #11411
2024-01-20 22:01:59 +10:00
Jaivignesh-afk
95ee796a0f Remove unused variables & mixins + update *-padding to rem
- Fixes #11458
2024-01-20 21:22:02 +10:00
nandini584
65f8a84cee Clean up sass variable usage
- updated the font to its direct use theme and removed -title-height
- removed the 1-time used scss variables and updated directly in the files
- Fixes #11458
2024-01-20 21:22:02 +10:00
LB Johnston
d7e52d1498 Add unit tests & small fixes to OrderableController
- Fix edge case where keyboard ordering and then drag drop ordering could get out of sync
- Ensure the sortable instance is cleaned up if the controller gets removed
- Relates to PR #11250 & Issue #10909
2024-01-20 10:05:21 +10:00
Aman Pandey
ef9375c475
Fix: Remove blur action from orderable controller (#11476)
* remove blur action from orderable controller as it will update whenever any move is made
* change aria description for instructions
2024-01-19 22:25:17 +10:00
Aman Pandey
735aaa95bf Adopt w-orderable for page order drag & drop/move
- Fixes #10909
2024-01-19 08:48:48 +10:00
Aman Pandey
bf3e317a48 Migrate jQuery re-ordering to Stimulus controller w-orderable
- Install and use Sortable.js and not a jQuery plugin
- Set up new controller OrderableController / w-orderable
2024-01-19 08:48:48 +10:00
Sage Abdullah
dae20c2038
Add status side panel to generic CreateView and simplify snippets CreateView 2024-01-18 15:57:44 +00:00
Sage Abdullah
e04d540bd1 Add icon--directional class to mirror icons for RTL languages 2024-01-18 11:56:18 +00:00
the-r3aper7
422d6a8cbe Migrate enableDirtyFormCheck to Stimulus UnsavedController
- Include backwards compatible global function replacement
2024-01-18 08:07:16 +10:00
Thibaud Colas
d79bac199f Adjust footer action styles based on new designs 2024-01-17 16:42:00 +00:00
Thibaud Colas
7c057661ff Remove legacy dropdown component 2024-01-17 16:42:00 +00:00
Thibaud Colas
885cf7b76c Clean up footer actions styles 2024-01-17 16:42:00 +00:00
Thibaud Colas
e801e6cec4 Convert pages footer actions to dropdown_button 2024-01-17 16:39:31 +00:00
Thibaud Colas
67c97b2168 Add warning styles for dropdown-button 2024-01-17 16:39:30 +00:00
Thibaud Colas
bc461d4de3 Convert all header dropdowns to new dropdown_button component 2024-01-17 16:39:30 +00:00
Thibaud Colas
91aa28b11a Add new dropdown-button component 2024-01-17 16:39:30 +00:00
Sage Abdullah
85408d8626 Implement design for active filter pills 2024-01-17 15:33:07 +00:00
Sage Abdullah
0de0cf4dd5 Add info-125 shade to color variables 2024-01-17 15:33:07 +00:00
Matt Westcott
7fd4e14f8e Set datetimepicker events to bubble so that they trigger a filter form refresh 2024-01-17 15:33:07 +00:00
Rohit Sharma
6f93b1a2c4 Fix long comment UI issues (scroll shaking & comment overflow)
- Includes PR #11322
- Fixes #10984 (scrolling issues with long initial comments)
- Fixes #11324 (overflow of comment reply with long words)
2024-01-17 17:34:48 +10:00
nandini584
a88a775aea Ensure the sidebar account toggle has no duplicate accessible labels
- Remove the integration test for this element as it was failing even though the element has valid content.
- Fixes #11372
2024-01-17 12:43:38 +10:00
nandini584
daf0c96841 Fix close button visibility in new dialog non-message variant
- Add w-dialog root classname to support overall styling of the dialog if a message is provided
- Fix up layout of dynamic classes to avoid additional spaces
- Fixes #11306
2024-01-17 09:27:50 +10:00
DevilsAutumn
fe1a306285 Move to a select field for determining the way TableBlock will use headers
- Make the new table_header_choice select backwards compatible with tables stored before Wagtail 6.0
- Built on previous PRs #9673 & #6763
- Fixes #5989
2024-01-17 08:37:40 +10:00
Tommaso Amici
a4c18b4957 Add optional caption field to TypedTableBlock
- Closes #8507
- Make caption default to "" for tables that predate adding the caption field
- Update the html generated in JS so the rendered form matches our new styles
- Use a consistent period (full stop) at the end of the help text sentence (including table fields)
2024-01-17 08:15:35 +10:00
Aman Pandey
3de0eca7e4 Remove inline script usage for enabling commenting
- Fixes #11287
- Add basic unit tests for form element data attributes showing/not showing based on commenting configs
2024-01-15 09:01:26 +10:00
LB Johnston
b93508f4ce Enhance Stimulus InitController to support additional custom event dispatching 2024-01-15 09:01:26 +10:00
LB Johnston
edc5991f50 Remove initTooltips util & move plugins to controller files
- Fully remove initTooltips util and replace with Controller usage
- Move plugins to their used Controller files
- Export hideTooltipOnEsc as it's used by other code
- Add unit tests for plugin behaviour in the controller tests
- Fixes #10668
- Built on #10869
2024-01-11 16:23:09 +00:00
vaishnav dasari
3680e32ca8 Fix a few grammar issues in code inline docs/comments
Closes #11429
2024-01-11 07:47:29 +10:00
Thibaud Colas
bc6ef43522 Replace visuallyhidden utility class with w-sr-only 2024-01-09 15:42:08 +00:00
Thibaud Colas
8e4285a04e Remove unused visuallyvisible styles 2024-01-09 15:42:08 +00:00
Thibaud Colas
b8e7a84a72 Remove invalid CSS styles / Sass selector concatenation 2024-01-09 15:42:08 +00:00
Thibaud Colas
7e213eadde Document correct class prefix in CSS comments 2024-01-09 15:42:08 +00:00
Thibaud Colas
bdb8ebdd82 Remove unused inline, inline-block, block classes 2024-01-09 15:42:08 +00:00
Thibaud Colas
294040dc82 Drop c- prefix for transition group 2024-01-09 15:42:08 +00:00
Thibaud Colas
02b4444369 Drop c- prefix for loading spinner component 2024-01-09 15:42:08 +00:00
Thibaud Colas
0865b9d716 Remove more unused class name prefixes 2024-01-09 15:42:08 +00:00
Thibaud Colas
77af0541be Remove usage of is- CSS class prefix 2024-01-09 15:42:08 +00:00
Thibaud Colas
9e65559d0e Replace u-hidden with Tailwind equivalent with and without !important 2024-01-09 15:42:08 +00:00
Thibaud Colas
27cc553dd8 Remove unused clearfix utility 2024-01-09 15:42:08 +00:00
Thibaud Colas
bfd23e4536 Remove unused divider-before utility 2024-01-09 15:42:08 +00:00
Thibaud Colas
d799f491c4 Replace reordering utility with generic tailwind 2024-01-09 15:42:08 +00:00
Thibaud Colas
5158dd688e Replace overflow utility with Tailwind 2024-01-09 15:42:08 +00:00
Thibaud Colas
38c0557434 Remove unused CSS layers 2024-01-09 15:42:08 +00:00
Thibaud Colas
484428b2d9 Combine o-pill and c-status styles, as they are always used together 2024-01-09 15:42:08 +00:00
Thibaud Colas
22fd74a451 Remove now-unused o-icon styles 2024-01-09 15:42:08 +00:00
Thibaud Colas
7077eb02c9 Move avatar styles from objects to components 2024-01-09 15:42:08 +00:00
Badr Fourane
e25c1bb1a0
Add right-to-left (RTL) support for the caret of select inputs (#11313)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2024-01-08 16:07:52 +00:00
Matt Westcott
5a524cb90f Add tests for maxlength on RichTextBlock 2024-01-02 19:05:21 +00:00
elhussein almasri
96b5f45fad display-character-count-to-RichTextBlock 2024-01-02 19:05:21 +00:00
Sage Abdullah
d792346752 Move filters to be inside the search form and use AJAX to submit the form
Also make the search form optional. The <form> element may still be
rendered as if there is either the search form or the filters, or both.
2024-01-02 09:00:58 +00:00
Sage Abdullah
a0a0b1343c Don't add padding to first column on report pages
Report pages have styles for .report that adds margins similar to nice-padding
2024-01-02 09:00:58 +00:00
Sage Abdullah
81ea6d6266 Remove nice-padding from documents, users, and generic listing views tables
The added CSS handles the case when nice padding is removed (to make the listing
go full-width) and no bulk actions are available (e.g. a ModelViewSet index view
or some other view that extends generic listing view).

This allows us to not rely on the full-width class (which should
eventually be removed) while correctly apply the spacing regardless
whether nice-padding is used or not, and whether bulk actions are
available or not.

If nice-padding is used, then the listing view will look as they
previously do.
2024-01-02 09:00:58 +00:00
Sage Abdullah
1ad22f530d Enforce bulk action checkbox column via CSS
10px was never the right width.

Using CSS instead of the column's width attribute allows us to use media queries to change the width responsively
2024-01-02 09:00:58 +00:00
Sage Abdullah
28d21bf066 Make styles for header buttons consistent 2024-01-02 09:00:58 +00:00
Sage Abdullah
73f7a1abc4 Use button components pattern for slim header buttons 2024-01-02 09:00:58 +00:00
Sage Abdullah
c900ba6c8e Reduce slim header search bar height to match filter button 2024-01-02 09:00:58 +00:00
Sage Abdullah
8a7dd1f5a1 Don't use legacy header when breadcrumbs are used 2024-01-02 09:00:58 +00:00
Sage Abdullah
3cbf3b4b6a Add sublabel support to breadcrumbs 2024-01-02 09:00:58 +00:00
Sage Abdullah
4407c5b5b0 Improve styles of slim header's search and filters for better vertical alignment 2024-01-02 09:00:58 +00:00
Sage Abdullah
3fbf792621 Use bigger font size for last breadcrumb item by default except on create/edit views
We want to make the slim_header.html as the basis for the modern header
template that will be used everywhere, eventually replacing header.html.

Rather than making the page explorer be the special case where we want
the last item to be bigger, do it the other way around i.e. use the
smaller font size on the create/edit views. This ensures that the big
font size is used on all other views e.g. Inspect view.
2024-01-02 09:00:58 +00:00
Sage Abdullah
f4f08ee2fe Move breadcrumbs styling in _listing.scss to its own _breadcrumbs.scss file 2024-01-02 09:00:58 +00:00
Sage Abdullah
6f92a71253 Move page explorer header's extra spacing to CSS
For better colocation with the CSS that increases the font size
2024-01-02 09:00:58 +00:00
Sage Abdullah
3c5f485201 Introduce get_header_title in WagtailAdminTemplateMixin for <title> and slim header's h1 2024-01-02 09:00:58 +00:00
Sage Abdullah
b0deeab728 Change page listing's add button to icon-only 2024-01-02 09:00:58 +00:00
Thibaud Colas
6cc4533a6f Refactor float usage within admin styles. Fix #8126 2023-12-19 15:38:22 +00:00
Matt Westcott
3c648369b0
Use a floating dialog for filters
Remove use of shared/filters.html, as it contains a duplicate `<form>` element we don't want, and generally has more stuff we don't want than stuff we do, to the point that it'll just get in the way of restyling.
2023-12-18 14:55:18 +00:00
Matt Westcott
4e59266743
Use checkboxes for page type filter 2023-12-18 14:55:17 +00:00
LB Johnston
ffc6ac8833 Adopt a small set of stylelint-config-wagtail changes
Where possible, adopt a subset of stylelint-config-wagtail changes.

- Formatting & ordering (auto applied), this includes the padding/inset shorthand changes
- Adopt a small set of no-union-classes changes as an example of changes to come in future PRs
- Ignore some areas where we are selecting against data* attributes that will not be practical to change
- Move some no-important ignore rules to specific lines
- Ignore max-combinators in modeladmin styles (legacy)
- Remove error messages forced-color-adjust setting to none
2023-12-18 13:28:18 +00:00