Matt Westcott
3c3bb68a9b
Make ExpandingFormset responsible for managing the opts dict again
...
With the custom onAdd logic eliminated, it is now safe for ExpandingFormset and InlinePanel to work from the same opts dict
2022-12-08 07:37:32 +10:00
Matt Westcott
54a1901c69
move InlinePanel onAdd logic into an overridden addForm method
2022-12-08 07:37:32 +10:00
Matt Westcott
100727eb13
make InlinePanel a subclass of ExpandingFormset
2022-12-08 07:37:32 +10:00
Matt Westcott
c632df8dee
Allow skipping onAdd/onInit callbacks when adding a new form to ExpandingFormset
...
This will help us to make InlinePanel a subclass of ExpandingFormset, since we'll want InlinePanel to extend the addForm method and only call the callbacks after it's done its thing.
Also rename this.opts in ExpandingFormset, so that we can have a separate set of options passed to ExpandingFormset while we're refactoring.
2022-12-08 07:37:32 +10:00
Matt Westcott
24a8a459b4
Fix misleading use of formCount in form 'add' logic
2022-12-08 07:37:32 +10:00
Matt Westcott
9f3c0b0492
Add an addForm API endpoint to InlinePanel
2022-12-08 07:37:32 +10:00
Matt Westcott
ef9d56723d
Make InlinePanel into a proper JS component class
2022-12-08 07:37:32 +10:00
Matt Westcott
393c1b3374
Move InlinePanel include module to components
2022-12-08 07:37:32 +10:00
Matt Westcott
89099d9a19
Import the ExpandingFormset class for InlinePanel instead of calling window.buildExpandingFormset
...
This eliminates the dependency on expanding-formset.js, and avoids having to mock buildExpandingFormset when testing InlinePanel
2022-12-03 15:53:48 +10:00
Matt Westcott
2834cd5ad5
Move ExpandingFormset tests to the component module
2022-12-03 15:53:48 +10:00
Matt Westcott
3b4cb3cafe
Convert buildExpandingFormset into a component class
2022-12-03 15:53:48 +10:00
Sage Abdullah
a5b372e47a
Remove grey background from .content-wrapper
...
- Fixes #9667
2022-11-30 07:57:38 +10:00
dependabot[bot]
ccf6ec15f7
Bump minimatch from 3.0.4 to 3.1.2 in /client/tests/integration
...
Bumps [minimatch](https://github.com/isaacs/minimatch ) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases )
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2 )
---
updated-dependencies:
- dependency-name: minimatch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-11-29 07:57:41 +10:00
Thibaud Colas
bf217a54fb
Use the correct padding for autocomplete block picker
2022-11-28 11:44:22 +00:00
Loic Teixeira
5c1c2c8f53
Enforce the use of a single string formatting mechanism for translation source strings
...
Close #9377
2022-11-26 11:00:05 +01:00
Thibaud Colas
713636a00e
Always show the page editor title field’s border when the field is empty. Fix #9318 ( #9719 )
2022-11-25 17:16:05 +00:00
4the4ryushin
a03bbba347
Fix pluralisation for Tab error count shown to screen readers
...
Fixes #9521
2022-11-23 07:52:24 +10:00
Lovelyfin00
731f96e9a8
Removed no plus plus eslint rule and fixed errors from linting
...
- Relates to #8731
2022-11-23 07:39:35 +10:00
Theresa-o
af1f1715a3
Refine the grid position of uploaded images
...
Closes #9674
Ensure that when there are less images to fill up the columns, the columns still have the same max width
2022-11-20 21:18:23 +10:00
Ivy
4fbccd1c88
Support text resizing in workflow steps cards ( #9525 )
...
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2022-11-18 23:23:39 +00:00
Theresa-o
8d30e716f7
Move DateField, DateTimeField, TimeField comment buttons to be right next to the fields. Fix #9543 ( #9549 )
...
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2022-11-18 23:07:24 +00:00
Coen van der Kamp
b91ed2cce4
Allow button labels to wrap onto two lines in dropdown buttons. Fix #9613 ( #9643 )
...
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2022-11-17 16:37:21 +00:00
sage
8cd8769eb6
Use consistent heading styles on top-level fields in the page editor ( #9659 )
...
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2022-11-17 16:23:38 +00:00
sage
dd0d2c4b88
Make it possible to resize the page editor’s side panels ( #9276 )
...
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2022-11-17 15:53:15 +00:00
Yekasumah
119f288a3c
Added unit tests & JSDoc to initDissmisibles
...
- Fixes #9495
2022-11-17 18:21:25 +10:00
jacobtoppm
34c37bc914
Stop comments being added on inline panels
...
- They do not have stable ids when models are not persisted to the database
- Fixes #9641
This feature should was enabled unintentionally. It would be great to add the ability to comment on child models in the future, but just like ListBlock before the addition of ids, we need a stable way to calculate the id to attach a comment before we can do this. This is a problem we'll need to solve - potentially via a uuid field on the model to identify models that haven't yet been saved to the database outside revisions.
2022-11-17 07:55:30 +10:00
Sage Abdullah
87e868d315
Move preview_settings to wagtail_config template tag
2022-11-11 14:18:12 +00:00
Sage Abdullah
ff8a33733c
Use CSRF_HEADER_NAME from global config for preview panel DELETE request
2022-11-11 14:18:12 +00:00
xomcodes
4eb720b6c6
Move initTagField from core.js to initTagField.ts
...
- Add JSDoc & unit tests for pulled out includes file
- Fixes #9496
2022-11-11 08:08:39 +10:00
Thibaud Colas
77a63c224f
Make sure minimap error indicators follow the minimap scrolling ( #9624 )
2022-11-10 08:31:00 +00:00
FatumaA
d4792785b8
Refactor - convert initTooltips to TypeScript, add JSDoc & tests
...
- Fixes #9505
2022-11-10 07:34:43 +10:00
Seremba
dcd8148dfe
Style default secondary buttons with icons
...
- Style secondary button with icon to match according to Wagtail Design System
- Fixes #9198
2022-11-10 07:24:27 +10:00
Albina Starykova
d36790640e
Remove unnecessary box-sizing: border-box declarations
...
- box-sizing: border-box added to all elements globally in #8921
- Relates to #9031
2022-11-10 06:52:09 +10:00
Lovelyfin00
933a730928
Removed no-prototype-builtins rule from eslintrc and fixed minor additional issues
2022-11-10 06:40:40 +10:00
Lovelyfin00
67c7f82de5
Create a util hasOwn
to simplify object property checks
2022-11-10 06:40:40 +10:00
mohammadareeb95
66f2512ef5
Ensure links that have .nolink (current link) can be seen in WHCM
...
- Fixes #9578
2022-11-09 22:55:03 +10:00
AdeboyeJuliet
c225172c1f
fix:Tippy tooltip arrows render as rectangles in WHCM
...
- Fixes #8835
2022-11-09 22:12:57 +10:00
Albina Starykova
b1c4ca5489
Fix tag field styles in WHCM
...
- Fixes #9529
2022-11-09 21:45:50 +10:00
AdeboyeJuliet
f41a219697
Migrate initSkipLink to typescript, add unit tests & JSDOC
...
- Additionally clean up the exports and imports to be sorted & align with named export usage
- Fixes #9541
2022-11-09 21:25:53 +10:00
Dev-Yusuf
c2ba84e825
Resolved the skip link contrast issues to meet requirements
...
- Update client/scss/components/_skiplink.scss
- fixes #9515
2022-11-09 21:17:37 +10:00
LB Johnston
55f5cad7f2
Ensure the ngettext (JS) util emulates the Django global if not present
...
Follow up from #9617
2022-11-08 09:09:45 +10:00
Lovelyfin00
0000ed88f7
removed unused styles from utility.legacy.scss file and clean up
...
- `divider-before` not used
- add w-list-none to Tailwind utility classes
- remove now unused unlist class
- relates to #8947
2022-11-08 08:45:23 +10:00
LB Johnston
da36c3994b
Rename test file - #9593
2022-11-08 08:38:56 +10:00
Lovelyfin00
b1c1618c9b
Migrated initButtonSelects from core.js to own includes file
...
- removed initButtonSelects from core.js , migrate to Typescript & and wrote test for it
- Fixes #9494
2022-11-08 08:28:59 +10:00
Matt Westcott
5703bc1133
Fix disabled style on StreamField add button
...
Fixes #9512
An `opacity: 0.2` style is defined for the disabled button state, but the `opacity: 1` hover style takes precedence over it. As a result, the only time it kicks in - on media with hover support - is when the StreamField does NOT have hover / focus, which would ordinarily be the time when the button is hidden entirely.
Fix this by adding hover states to the `&[disabled]` case, to match the order of precedence for the normal button state.
2022-11-07 12:24:54 +00:00
Theresa-o
0ebdd51882
Fix help block <a> to meet colour contrast guidelines
...
- Fixes #9569
2022-11-07 19:56:36 +10:00
LB Johnston
acd412e8f3
Update gettext unit tests to clearly test their functionality
...
- instead of mocking the Django global functions, test each function's export that it correctly uses the global if present or test the default behaviour
2022-11-07 19:51:13 +10:00
LB Johnston
e609f15a93
Ignore test files from extract-translatable-strings
...
Avoid unit test translation usage from being added to translation strings
2022-11-07 19:51:13 +10:00
LB (Ben Johnston)
f6a35268c7
cleanup - remove commented out scss in _listing.scss ( #9619 )
2022-11-06 23:27:05 +01:00
Yekasumah
aeae816b27
Fix comments notice background overflow ( #9567 )
2022-11-04 18:24:13 -04:00