0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Commit Graph

1451 Commits

Author SHA1 Message Date
LB Johnston
76a0c4968a Adopt classname instead of classnames in all MenuItem/Sidebar usage
- Adds a deprecation path, including documentation to further remove unpredictable naming of adding `classname` in Python APIs
- Intentionally keeps `classNames` in Telepath adaptor inner usage as this convention is not set, however, the server side value passed in will use `classname`
- See https://docs.wagtail.org/en/stable/contributing/general_guidelines.html#use-classname-in-python-html-template-tag-variables
- See #9769 & #9770
2023-10-04 08:05:52 +11:00
Matt Westcott
235f1f4104 Set title line-height in em rather than rem 2023-09-21 09:51:51 +01:00
Matt Westcott
2ed0910e26 Remove margin on ul elements within tables
Fixes the Usage view - https://github.com/wagtail/wagtail/pull/10896#discussion_r1328281681
2023-09-21 09:51:51 +01:00
Matt Westcott
4c7a1aae94 Make action buttons in listings always visible 2023-09-21 09:51:51 +01:00
Matt Westcott
210a9c5df3 Set title-wrapper to inline so we don't have to change it to a span everywhere 2023-09-21 09:51:51 +01:00
Matt Westcott
04eca55b13 Add folder icon for pages with children 2023-09-21 09:51:51 +01:00
Matt Westcott
1746cdec58 Remove align-top classname and use top alignment in listings as standard
This is the most sensible rendering when one cell's content is overly tall - see for example the thumb image column on the bakerydemo People listing.
2023-09-21 09:51:51 +01:00
Matt Westcott
7ee53a9714 Update listing table styling 2023-09-21 09:51:51 +01:00
mansi0829
0fde1ca404 Update InlinePanel JS to support empty form as Template
- Keep backwards compatibility with script element
2023-09-17 21:20:51 +10:00
Subhajit Ghosh
f86a832a4b Add support for offset value in Dropdown & Tooltip controllers 2023-09-14 09:09:59 +10:00
LB Johnston
aa6f190139 Clean up - align html template tag usage in tests
- There is one case where the closing tag was malformed
- All other cases are just ensuring the final backtick is on the closing tag's line
- This allows IDEs to better pick up on html within template tags
2023-09-13 15:06:52 +01:00
LB Johnston
51353c7c43
Do not use jest inside stubs.js to prevent Storybook from crashing 2023-09-13 15:04:04 +01:00
faishalmanzar
3a86efaf12 Add ability for InlinePanel to set focus on newly created items
Fixes #10764 - Inserting a new InlinePanel function improved
2023-09-13 07:54:57 +10:00
LB Johnston
b96d2d7faa Adopt w-messages (CloneController) in unsaved changes warning
- Replace global util window.updateFooterSaveWarning with the w-messages usage
- Remove window.updateFooterSaveWarning usage in core.js & move 'delay before clearing' time delay to the Stimulus value
- Fix JSDoc usage in `enableDirtyFormCheck`
- Add aria-live="polite" so message updates can be advised to screen readers
- Add release considerations and for `window.updateFooterSaveWarning` removal
- Closes #10091
2023-09-13 07:40:04 +10:00
Hussain Saherwala
e4fdf6da2a Update CloneController / w-clone for editor unsaved messages
- Changes default show-delay to zero (immediate) and update the w-messages (page messages) to have the 100ms delay
- Add support for 'hide' classes to be added/removed based on clone usage
- Add support for calling the clear method from actions, and resetting classes if used after a clear delay value
- Add JSDoc descriptions to most other properties, add better TS types
- Pull out logic to get template content to class method
- Based on initial work in #10327
2023-09-13 07:40:04 +10:00
LB Johnston
65a40f39e3 Rename MessagesController to CloneController
- Register with two identifiers; w-messages & w-clone
- Update unit tests and basic JSDoc to align with new naming
- This allows the Controller to reflect the 'behaviour' not the 'usage'
2023-09-13 07:40:04 +10:00
LB Johnston
325d584a9b Refine debounce implementation
- Allow the debounced function to be used with a Promise API
- Allow debounce to be called with a non-number/falsey to indicate there should be no wait (runs immediately)
- Add error handling
- Refine types to be better to work with for callers
- Add full unit test suite to implementation
2023-09-13 07:40:04 +10:00
Gareth Palmer
a63689869e Add support for merging cells in TableBlock.
Handsontable has support for merging table cells using the `mergeCells`
plugin but there was no support in Wagtail for storing which cells have
been merged or rendering them in the output template.

The client JavaScript will now save which cells have been merged and
the output template will merge or hide cells.

See https://handsontable.com/docs/6.2.0/Options.html#mergeCells
2023-09-08 08:30:49 +10:00
Matt Westcott
a3029bbe3a Implement linked_fields on ChooserViewSet 2023-09-06 15:58:36 +01:00
LB Johnston
8a52269da5 Update w-breadcrumb root class to w-breadcrumbs (plural)
- This way we align with the controller name
2023-09-05 20:05:56 +10:00
LB Johnston
857ea05c2e Migrate breadcrumb JS to Stimulus RevealController
- Adds a new generic `RevealController` that handles the ability for content to be opened/closed while updating the relevant parts of the DOM such as aria-expanded on the toggle.
- Register this controller as a generic `w-reveal` and also the `w-breadcrumb` identifiers so that we can differentiate usage via different DOM attributes and events.
- Closes #10118
2023-09-05 20:05:56 +10:00
LB Johnston
0d09eba59e Rename breadcrumbs.js to RevealController 2023-09-05 20:05:56 +10:00
LB Johnston
dfaa488add Remove work arounds for dispatch target events
- See https://github.com/hotwired/stimulus/issues/642
- Adopt streamlined approach in SwapController for 'targetElement'
2023-08-24 17:01:56 +02:00
LB Johnston
585a08fea0 Adopt w-bulk Stimulus controller for form submissions listing 2023-08-24 20:53:49 +10:00
LB Johnston
b9b444fd70 Clean up unit tests that passed a function/data to Promise.resolve
- Passing anything to Promise.resolve just means that will be the return value of the promise (.then)
- This does not actually run the function (e.g. in the case of requestAnimationFrame)
- Avoiding unit tests that could cause confusion in the future
2023-08-09 09:00:34 +10:00
Storm B. Heg
2c43ddbbd3 Add support for options/attrs in Telepath widgets & add required/aria-describedby
- This allows us to pass extra data for the widget to use in a backwards-compatible way.
- FieldBlock: render 'required' and 'aria-describedby' attributes when appropriate
- Ensure options passed to `render` override defaults
- FieldBlock: add test proving options are constructed and passed down
- Allow Telepath's widget rendering to take options
- Include extra accessibility-related attributes in html output
- Resolves missing required attribute on input elements for required fields
- Resolves missing aria-describedby attribute on input element when the field has help text.
- Partial work on #10300
2023-08-05 08:55:53 +10:00
Storm B. Heg
3be4e685c0
Remove unused WorkflowStatus view, urlpattern, and workflow-status.js 2023-08-03 15:16:08 +01:00
LB Johnston
fb340f1971 Remove CommentApp state update util
- The `update` util's types are not compatible with future TS v5 adoption.
- This util is simply a wrapper around `Object.assign` and only used in three places.
- Instead use the Object.assign in place for simplicity instead and remove the `update` util.
2023-08-02 21:00:25 +10:00
LB Johnston
1a95163138 Update eslint configs & align linting changes
- Align JS with latest Eslint package updates
- Update configs to ignore new defaults not required in test files
- Update Controller js usage & configs for classProperty naming rules
- Remove eslint ignore directives no longer required due to changed defaults
2023-08-02 21:00:25 +10:00
LB Johnston
35dfdea89c Update formatting - Prettier 3.0
- Run formatting with latest version of Prettier
2023-08-02 21:00:25 +10:00
Sage Abdullah
7fca33c47d
Fix preview panel iframe not loading immediately when preview panel is opened in snippets 2023-07-28 09:25:45 +01:00
Sage Abdullah
0eda6a0a49
Fix loading spinner being shown indefinitely in preview panel 2023-07-28 09:25:45 +01:00
Sage Abdullah
9122ab2aee
Fix initial size of 'Preview unavailable' content in preview panel 2023-07-28 09:25:45 +01:00
dependabot[bot]
f66cb7cbb5 Bump word-wrap from 1.2.3 to 1.2.4 in /client/tests/integration
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-19 18:07:56 +10:00
LB Johnston
f3c3d31e23
Ensure userbar dialog can sit above other website content
- Fixes #10471
2023-07-18 13:53:06 +01:00
LB Johnston
aa3863f17c DropdownController - fix test & refine events & methods
- Test that uses setTimeout never ran as Tippy relies on `transitionend` events, which JSDom will not dispatch. Rework tests to correctly test this custom event gets dispatched
- Use Stimulus dispatch method for custom event dispatching as the controller name (e.g. 'w-dropdown') will automatically be added, work around TypeScript bug in Stimulus which should be fixed in a future release https://github.com/hotwired/stimulus/issues/642
- Add show/hide methods, pull out options to own get method
- Add unit tests for show/hide, content being in dropdown
- Relates to #10557
2023-07-18 21:46:07 +10:00
Storm B. Heg
fef8c4ac3c Ensure StreamField panels validation errors are visible (#10673)
...by rendering panels as expanded, regardless of the collapse
setting specified by the Wagtail implementor.

Fixes #8990 partially.
2023-07-18 12:43:17 +01:00
Thibaud Colas
be2eb7fafc
Use inactive field border styles for read-only FieldPanel 2023-07-18 10:42:05 +01:00
Thibaud Colas
3ae40d87f0
Use a theme-agnostic color token for read-only panels support in dark mode 2023-07-18 10:40:07 +01:00
LB Johnston
995809a318 Adopt data attribute usage of SwapController (w-swap) for all header searches
- Removes six inline scripts completely, no longer relying on window.headerSearch
- Update the fallback Stimulus Swap controller afterLoad to be a deprecated method
- Add upgrade considerations
- Fix regression from d554cbe310 where manually submitting page search results would load the partial, not full page response
- Closes #9950
2023-07-18 07:09:28 +10:00
LB Johnston
b0dc6c1ea5 Revise the default SwapController target to the more common '#listing-results' 2023-07-18 07:09:28 +10:00
LB Johnston
4afe01104b Adopt Stimulus SwapController for task-chooser-modal use case
- Builds on #9952
- Create a new method `submit` and `submitLazy` to serialise a form's inputs and submit (GET) async to replace content
- Create a lazy version of `replace` and add unit tests for it
- Partial progress on #9950
2023-07-18 06:24:49 +10:00
Albina Starykova
457e260622 Update styles for userbar and a11y checker in dark mode 2023-07-16 22:07:24 +10:00
Albina Starykova
ecb2126cea Update Wagtail logo to the latest version
- Partial progress on #10404
2023-07-16 17:20:26 +10:00
Lovelyfin00
9868be7900 Adopt DialogController & TeleportController in the userbar 2023-07-15 23:03:57 +10:00
Lovelyfin00
62786ebd13 Adopt DialogController & TeleportController in admin 2023-07-15 23:03:57 +10:00
Lovelyfin00
c556acef35 Create DialogController (w-dialog) & TeleportController (w-teleport) 2023-07-15 23:03:57 +10:00
LB Johnston
a15f7d188b Rename includes/dialog to controllers/DialogController 2023-07-15 23:03:57 +10:00
Sage Abdullah
994698d76c
Do not use FieldRowPanel for scheduled publishing fields
To prevent inconsistent layout if only one of the fields has an error
2023-07-14 15:21:57 +01:00
Sage Abdullah
876b0e0f19
Move comments counter badge markup to base SidePanelToggle component 2023-07-14 15:21:57 +01:00