0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-25 13:10:14 +01:00
Commit Graph

1226 Commits

Author SHA1 Message Date
Matt Westcott
1c2d828e7b Remove deprecated createXChooser JS functions 2023-02-08 14:25:09 +00:00
Lovelyfin00
b336536015 User - Reimplement Gravatar switching without JS
- Resolves #9972
- Avoids inline script for a solution that can be CSS/HTML only
- Use translatable alt text for when the default avatar is selected
- Relates to #1288 & #5247 (CSP compliance)
2023-02-07 21:18:31 +10:00
Aadi jindal
1ffa497886 fixed Uncaught TypeError: Cannot read properties of undefined (reading 'getTextLabel') in admin and missing stream blocks. (#10023)
Fixes #9990
2023-02-06 19:37:11 +00:00
4the4ryushin
e10dc142de
Prevent account name from overflowing the sidebar 2023-02-02 11:08:01 +00:00
Albina Starykova
2afeca2875
Refactor accessibility checker userbar item
- Move dialog template code from the userbar base template to the
  accessibility item template
- Use fragment for the total results count in the header
- Wrap dialog header in a div to allow styling it separately from the
  rest of the dialog content
- Get selector from the first element of axe violation's node.target
2023-01-27 12:31:31 +00:00
Thibaud Colas
d4544ec9ee Re-enable strictPropertyInitialization in tsconfig
- Use declare for existing Stimulus controllers
- First enabled in #9761 & then disabled in #9818
2023-01-27 11:33:49 +10:00
Sage Abdullah
d4b69cbfc1 Fix header search when q URL param is not present 2023-01-19 22:07:50 +00:00
Thibaud Colas
0fc8df059a Fix positioning of StreamField and rich text "add" toggle buttons 2023-01-19 16:57:24 +00:00
Thibaud Colas
8b231d19c6 Replace StreamField block picker with new ComboBox 2023-01-19 16:57:24 +00:00
Thibaud Colas
a176616cda Use new ComboBox component in rich text 2023-01-19 16:57:24 +00:00
Thibaud Colas
3a7e489cdf Add new ComboBox React component based on downshift 2023-01-19 16:57:24 +00:00
Albina
a3f10acae1
Userbar & accessibility checker UI improvements (#9913)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2023-01-19 16:06:11 +00:00
Sage Abdullah
711d592052
Move pages/workflow_history templates to shared 2023-01-19 14:06:11 +00:00
Thibaud Colas
e33cdbf8db
Set up CSS LTR-RTL direction variable and fix incorrect transforms (#9914). Fix #9800
- Fix Draftail block toolbar trigger overlay in RTL mode
- Fix switch component rendering in RTL mode
- Fix panel header positioning in RTL mode
- Remove unused 404 styles
- Fix comments positioning in RTL mode
- Fix sidebar sub-menus transition direction
- Fix form side panels in RTL mode
- Fix minimap positioning in RTL mode
- Fix Draftail tooltips positioning in RTL mode
- Fix page explorer transition direction in RTL mode
- Set up CSS LTR-RTL direction variable
2023-01-19 12:06:43 +00:00
Thibaud Colas
1b7f92351f Improve page editor side panel closing animation 2023-01-19 11:19:25 +00:00
Albina
55d04366f7
Axe accessibility checker integration with floating dialog component (#9899)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2023-01-18 15:59:44 +00:00
Matt Westcott
4468b55d2d Enforce max_num on MultipleChooserPanel
Enable / disable the open-modal button on reaching the limit, as we do for InlinePanel's standard add button; and when handling the response from the modal, stop adding new items when max_num is reached
2023-01-18 14:31:08 +00:00
Matt Westcott
2574204b27 Make title into a label rather than a link when in multiple choice mode 2023-01-18 14:31:08 +00:00
Matt Westcott
32f8c78b58 Enable / disable submit button once a selection is made 2023-01-18 14:31:08 +00:00
Matt Westcott
f4125d04e0 Import ChooserFactory classes in telepath endpoint files, rather than relying on them existing in the global scope 2023-01-18 14:31:08 +00:00
Matt Westcott
89179da1fd Eliminate jquery from MultipleChooserPanel 2023-01-18 14:31:08 +00:00
Matt Westcott
af168d62f8 Implement multiple chooser UI on page chooser modal 2023-01-18 14:31:08 +00:00
Matt Westcott
78b88a605a Populate MultipleChooserPanel from modal results 2023-01-18 14:31:08 +00:00
Matt Westcott
67ff655111 Add mechanism for retrieving an existing widget instance from ChooserFactory 2023-01-18 14:31:08 +00:00
Matt Westcott
d534567f81 Add checkboxes for selecting multiple items 2023-01-18 14:31:08 +00:00
Matt Westcott
e94e268ecb Recognise 'multiple' option in ChooserModal as a URL parameter to pass to the modal view
the modal view doesn't do anything with it yet
2023-01-18 14:31:08 +00:00
Matt Westcott
c66b793957 Add JS initialiser / open-modal behaviour for MultipleChooserPanel 2023-01-18 14:31:08 +00:00
Matt Westcott
d56c25704b Add openModal method to ChooserFactory 2023-01-18 14:31:08 +00:00
Matt Westcott
d70bf142f3 Pass modalUrl in opts dict as standard, and use it in preference to the data-chooser-url attribute on the HTML element
We keep data-chooser-url in the HTML output, and use it as a fallback in the JS - for backwards compatibility with existing BaseChooser subclasses that don't pass an options dict (such as AdminTaskChooser, which overrides render_js_init)
2023-01-18 14:31:08 +00:00
Matt Westcott
8fe23a4f61 Standardise on camel case for opts dictionary keys
At this point we've been turning the 'opts' dict from a private API specific to PageChooser, that more or less transparently passes options on to the modal as URL query parameters, into a convention shared across all chooser widgets where the question of "will this option become a URL parameter" is an internal implementation detail. Since this is notionally a bundle of JS variables rather than a bundle of URL params, we should take this opportunity to consistently adopt camel case, before this pattern becomes widespread in third-party code and ends up as a mishmash of camel-case and snake-case.
2023-01-18 14:31:08 +00:00
Matt Westcott
3dc3d37bbf Move FooChooserFactory definitions into the widget JS endpoints rather than the telepath ones
This makes it cleaner for FooChooser and FooChooserFactory to share definitions (e.g. modal handler classes)
2023-01-18 14:31:08 +00:00
Matt Westcott
ed8d999887 Use the base ChooserFactory class for PageChooserFactory 2023-01-18 14:31:08 +00:00
Matt Westcott
536d1096c2 Change PageChooser widget constructor to accept parent_id as part of the opts dict
The old signature is still accepted for backwards compatibility.

This then matches the signature of the other chooser widget JS classes, allowing PageChooserFactory to extend the generic ChooserFactory.
2023-01-18 14:31:08 +00:00
Matt Westcott
dcba3a9194 Consistently pass an opts dict to the constructors of Chooser and ChooserFactory 2023-01-18 14:31:07 +00:00
Matt Westcott
f238d659ee Move PageChooserFactory to its own JS endpoint
This will allow us to refactor it, including adding class-level references to window.PageChooser and window.PageChooserModal as necessary, without dealing with the possibility of telepath/widgets.js being imported before the includes that define those.
2023-01-18 14:31:07 +00:00
Matt Westcott
7a1ae9f16b Eliminate jQuery from PageChooserFactory.render
This matches the implementation in components/ChooserWidget. This change breaks the tests that pass a jQuery collection object rather than a DOM element, but that was never valid in the first place as per https://docs.wagtail.org/en/stable/reference/streamfield/widget_api.html - fix the tests accordingly.
2023-01-18 14:31:07 +00:00
Matt Westcott
947a7883f9 Add a higher-level API for chooser modals
Previously, anything invoking the chooser modal needed to make its own call to ModalWorkflow, which meant it needed to import the corresponding 'onloadHandlers' dict, know the appropriate chosen response identifier to listen to, and know how to modify the chooser URL to pass parameters (if applicable). This would mean a lot of duplicated logic if there were multiple places where the modal is invoked.

Here we introduce a ChooserModal base class which encapsulates those details - a caller just needs to instantiate it with the base URL, and call `open` on it to open the modal (passing an options dict and a response callback).
2023-01-18 14:31:07 +00:00
Lovelyfin00
b929694203 Migrate lock/unlock actions to w-action controller
- Revise 'redirect' from a string to a 'continue' boolean that defaults to false
- Use 'continue=true' for cases where we do not want to create a next param on submit that takes the user back to the current page
- Fixes #9815
2023-01-18 19:00:47 +10:00
Lovelyfin00
9e9a84c953 Pull out loadiconSprite function from inline script
- wrote test for initIconSpirite
- changed from xmlhttprequest to fetch
- prepared a domReady util
- Fixes #9811
2023-01-18 08:04:55 +10:00
Thibaud Colas
34f6bab633
Rich text toolbar refinements from usability testing. Fix #9281 (#9905) 2023-01-17 17:21:45 +00:00
Thibaud Colas
b02f08d8d9
Fix JS error in dirty form checks from NodeList - array API differences (#9906) 2023-01-17 13:43:55 +00:00
sag᠎e
c8981416ef
Load Axe configuration and error messages defined in Python (#9898)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2023-01-16 13:42:09 +00:00
Lovelyfin00
004faac53c
Migrate workflow and workflow tasks enable action to a Stimulus controller (#9844)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2023-01-12 21:55:40 +00:00
Albina
1e9f580b8c
Add base Axe accessibility checker integration within userbar, with error count (#9850)
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
2023-01-12 12:21:58 +00:00
Thibaud Colas
1884447a6b Slim header design fixes 2023-01-12 09:51:51 +00:00
Thibaud Colas
90ffcb05b0 Sidebar spacing fix 2023-01-12 09:51:51 +00:00
Thibaud Colas
eed32d01a6 Generic header spacing fixes 2023-01-12 09:51:51 +00:00
Thibaud Colas
e056a70083 Dashboard header design fixes 2023-01-12 09:51:51 +00:00
LB Johnston
c8dca0a7f2 Migrate upgrade notification to Stimulus (UpgradeController) 2023-01-12 09:26:31 +10:00
LB Johnston
e8fc3d9cf0 Rename initUpgradeNotification to UpgradeController 2023-01-12 09:26:31 +10:00