0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-24 19:17:48 +01:00
Commit Graph

670 Commits

Author SHA1 Message Date
Scott Cranfill
f886b1b65b Fix Jest snapshot once more 2021-10-31 13:00:17 -04:00
Scott Cranfill
8032539dd0 Fix line length issue and update Jest snapshot 2021-10-31 12:38:52 -04:00
Scott Cranfill
9ecf25d8ee TypedTableBlock: Add aria-label to column heading input 2021-10-31 12:28:31 -04:00
LB Johnston
274e4485f9 fix issue where nested inline panel fix broke inline panel ordering/delete 2021-10-28 13:26:42 +01:00
Matt Westcott
9fcadd9461 Make column-count hidden field include deleted columns in its count
Fixes #7654. Without this fix, the server-side logic ends up only considering column IDs up to the final number of columns in the table, so (for example) if you start with three columns, delete two and add one, it will only consider IDs up to 2 even though the last inserted column has been assigned an ID of 4.
2021-10-28 10:08:39 +01:00
Scott Cranfill
1e7fbae192
TypedTableBlock: Use SVG for add button icons; use rem units for styling (#7647)
* TypedTableBlock: Use SVG for add button icons; use rem units for styling

* Fix add row button positioning in Safari
2021-10-27 07:05:23 -07:00
Jacob Topp-Mugglestone
2f8de89a5c Feature/bulk actions move chooser fixes (#7617)
* [feat] Documents, images and users bulk actions now work with custom models as well

* [fix] Bulk move disables invalid parent pages in the page chooser modal

* [refactor] Make the code DRY

Co-authored-by: Shohan <shohanduttaroy99@gmail.com>
2021-10-15 16:51:18 +01:00
Shohan
0d8ad857bf Customize select all in listing feature (#7606)
* [feat] Add feature to customize behavior of select all objects in listing

* [feat] Select all in listing now works with search terms

* [refactor] Make the code DRY
2021-10-15 16:51:18 +01:00
Shohan
4624d2d540 Fix typos and remove unwanted code from bulk actions (#7613)
* [refactor] Fix typos and documentation

* [refactor] Remove unused attribute object_key

* [refactor] Remove filters from page explorer

* [refactor] Remove unused code of page filters
2021-10-15 16:51:18 +01:00
Shohan
8033078d6c [lint] Fix lint errors (#7608) 2021-10-15 16:51:18 +01:00
Dan Braghis
57b0d2c2d7 Improve image listing checkbox alignment
Co-Authored-By: Thibaud Colas <thibaudcolas@gmail.com>
2021-10-15 16:51:18 +01:00
Dan Braghis
247bfe883f Further tidy up following code review
Co-Authored-By: Thibaud Colas <thibaudcolas@gmail.com>
2021-10-15 16:51:18 +01:00
Dan Braghis
d19e1b4380 Tidy up based on code review 2021-10-15 16:51:18 +01:00
Dan Braghis
2688bb062c Extract bulk actions styles to own component
_listing.scss still has a couple of references to bulk actions, but they quite nested so best left in there
2021-10-15 16:51:18 +01:00
Shohan
6deafb7dd8 [fix] Fix bulk action checkboxes not hiding after deselecting all 2021-10-15 16:51:18 +01:00
Shohan
5f261910ae [fix] Fix bulk actions checkbox not working after search results 2021-10-15 16:51:18 +01:00
Shohan
9c5d0a2a26 Bulk actions - action bar UI fixes (#7403)
* [fix] Fix transform transition of action bar

* [refactor] Increase spacing in action bar, consistent with the designs

* [fix] Make button width fixed, with proper notes to accessibility

* [refactor] Decrease padding and border radius, remove borders from buttons, align action bar with titles

* [refactor] Remove border from more button and decrease font weight of button label
2021-10-15 16:51:18 +01:00
Shohan
95d5097615 Bulk actions - appropriate string for listing (#7428)
* [feat] Add separate strings for different listings

* [refactor] Change string in users listing

* [refactor] Change keys to uppercase for consistency
2021-10-15 16:51:18 +01:00
Shohan
d773e9b4d2 [feat] Add bulk action ui to images listing 2021-10-15 16:51:18 +01:00
Shohan
1b9facb377 [fix] Fix bug that caused disconnect between ui and javascipt state when using the navigate back button in chrome to cancel a bulk action (#7394) 2021-10-15 16:51:18 +01:00
Shohan
ebf2351cff [refactor] Fix typo 2021-10-15 16:51:18 +01:00
Shohan
11d50333b5 [refactor] namespace data attributes for bulk actions 2021-10-15 16:51:18 +01:00
Shohan
48e9508fc1 [refactor] Refactor based on review comments
Changed following
- Use data- attributes to select elements instead of using classes
2021-10-15 16:51:18 +01:00
Shohan
d2ce53903c [refactor] Refactor based on review comments
Changed following
- action bar now uses translate for animation instead of changing layout
- action bar is now hidden from both text readers and keyboard navigation when it is out of view
- css now doesn't use elements for styling
- 'Show all in listing' is now a button instead of an <a>
- Changed aria labels to more suitable and meaningful ones
2021-10-15 16:51:18 +01:00
Shohan
d5481b0df5 [fix] Fix small ui issues and inconsistencies in the action bar
Fixed following
- Fixed the transition time of the action bar
- Fixed the sudden jerk due to text change in the action bar
- select all text in the action bar now appears only if there are more objects to display
2021-10-15 16:51:18 +01:00
Shohan
b7f24a2d81 [refactor] Refactor existing bulk action code for reusability 2021-10-15 16:51:18 +01:00
Shohan
bc24f1eb5e [refactor] Use template literals instead of string concatention, and reduce dependency on html structure for querySelector 2021-10-15 16:51:18 +01:00
Shohan
75764a99e7 [refactor] Capitalise 'More' text using css rather than rendering uppercase text in html 2021-10-15 16:51:18 +01:00
Shohan
263d652a61 [fix] Fix css issues regarding footer and bulk action buttons
Fixed following
- The text color on the bulk action buttons used to turn white on hover. Now, the text color changes acoordingly
- Changes to footer css changed caused changes in some unwanted places. Fixed that by namespacing the css changes
2021-10-15 16:51:18 +01:00
Shohan
020f8dcfaf [feat] Move actions bar to footer and ad bulk actions to search page
Added following
- Add 'More' dropdown if there are more than 4 bulk actions
- Add bulk actions to 'Pages search' page

Changed following
- Move actions bar from headers to footer
2021-10-15 16:51:18 +01:00
Shohan
9b463f0429 [refactor] Remove repeated logic in bulk-actions.js 2021-10-15 16:51:18 +01:00
Shohan
a40d4de316 [refactor] Refactor after review commits
Added following
- Add prepare action method that runs before transaction starts
- Add a default form with a default field

Changed following
- Move permissions check in bulk move from before hook to a method that runs before the transaction starts
- Select all pages now doesn't fetch all ids, but passes id as all and the parent page id
- Change no access permissions

Fixed following
- Fix tests for changes in html
2021-10-15 16:51:18 +01:00
Shohan
403cd5eb29 [feat] Add 'Select all pages in listing' support 2021-10-15 16:51:18 +01:00
Shohan
e524ccb995 [feat] Reintroduced ordering column and remove search input box and related views 2021-10-15 16:51:18 +01:00
Shohan
3ef56faac9 [refactor] Change filters implementation
Added following
- Separate routes for getting filter count with or without parent page id
- Use already existing parse_query_string function for parsing filter string

Changed following
- apply_filters now uses django's Q object, for more flexibility of filters

Fixed following
- bulk_action_choices hook now passes existing tests
2021-10-15 16:51:18 +01:00
Shohan
f96b9c829e [refactor] Refactor code to comply with style guide 2021-10-15 16:51:18 +01:00
Shohan
f875484f73 [feat] Add support for filters and bulk actions (del, pub, and unpub)
Added following
- Add support for filters
- Add bulk delete, publish and unpublish actions (views and templates)
- Add search textbox to get filtered results
- Add view to get count of pages corresponding to a set of given filters
2021-10-15 16:51:18 +01:00
Shohan
64a1d7299f [feat] Add bulk actions in page listing
Added following
- Add bulk action checkboxes (non functional), actions, filters in page listing (non functional)
- Add search bar in page listing (non functional)
2021-10-15 16:51:18 +01:00
Thibaud Colas
a32d390b83 Fix linting issue 2021-10-15 16:17:23 +01:00
Thibaud Colas
7f72540ac3 Fix visibility of sidebar footer items when closed 2021-10-15 16:17:23 +01:00
Thibaud Colas
36a793eb1f Add keyboard interactions to sidebar footer 2021-10-15 16:17:23 +01:00
Thibaud Colas
e1f9db736d Make it possible for slim sidebar submenus to vertically scroll 2021-10-15 16:17:23 +01:00
Thibaud Colas
27428e3760 Fix vertical scrolling of main slim sidebar panel 2021-10-15 16:17:23 +01:00
Shariq Jamil
c4422b2bec add border to comments dropdown
- for windows high contrast mode
- fixes #7458
2021-10-15 23:25:09 +10:00
Matt Westcott
5e720fa1d5 Reorganise control columns to put tab order for 'insert column' buttons at start 2021-10-15 14:20:56 +01:00
Matt Westcott
eec0ad2981 Improve tab ordering of 'insert column' buttons 2021-10-15 14:20:56 +01:00
Matt Westcott
e6b0def9e2 Add aria-label attributes to buttons 2021-10-15 14:20:56 +01:00
Matt Westcott
85781dfbac Update test snapshot for new markup 2021-10-15 14:20:56 +01:00
Coen van der Kamp
8deaf401f4 Reposition bottom add row button, add bin icons 2021-10-15 14:20:56 +01:00
Coen van der Kamp
3f3f3fe319 Make remove buttons red 2021-10-15 14:20:56 +01:00