mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-25 05:02:57 +01:00
Code Issues Releases Wiki Activity

Fix: Remove blur action from orderable controller (#11476)

Browse Source 
* remove blur action from orderable controller as it will update whenever any move is made
* change aria description for instructions
This commit is contained in:
Aman Pandey 2024-01-19 17:55:17 +05:30 committed by GitHub
parent bb2658f6a3
commit ef9375c475
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/src/controllers/OrderableController.test.js
View File

@ -32,15 +32,15 @@ describe('OrderableController', () => {
data-w-orderable-message-value="'__label__' has been updated!"
>
<li data-w-orderable-target="item" data-w-orderable-item-id="73" data-w-orderable-item-label="Beef">
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply blur->w-orderable#apply">--</button>
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply">--</button>
Item 73
</li>
<li data-w-orderable-target="item" data-w-orderable-item-id="75" data-w-orderable-item-label="Cheese">
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply blur->w-orderable#apply">--</button>
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply">--</button>
Item 75
</li>
<li data-w-orderable-target="item" data-w-orderable-item-id="93" data-w-orderable-item-label="Santa">
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply blur->w-orderable#apply">--</button>
<button class="handle" type="button" data-w-orderable-target="handle" data-action="keyup.up->w-orderable#up:prevent keyup.down->w-orderable#down:prevent keydown.enter->w-orderable#apply">--</button>
Item 93
</li>
</ul>

2
wagtail/admin/templates/wagtailadmin/pages/listing/_ordering_cell.html
View File

@ -5,7 +5,7 @@
type="button"
aria-live="polite"
data-w-orderable-target="handle"
data-action="keydown.up->w-orderable#up:prevent keydown.down->w-orderable#down:prevent keydown.enter->w-orderable#apply blur->w-orderable#apply"
data-action="keydown.up->w-orderable#up:prevent keydown.down->w-orderable#down:prevent keydown.enter->w-orderable#apply"
>
{% icon name="grip" classname="default" %}
<span class="w-sr-only">

2
wagtail/admin/views/pages/listing.py
View File

@ -342,7 +342,7 @@ class BaseIndexView(generic.IndexView):
if self.show_ordering_column:
kwargs["attrs"] = {
"aria-description": _(
"Press enter to select an item, use up and down arrows to move the item. Pressing enter or moving to a different item will complete the move."
"Focus on the drag button and press up or down arrows to move the item, then press enter to submit the change."
),
"data-controller": "w-orderable",
"data-w-orderable-active-class": "w-orderable--active",