mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-25 05:02:57 +01:00
Code Issues Releases Wiki Activity

Use arrow function for hideTooltipOnClickAway to allow 'this' to refer to DropdownController

Browse Source
This commit is contained in:
Sage Abdullah 2024-01-25 10:09:12 +00:00 committed by sag​e
parent a89812f6b9
commit ea288448cd
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/src/controllers/DropdownController.ts
View File

@ -217,17 +217,11 @@ export class DropdownController extends Controller<HTMLElement> {
* elements outside of the dropdown's DOM).
*/
get hideTooltipOnClickAway() {
// We can't use `this` to access the controller instance inside the plugin
// function, so we need to get these ahead in time.
const reference = this.reference;
const toggleTarget = this.toggleTarget;
const dispatch = this.dispatch.bind(this);
return {
name: 'hideTooltipOnClickAway',
fn(instance: Instance) {
fn: (instance: Instance) => {
const onClick = (e: MouseEvent) => {
const event = dispatch('clickaway', {
const event = this.dispatch('clickaway', {
cancelable: true,
detail: { target: e.target },
});
@ -238,8 +232,8 @@ export class DropdownController extends Controller<HTMLElement> {
instance.state.isShown &&
// Hide if the click is outside of the reference element,
// or if the click is on the toggle button itself.
(!reference.contains(e.target as Node) ||
toggleTarget.contains(e.target as Node))
(!this.reference.contains(e.target as Node) ||
this.toggleTarget.contains(e.target as Node))
) {
instance.hide();
}