mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-29 09:33:54 +01:00
Code Issues Releases Wiki Activity

Merge pull request #1412 from gasman/fix/url-path-limit

Browse Source 
Convert url_path to a text field - fixes #1216
This commit is contained in:
Karl Hobley 2015-06-16 16:02:14 +01:00
commit b932ecfb3b
3 changed files with 48 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
wagtail/wagtailcore/migrations/0016_change_page_url_path_to_text_field.py Normal file
View File

@ -0,0 +1,20 @@
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
from django.db import models, migrations
class Migration(migrations.Migration):
dependencies = [
('wagtailcore', '0015_add_more_verbose_names'),
]
operations = [
migrations.AlterField(
model_name='page',
name='url_path',
field=models.TextField(verbose_name='URL path', editable=False, blank=True),
preserve_default=True,
),
]

2
wagtail/wagtailcore/models.py
View File

@ -274,7 +274,7 @@ class Page(six.with_metaclass(PageBase, MP_Node, ClusterableModel, index.Indexed
content_type = models.ForeignKey('contenttypes.ContentType', verbose_name=_('Content type'), related_name='pages')
live = models.BooleanField(verbose_name=_('Live'), default=True, editable=False)
has_unpublished_changes = models.BooleanField(verbose_name=_('Has unpublished changes'), default=False, editable=False)
url_path = models.CharField(verbose_name=_('URL path'), max_length=255, blank=True, editable=False)
url_path = models.TextField(verbose_name=_('URL path'), blank=True, editable=False)
owner = models.ForeignKey(settings.AUTH_USER_MODEL, verbose_name=_('Owner'), null=True, blank=True, editable=False, on_delete=models.SET_NULL, related_name='owned_pages')
seo_title = models.CharField(verbose_name=_("Page title"), max_length=255, blank=True, help_text=_("Optional. 'Search Engine Friendly' title. This will appear at the top of the browser window."))

27
wagtail/wagtailcore/tests/test_page_model.py
View File

@ -677,3 +677,30 @@ class TestIssue756(TestCase):
# Check that latest_revision_created_at is still set
self.assertIsNotNone(Page.objects.get(id=1).latest_revision_created_at)
class TestIssue1216(TestCase):
"""
Test that url paths greater than 255 characters are supported
"""
fixtures = ['test.json']
def test_url_path_can_exceed_255_characters(self):
event_index = Page.objects.get(url_path='/home/events/')
christmas_event = EventPage.objects.get(url_path='/home/events/christmas/')
# Change the christmas_event slug first - this way, we test that the process for
# updating child url paths also handles >255 character paths correctly
new_christmas_slug = "christmas-%s-christmas" % ("0123456789" * 20)
christmas_event.slug = new_christmas_slug
christmas_event.save_revision().publish()
# Change the event index slug and publish it
new_event_index_slug = "events-%s-events" % ("0123456789" * 20)
event_index.slug = new_event_index_slug
event_index.save_revision().publish()
# Check that the url path updated correctly
new_christmas_event = EventPage.objects.get(id=christmas_event.id)
expected_url_path = "/home/%s/%s/" % (new_event_index_slug, new_christmas_slug)
self.assertEqual(new_christmas_event.url_path, expected_url_path)