mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Code Issues Releases Wiki Activity

Fix bulk page publishing

Browse Source 
Fixes #7690. We need to retrieve the specific page instance before `save_revision`, or we'll end up clearing the subclass's fields (resulting in a ValidationError if any were required, or a published version with blanked fields if not).
This commit is contained in:
Matt Westcott 2021-11-10 19:08:16 +00:00 committed by Matt Westcott
parent 33445188e7
commit a54e242709
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
wagtail/admin/tests/pages/test_bulk_actions/test_bulk_publish.py
View File

@ -9,6 +9,7 @@ from django.utils.translation import gettext_lazy as _
from wagtail.admin.views.pages.bulk_actions.page_bulk_action import PageBulkAction
from wagtail.core.models import Page
from wagtail.core.signals import page_published
from wagtail.tests.testapp.models import SimplePage
from wagtail.tests.utils import WagtailTestUtils
@ -18,7 +19,7 @@ class TestBulkPublish(TestCase, WagtailTestUtils):
# Add child pages
self.child_pages = [
Page(title=f"Hello world!-{i}", slug=f"hello-world-{i}", live=False)
SimplePage(title=f"Hello world!-{i}", slug=f"hello-world-{i}", content=f"Hello world {i}!", live=False)
for i in range(1, 5)
]
self.pages_to_be_published = self.child_pages[:3]
@ -168,7 +169,7 @@ class TestBulkPublishIncludingDescendants(TestCase, WagtailTestUtils):
# Add child pages
self.child_pages = [
Page(title=f"Hello world!-{i}", slug=f"hello-world-{i}", live=False)
SimplePage(title=f"Hello world!-{i}", slug=f"hello-world-{i}", content=f"Hello world {i}!", live=False)
for i in range(1, 5)
]
self.pages_to_be_published = self.child_pages[:3]
@ -179,10 +180,11 @@ class TestBulkPublishIncludingDescendants(TestCase, WagtailTestUtils):
# map of the form { page: [child_pages] } to be added
self.grandchildren_pages = {
self.pages_to_be_published[0]: [Page(title="Hello world!-a", slug="hello-world-a", live=False)],
self.pages_to_be_published[0]: [
SimplePage(title="Hello world!-a", slug="hello-world-a", content="Hello world a!", live=False)],
self.pages_to_be_published[1]: [
Page(title="Hello world!-b", slug="hello-world-b", live=False),
Page(title="Hello world!-c", slug="hello-world-c", live=False)
SimplePage(title="Hello world!-b", slug="hello-world-b", content="Hello world b!", live=False),
SimplePage(title="Hello world!-c", slug="hello-world-c", content="Hello world c!", live=False)
]
}
for child_page, grandchild_pages in self.grandchildren_pages.items():

1
wagtail/admin/views/pages/bulk_actions/publish.py
View File

@ -34,6 +34,7 @@ class PublishBulkAction(PageBulkAction):
def execute_action(cls, objects, include_descendants=False, user=None, **kwargs):
num_parent_objects, num_child_objects = 0, 0
for page in objects:
page = page.specific
revision = page.save_revision(user=user)
revision.publish(user=user)
num_parent_objects += 1