0
0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-25 13:10:14 +01:00

Remove double tagit initialisation

tagit was initialized from both the AdminTagWidget, and from the `done`
method in the image uploader. Initializing it twice led to strange
errors and ultimately the tags not being saved on the image model.

As the tag widget now contains its own initialisation <script>, tag
inputs do not need to be specially handled by AJAX code any more, so
this can simply be removed.

Fixes #2142
This commit is contained in:
Tim Heap 2016-01-25 13:30:19 +11:00 committed by Matt Westcott
parent d68f4829c4
commit 66da5ad5ad
3 changed files with 2 additions and 3 deletions

View File

@ -15,6 +15,7 @@ Changelog
* Fix: `ChooserBlock` now correctly handles models with primary keys other than `id` (alexpilot11)
* Fix: Fixed typo in Wistia oEmbed pattern (Josh Hurd)
* Fix: Added more accurate help text for the Administrator flag on user accounts (Matt Fozard)
* Fix: Tags added on the multiple image uploader are now saved correctly
1.3.1 (05.01.2016)
~~~~~~~~~~~~~~~~~~

View File

@ -34,6 +34,7 @@ Bug fixes
* ``ChooserBlock`` now correctly handles models with primary keys other than ``id`` (alexpilot11)
* Fixed typo in Wistia oEmbed pattern (Josh Hurd)
* Added more accurate help text for the Administrator flag on user accounts (Matt Fozard)
* Tags added on the multiple image uploader are now saved correctly
Upgrade considerations

View File

@ -105,9 +105,6 @@ $(function() {
itemElement.addClass('upload-success')
$('.right', itemElement).append(response.form);
// run tagit enhancement
$('.tag_field input', itemElement).tagit(window.tagit_opts);
} else {
itemElement.addClass('upload-failure');
$('.right .error_messages', itemElement).append(response.error_message);