mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Code Issues Releases Wiki Activity

Cache the SVG icon HTML fragment

Browse Source 
The `{% icons %}` tag runs on every admin page render, and without caching, this will perform a template fetch for every .svg file - which is exceptionally slow on environments with shared filesystems (e.g. Vagrant). Adding this cache reduces the runtime of `wagtail.admin.tests.pages.test_create_page` from 89 to 57 seconds.
This commit is contained in:
Matt Westcott 2020-08-03 14:48:51 +01:00 committed by Matt Westcott
parent f1d7c7d208
commit 5fe3002e76
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
wagtail/admin/templatetags/wagtailadmin_tags.py
View File

@ -547,11 +547,18 @@ def icon(name=None, class_name='icon', title=None, wrapped=False):
}
@register.inclusion_tag("wagtailadmin/shared/icons.html")
_icons_html = None
@register.simple_tag
def icons():
icon_hooks = hooks.get_hooks('register_icons')
icons = sorted(itertools.chain.from_iterable(hook([]) for hook in icon_hooks))
return {'icons': icons}
global _icons_html
if _icons_html is None:
icon_hooks = hooks.get_hooks('register_icons')
icons = sorted(itertools.chain.from_iterable(hook([]) for hook in icon_hooks))
_icons_html = render_to_string("wagtailadmin/shared/icons.html", {'icons': icons})
return _icons_html
@register.filter()