mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-11-25 05:02:57 +01:00
Code Issues Releases Wiki Activity

SwapController - Ensure untrusted data sources are logged correctly

Browse Source 
Avoids the rare case of `requestUrl` being used to log out an object
Fixes #11212
This commit is contained in:
LB Johnston 2023-11-10 06:29:34 +10:00 committed by LB (Ben Johnston)
parent 11570f0072
commit 5fd8ebf171
4 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.txt
View File

@ -57,6 +57,7 @@ Changelog
* Maintenance: Refactor `page_breadcrumbs` tag to use shared `breadcrumbs.html` template (Sage Abdullah)
* Maintenance: Add `keyboard` icon to admin icon set (Rohit Sharma)
* Maintenance: Remove dead code in the minimap when elements are not found (LB (Ben) Johnston)
* Maintenance: Ensure untrusted data sources are logged correctly in the Stimulus `SwapController` (LB (Ben) Johnston)
6.0.2 (xx.xx.xxxx) - IN DEVELOPMENT

3
client/src/controllers/SwapController.test.js
View File

@ -410,7 +410,8 @@ describe('SwapController', () => {
// eslint-disable-next-line no-console
expect(console.error).toHaveBeenLastCalledWith(
'Error fetching /admin/images/results/?q=alpha',
'Error fetching %s',
'/admin/images/results/?q=alpha',
expect.any(Error),
);

2
client/src/controllers/SwapController.ts
View File

@ -303,7 +303,7 @@ export class SwapController extends Controller<
target,
});
// eslint-disable-next-line no-console
console.error(`Error fetching ${requestUrl}`, error);
console.error('Error fetching %s', requestUrl, error);
})
.finally(() => {
if (signal === this.abortController?.signal) {

1
docs/releases/6.1.md
View File

@ -79,6 +79,7 @@ depth: 1
* Refactor `page_breadcrumbs` tag to use shared `breadcrumbs.html` template (Sage Abdullah)
* Add `keyboard` icon to admin icon set (Rohit Sharma)
* Remove dead code in the minimap when elements are not found (LB (Ben) Johnston)
* Ensure untrusted data sources are logged correctly in the Stimulus `SwapController` (LB (Ben) Johnston)
## Upgrade considerations