mirrors/wagtail
mirrors/wagtail
0
0
Fork 0
mirror of https://github.com/wagtail/wagtail.git synced 2024-12-01 11:41:20 +01:00
Code Issues Releases Wiki Activity

Revert "Add role="table" to TableBlock output" (#5977)

Browse Source
This commit is contained in:
Thibaud Colas 2020-04-28 09:02:38 +01:00 committed by GitHub
parent 165c5c0ce5
commit 2af880025a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.txt
View File

@ -13,6 +13,7 @@ Changelog
* `AbstractEmailForm` now has a separate method (`render_email`) to build up email content on submission emails (Haydn Greatnews)
* Fix: Ensure link to add a new user works when no users are visible in the users list (LB (Ben Johnston))
* Fix: `AbstractEmailForm` saved submission fields are now aligned with the email content fields, `form.cleaned_data` will be used instead of `form.fields` (Haydn Greatnews)
* Fix: Removed ARIA `role="table"` from TableBlock output (Thibaud Colas)
2.9 (xx.xx.xxxx) - IN DEVELOPMENT

1
docs/releases/2.10.rst
View File

@ -27,6 +27,7 @@ Bug fixes
* Ensure link to add a new user works when no users are visible in the users list (LB (Ben Johnston))
* ``AbstractEmailForm`` saved submission fields are now aligned with the email content fields, ``form.cleaned_data`` will be used instead of ``form.fields`` (Haydn Greatnews)
* Removed ARIA `role="table"` from TableBlock output (Thibaud Colas)
Upgrade considerations

2
wagtail/contrib/table_block/templates/table_block/blocks/table.html
View File

@ -1,6 +1,6 @@
{% load table_block_tags %}
<table role="table">
<table>
{% if table_caption %}
<caption>{{ table_caption }}</caption>
{% endif %}

16
wagtail/contrib/table_block/tests.py
View File

@ -37,7 +37,7 @@ class TestTableBlock(TestCase):
block = TableBlock()
result = block.render(value)
expected = """
<table role="table">
<table>
<tbody>
<tr><td>Test 1</td><td>Test 2</td><td>Test 3</td></tr>
<tr><td></td><td></td><td></td></tr>
@ -61,7 +61,7 @@ class TestTableBlock(TestCase):
block = TableBlock()
result = block.render(value)
expected = """
<table role="table">
<table>
<thead>
<tr><th scope="col">Test 1</th><th scope="col" class="htLeft">Test 2</th><th scope="col">Test 3</th></tr>
</thead>
@ -90,7 +90,7 @@ class TestTableBlock(TestCase):
]
})
expected = """
<table role="table">
<table>
<tbody>
<tr><td></td><td></td><td></td></tr>
<tr><td></td><td></td><td></td></tr>
@ -110,7 +110,7 @@ class TestTableBlock(TestCase):
[None, None, None]]}
expected = """
<table role="table">
<table>
<tbody>
<tr><td>&lt;p&gt;&lt;strong&gt;Test&lt;/strong&gt;&lt;/p&gt;</td><td></td><td></td></tr>
<tr><td></td><td></td><td></td></tr>
@ -131,7 +131,7 @@ class TestTableBlock(TestCase):
'data': [['Foo', 'Bar', 'Baz'], [None, None, None], [None, None, None]]}
expected = """
<table role="table">
<table>
<thead>
<tr><th scope="col">Foo</th><th scope="col">Bar</th><th scope="col">Baz</th></tr>
</thead>
@ -153,7 +153,7 @@ class TestTableBlock(TestCase):
'data': [['Foo', 'Bar', 'Baz'], ['one', 'two', 'three'], ['four', 'five', 'six']]}
expected = """
<table role="table">
<table>
<tbody>
<tr><th scope="row">Foo</th><td>Bar</td><td>Baz</td></tr>
<tr><th scope="row">one</th><td>two</td><td>three</td></tr>
@ -173,7 +173,7 @@ class TestTableBlock(TestCase):
'data': [['Foo', 'Bar', 'Baz'], ['one', 'two', 'three'], ['four', 'five', 'six']]}
expected = """
<table role="table">
<table>
<thead>
<tr><th scope="col">Foo</th><th scope="col">Bar</th><th scope="col">Baz</th></tr>
</thead>
@ -258,7 +258,7 @@ class TestTableBlock(TestCase):
block = TableBlock()
result = block.render(value)
expected = """
<table role="table">
<table>
<caption>caption</caption>
<tbody>
<tr><td>Test 1</td><td>Test 2</td><td>Test 3</td></tr>