From 7f0dda6a449e169dabfe4f03f4e9f820e31df629 Mon Sep 17 00:00:00 2001 From: Louis Lam Date: Tue, 26 Oct 2021 11:28:38 +0800 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e521b6c19..4cbf24232 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,7 +40,8 @@ If you are not sure whether I will accept your pull request, feel free to create 1. Create an empty commit `git commit -m "[empty commit] pull request for " --allow-empty` 1. Push to your fork repo -1. Create a pull request: https://github.com/louislam/uptime-kuma/compare +1. Create a pull request: https://github.com/louislam/uptime-kuma/compare +1. Write a proper description 1. Click "Change to draft" ### Pull Request Examples @@ -65,10 +66,12 @@ I do not have such knowledge to test it. #### ⚠ Low Priority - Harsh Mode -Some pull requests are required to modifiy the core. To be honest, I do not want anyone to try to do that, because it would spend a lot of your time and my time. I will review your pull request harshly. Also you may need to write a lot of unit tests to ensure that there is no breaking change. +Some pull requests are required to modifiy the core. To be honest, I do not want anyone to try to do that, because it would spend a lot of your time. I will review your pull request harshly. Also you may need to write a lot of unit tests to ensure that there is no breaking change. -- Touch large parts of code of any very important features of Uptime Kuma +- Touch large parts of code of any very important features +- Touch monitoring logic - Drop a table or drop a column for any reason +- Touch the entry point of Docker or Node.js #### *️⃣ Low Priority