mirror of
https://github.com/sveltejs/svelte.git
synced 2024-12-01 17:30:59 +01:00
d2f8e472a5
Adds optional performance support for apps using an immutable data structure such as redux. Adds the `immutable` boolean option for compile and an `immutable` option to store as well. When these options are used, computed will not recompute if the object has not changed. If your data structure is not immutable you should not use this as svelte cannot know if a mutation was made on objects. This PR also adds support for Dates and NaN values so computed properties will not recompute if a date has not changed or a value did not change from NaN. This closes out these issues: * https://github.com/sveltejs/svelte/issues/1146 * https://github.com/sveltejs/svelte/issues/1161 This is my first PR for Svelte. Any feedback would be appreciated!
166 lines
3.5 KiB
JavaScript
166 lines
3.5 KiB
JavaScript
import {
|
|
assign,
|
|
blankObject,
|
|
differs,
|
|
differsImmutable,
|
|
dispatchObservers,
|
|
get,
|
|
observe
|
|
} from './shared.js';
|
|
|
|
function Store(state, options) {
|
|
this._observers = { pre: blankObject(), post: blankObject() };
|
|
this._changeHandlers = [];
|
|
this._dependents = [];
|
|
|
|
this._computed = blankObject();
|
|
this._sortedComputedProperties = [];
|
|
|
|
this._state = assign({}, state);
|
|
this._differs = options && options.immutable ? differsImmutable : differs;
|
|
}
|
|
|
|
assign(Store.prototype, {
|
|
_add: function(component, props) {
|
|
this._dependents.push({
|
|
component: component,
|
|
props: props
|
|
});
|
|
},
|
|
|
|
_init: function(props) {
|
|
var state = {};
|
|
for (var i = 0; i < props.length; i += 1) {
|
|
var prop = props[i];
|
|
state['$' + prop] = this._state[prop];
|
|
}
|
|
return state;
|
|
},
|
|
|
|
_remove: function(component) {
|
|
var i = this._dependents.length;
|
|
while (i--) {
|
|
if (this._dependents[i].component === component) {
|
|
this._dependents.splice(i, 1);
|
|
return;
|
|
}
|
|
}
|
|
},
|
|
|
|
_sortComputedProperties: function() {
|
|
var computed = this._computed;
|
|
var sorted = this._sortedComputedProperties = [];
|
|
var cycles;
|
|
var visited = blankObject();
|
|
|
|
function visit(key) {
|
|
if (cycles[key]) {
|
|
throw new Error('Cyclical dependency detected');
|
|
}
|
|
|
|
if (visited[key]) return;
|
|
visited[key] = true;
|
|
|
|
var c = computed[key];
|
|
|
|
if (c) {
|
|
cycles[key] = true;
|
|
c.deps.forEach(visit);
|
|
sorted.push(c);
|
|
}
|
|
}
|
|
|
|
for (var key in this._computed) {
|
|
cycles = blankObject();
|
|
visit(key);
|
|
}
|
|
},
|
|
|
|
compute: function(key, deps, fn) {
|
|
var store = this;
|
|
var value;
|
|
|
|
var c = {
|
|
deps: deps,
|
|
update: function(state, changed, dirty) {
|
|
var values = deps.map(function(dep) {
|
|
if (dep in changed) dirty = true;
|
|
return state[dep];
|
|
});
|
|
|
|
if (dirty) {
|
|
var newValue = fn.apply(null, values);
|
|
if (store._differs(newValue, value)) {
|
|
value = newValue;
|
|
changed[key] = true;
|
|
state[key] = value;
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
c.update(this._state, {}, true);
|
|
|
|
this._computed[key] = c;
|
|
this._sortComputedProperties();
|
|
},
|
|
|
|
get: get,
|
|
|
|
observe: observe,
|
|
|
|
onchange: function(callback) {
|
|
this._changeHandlers.push(callback);
|
|
return {
|
|
cancel: function() {
|
|
var index = this._changeHandlers.indexOf(callback);
|
|
if (~index) this._changeHandlers.splice(index, 1);
|
|
}
|
|
};
|
|
},
|
|
|
|
set: function(newState) {
|
|
var oldState = this._state,
|
|
changed = this._changed = {},
|
|
dirty = false;
|
|
|
|
for (var key in newState) {
|
|
if (this._computed[key]) throw new Error("'" + key + "' is a read-only property");
|
|
if (this._differs(newState[key], oldState[key])) changed[key] = dirty = true;
|
|
}
|
|
if (!dirty) return;
|
|
|
|
this._state = assign({}, oldState, newState);
|
|
|
|
for (var i = 0; i < this._sortedComputedProperties.length; i += 1) {
|
|
this._sortedComputedProperties[i].update(this._state, changed);
|
|
}
|
|
|
|
for (var i = 0; i < this._changeHandlers.length; i += 1) {
|
|
this._changeHandlers[i](this._state, changed);
|
|
}
|
|
|
|
dispatchObservers(this, this._observers.pre, changed, this._state, oldState);
|
|
|
|
var dependents = this._dependents.slice(); // guard against mutations
|
|
for (var i = 0; i < dependents.length; i += 1) {
|
|
var dependent = dependents[i];
|
|
var componentState = {};
|
|
dirty = false;
|
|
|
|
for (var j = 0; j < dependent.props.length; j += 1) {
|
|
var prop = dependent.props[j];
|
|
if (prop in changed) {
|
|
componentState['$' + prop] = this._state[prop];
|
|
dirty = true;
|
|
}
|
|
}
|
|
|
|
if (dirty) dependent.component.set(componentState);
|
|
}
|
|
|
|
dispatchObservers(this, this._observers.post, changed, this._state, oldState);
|
|
}
|
|
});
|
|
|
|
export { Store }; |