Paolo Ricciuti
d207666ec3
fix: consider img with loading attribute not static ( #14237 )
...
* fix: consider img with loading attribute not static
* chore: add comment for `is_static_element`
* chore: better comment
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2024-11-10 17:48:10 +01:00
github-actions[bot]
4bcd01b994
Version Packages ( #14207 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-11-08 11:48:03 -08:00
Paolo Ricciuti
1060bea6e1
fix: consider valueOf in the reactive methods of SvelteDate ( #14227 )
2024-11-08 15:30:38 +01:00
Paolo Ricciuti
f0c2d4c698
fix: account for shadowing children slot during migration ( #14224 )
...
Fixes #14171
2024-11-08 14:14:56 +01:00
Simon H
31e6bbb646
fix: add lang="ts" attribute during migration if needed ( #14222 )
...
* fix: add `lang="ts"` attribute during migration if needed
fixes #14219
* fix
2024-11-08 12:25:03 +01:00
Paolo Ricciuti
438de04fb2
fix: add migration task when there's a variable named that would conflict with a rune ( #14216 )
...
Closes #14215
2024-11-08 11:18:50 +01:00
Simon H
870745fc53
fix: handle sibling combinators within :has ( #14213 )
...
We didn't collect sibling elements of a given element to then check the `:has` selectors. This adds the logic for that. Fixes #14072
2024-11-08 10:53:43 +01:00
Paolo Ricciuti
53af138d58
fix: read index as a source in legacy keyed each block ( #14208 )
...
Fixes #14203
2024-11-07 21:18:45 +01:00
Paolo Ricciuti
ea0d80e195
fix: consider variables with synthetic store sub as state ( #14195 )
...
Fixes #14183
2024-11-07 15:33:02 +01:00
Simon H
1eed645919
fix: ensure explicit nesting selector is always applied ( #14193 )
...
Previously, we were applying an explicit nesting selector to the start of a relative selector chain only when starting the traversal. Prepending the selector is important because it ensures we traverse upwards to the parent rule when the current selectors all matched and there's still more to do. But we forgot to do the prepend for parent rules, which meant that if we were nested two levels deep, we would stop too early. This fix ensures we prepend in that case, too.
Fixes #14178
2024-11-07 15:30:06 +01:00
github-actions[bot]
d7caf0833c
Version Packages ( #14184 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-11-07 09:00:26 +00:00
Paolo Ricciuti
44a833fafe
fix: restore active reaction if then block throws ( #14191 )
2024-11-06 17:51:09 +00:00
Dominic Gannaway
f1aeaf19e5
feat: adds legacy mode flag ( #14180 )
...
* feat: adds legacy mode flag
* feedback
* feedback and tweaks
* feedback and tweaks
* tweaks
* tweaks
* tweaks
* tweaks
2024-11-06 16:41:17 +00:00
Simon H
9b2a8f15fb
fix: ignore as type expressions on property definitions ( #14181 )
...
fixes #14179
2024-11-06 16:48:27 +01:00
github-actions[bot]
c49949621b
Version Packages ( #14167 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-11-06 08:01:05 -05:00
Simon H
aa23415179
fix: remove scoping for most :not selectors ( #14177 )
...
fixes #14168
This reverts the whole "selectors inside `:not` are scoped" logic. Scoping is done so that styles don't bleed. But within `:not`,everything is reversed, which means scoping the selectors now means they are more likely to bleed. That is the opposite of what we want to achieve, therefore we should just leave those selectors alone.
The exception are `:not` selectors with descendant selectors, as that means "look up the tree" and we need to scope all ancestor elements in that case.
2024-11-06 13:49:37 +01:00
Caique Torres
5077061695
fix: issue with implicit public modifier causing undefined properties ( #14153 )
...
closes #14152
2024-11-05 20:29:38 +01:00
github-actions[bot]
ecc9b97a5b
Version Packages ( #14097 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-11-05 13:54:18 -05:00
Rich Harris
927319c139
fix: update links in JSDoc ( #14165 )
2024-11-05 13:51:50 -05:00
Gonzalo Ruiz
e6dd871819
fix: ensure migrate keeps inline/trailing comments in $props type definition and produces non-broken code ( #14143 )
...
* feat[sv migrate]: keep inline/trailing comments when migrating export let types to type definition
* test: add tests for inline comment migration
* chore: add changeset
* fix: migrate trailing multiline comment parsing no longer results in broken code, FIXES PR #14143#issuecomment-2455702689
* test: add migrate test with same-line trailing multiline comments and same-line leading multiline comments
* chore: add changeset
* fix: lint
---------
Co-authored-by: Gonzalo Ruiz <rgon@rgon.es>
Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>
2024-11-04 23:31:36 +01:00
Simon H
7dbe812fc9
fix: ensure non-matching elements are scoped for :not(...) selector ( #13999 )
...
If the contents of a `:not` selector don't match, then it's actually a match for `:not` because it's inverted. Therefore, we need to scope such elements. We're also making sure that contents of `:not` that never match actually count as a used (because the result is negated), and as such the contents of `:not` that always match are actually marked as unused.
Fixes #13974
2024-11-04 22:49:54 +01:00
wackbyte
57e27ae90e
fix: only output the key for each_key_duplicate ( #14147 )
...
Fixes #14146
2024-11-04 22:19:53 +01:00
Simon H
551284ca22
fix: correctly infer <a> tag namespace ( #14134 )
...
`<a>` tags are valid in both the SVG and HTML namespace. If there's no parent, we therefore have to look downwards to see if it's the parent of a SVG or HTML element.
fixes #7807
fixes #13793
2024-11-03 15:04:52 +01:00
Paolo Ricciuti
8de5605b6a
fix: prevent migrated snippet from shadow snippet prop ( #14127 )
2024-11-03 14:36:11 +01:00
Paolo Ricciuti
74a2c6b580
fix: migrate multiple declarations with only some exported correctly ( #14126 )
2024-11-03 14:31:54 +01:00
Simon H
4ec9986cba
fix: check options namespace for top level svelte:elements ( #14101 )
...
We were checking it for nested elements, but not root elements
fixes #13875
2024-11-01 19:09:27 +01:00
Dominic Gannaway
9883e7078c
fix: ensure SvelteMap and SvelteSet work with generators in dev ( #14103 )
...
* fix: ensure SvelteMap and SvelteSet work with generators in dev
* add test
* better fix
* better fix
* better fix
* better fix
2024-11-01 16:08:45 +00:00
Simon H
e7d68d8c10
fix: pass along anchor in legacy class wrappers ( #14100 )
...
fixes #13832
2024-11-01 14:22:24 +01:00
Dominic Gannaway
a315a14939
fix: ensure video elements autoplay in safari ( #14095 )
2024-11-01 12:52:32 +00:00
Simon H
7d11fa8da2
fix: recognize all custom element prop definitions ( #14084 )
...
We didn't account for the `$props` rune being writtin in a way that makes some props unknown, and they would only be visible through the `customElement.props` definition. This changes the iteration to account for that and also adds a note to the documentation that you need to list out the properties explicitly.
fixes #13785
2024-11-01 13:19:52 +01:00
github-actions[bot]
cf25930512
Version Packages ( #14081 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-31 19:40:21 +00:00
Dominic Gannaway
58b1540ddc
fix: ensure transitions are applied to nested elements ( #14080 )
2024-10-31 18:36:21 +00:00
github-actions[bot]
b0d255aefe
Version Packages ( #14075 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-31 18:18:06 +01:00
Dominic Gannaway
2bdc3d401f
fix: ensure compiler statements are correctly included ( #14074 )
...
Fixes #14068 and fixes #14071
2024-10-31 18:16:06 +01:00
github-actions[bot]
3b38bc2a77
Version Packages ( #14052 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-31 11:41:47 -04:00
Rich Harris
37049b4171
Revert "feat: migrate Component to ComponentExports<typeof Component> in …" ( #14070 )
...
This reverts commit 4715dfaad2
2024-10-31 16:38:13 +01:00
Rich Harris
2784fb19f3
Revert "feat: add ComponentExports utility type ( #13441 )" ( #14069 )
...
This reverts commit d93ad3ba1e
2024-10-31 16:37:30 +01:00
Simon H
4f80ab6da6
fix: allow warningFilter option for compileModule ( #14066 )
...
fixes #14012
2024-10-31 14:47:53 +01:00
Paolo Ricciuti
4715dfaad2
feat: migrate Component to ComponentExports<typeof Component> in TS ( #13656 )
...
Closes #13491
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2024-10-31 12:59:49 +01:00
FoHoOV
d93ad3ba1e
feat: add ComponentExports utility type ( #13441 )
...
Safer/clearer/backwards/forward-compatibale way to reference them
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2024-10-31 12:25:49 +01:00
Dominic Gannaway
3999fed4ca
fix: ensure each block inert items are disposed of if the each block is also inert ( #13930 )
...
Fixes #13926
2024-10-31 12:02:30 +01:00
Paolo Ricciuti
e47ee22628
fix: wrap :id, :where:not and :has with :global during migration ( #13850 )
...
Closes #13765
2024-10-31 11:26:53 +01:00
Dominic Gannaway
4a5a0b15d9
fix: ensure onMount correctly fires when new expressions are used ( #14049 )
...
* fix: ensure onMount correctly fires when used externally
* fix root context
* fix root context
* revert
* alternative fix
2024-10-30 21:08:33 +00:00
Dominic Gannaway
cdec39afac
fix: ensure custom element attribute/prop changes are in their own context ( #14016 )
...
Fixes #13848 .
When we set custom element attributes/props, we should be doing so without the current effect/reaction active. Otherwise, the custom element lifecycle might attach effects/dependencies to the wrong reaction and all manner of things can incorrectly occur
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2024-10-30 22:07:38 +01:00
github-actions[bot]
e78ea1d555
Version Packages ( #14047 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-30 19:39:01 +00:00
Dominic Gannaway
bce1c4898c
fix: ensure child effects are destroyed before their deriveds ( #14043 )
...
* fix: ensure legacy props cache last value when destroyed
* fix runes
* better approach
* better approach
* kill code
* lint
2024-10-30 19:35:06 +00:00
github-actions[bot]
f519b3d7b7
Version Packages ( #14031 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-30 09:52:55 -07:00
Rich Harris
4157db94c4
fix: correct typo in compiler error messages ( #14044 )
2024-10-30 09:50:33 -07:00
Ahmad S.
224fcde821
fix: preserve the separator between selectors when an unused selector is in between ( #13954 )
...
fixes #13945
2024-10-30 17:37:31 +01:00
Dominic Gannaway
253d01ec29
fix: ensure element effects are executed in the correct order ( #14038 )
2024-10-30 16:27:47 +00:00
