mirrors/svelte
mirrors/svelte
0
0
Fork 0
mirror of https://github.com/sveltejs/svelte.git synced 2024-12-01 17:30:59 +01:00
Code Issues Releases Wiki Activity

fix determing whether an attribute should prevent innerHTML optimization

Browse Source 
Fixes #1581
This commit is contained in:
Conduitry 2018-07-08 01:47:38 -04:00
parent 2edc56b919
commit 909536dac9
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/compile/nodes/Element.ts
View File

@ -152,8 +152,14 @@ export default class Element extends Node {
); );
this.attributes.forEach(attr => { this.attributes.forEach(attr => {
if (attr.dependencies.size) { if (
attr.chunks &&
attr.chunks.length &&
(attr.chunks.length > 1 || attr.chunks[0].type !== 'Text')
) {
this.parent.cannotUseInnerHTML(); this.parent.cannotUseInnerHTML();
}
if (attr.dependencies.size) {
block.addDependencies(attr.dependencies); block.addDependencies(attr.dependencies);
// special case — <option value={foo}> — see below // special case — <option value={foo}> — see below

5
test/runtime/samples/attribute-dynamic-no-dependencies/_config.js Normal file
View File

@ -0,0 +1,5 @@
export default {
html: `
<div><div title='foo'>bar</div></div>
`,
};

1
test/runtime/samples/attribute-dynamic-no-dependencies/main.html Normal file
View File

@ -0,0 +1 @@
<div><div title={'foo'}>bar</div></div>