mirrors/svelte
mirrors/svelte
0
0
Fork 0
mirror of https://github.com/sveltejs/svelte.git synced 2024-12-01 17:30:59 +01:00
Code Issues Releases Wiki Activity

Adds validation check to checkComponent function and removes console.logs.

Browse Source
This commit is contained in:
Admin 2018-08-05 00:34:43 -05:00
parent 89412e370e
commit 7df6de62bb
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/validate/html/validateComponent.ts
View File

@ -2,6 +2,7 @@ import * as namespaces from '../../utils/namespaces';
import validateEventHandler from './validateEventHandler';
import validate, { Validator } from '../index';
import { Node } from '../../interfaces';
import isValidIdentifier from '../../utils/isValidIdentifier';
export default function validateComponent(
validator: Validator,
@ -22,11 +23,23 @@ export default function validateComponent(
node.attributes.forEach((attribute: Node) => {
if (attribute.type === 'Ref') {
if (attribute.name.includes('-'))
console.dir(attribute);
if (!isValidIdentifier(attribute.name)) {
const suggestion = attribute.name.replace(/[^_$a-z0-9]/ig, '_').replace(/^\d/, '_$&');
const key = {
start: attribute.start,
end: attribute.end
};
validator.error(key, {
code: `invalid-reference-name`,
message: `Reference name '${attribute.name}' is invalid — must be a valid identifier such as ${suggestion}`
});
} else {
if (!refs.has(attribute.name)) refs.set(attribute.name, []);
refs.get(attribute.name).push(node);
}
}
if (attribute.type === 'EventHandler') {
validator.used.events.add(attribute.name);

1
src/validate/html/validateElement.ts
View File

@ -83,7 +83,6 @@ export default function validateElement(
node.attributes.forEach((attribute: Node) => {
if (attribute.type === 'Ref') {
// console.dir(isValidIdentifier(attribute.name));
if (!isValidIdentifier(attribute.name)) {
const suggestion = attribute.name.replace(/[^_$a-z0-9]/ig, '_').replace(/^\d/, '_$&');