mirrors/svelte
mirrors/svelte
0
0
Fork 0
mirror of https://github.com/sveltejs/svelte.git synced 2024-11-24 16:29:46 +01:00
Code Issues Releases Wiki Activity

fix: ensure inline object literals are correctly serialised (#14325)

Browse Source 
* fix: ensure inline object literals are correctly serialised

* Apply suggestions from code review

* address feedback

* address feedback

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
This commit is contained in:
Dominic Gannaway 2024-11-16 17:10:45 +00:00 committed by GitHub
parent 95ab85fad7
commit 3a69b4c415
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/wicked-readers-knock.md Normal file
View File

@ -0,0 +1,5 @@
---
'svelte': patch
---
fix: treat property accesses of literals as pure

27
packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js
View File

@ -1,4 +1,4 @@
/** @import { AssignmentExpression, Expression, Identifier, Pattern, PrivateIdentifier, Super, UpdateExpression, VariableDeclarator } from 'estree' */ /** @import { AssignmentExpression, Expression, Literal, Pattern, PrivateIdentifier, Super, UpdateExpression, VariableDeclarator } from 'estree' */
/** @import { AST, Binding } from '#compiler' */ /** @import { AST, Binding } from '#compiler' */
/** @import { AnalysisState, Context } from '../../types' */ /** @import { AnalysisState, Context } from '../../types' */
/** @import { Scope } from '../../../scope' */ /** @import { Scope } from '../../../scope' */
@ -176,21 +176,42 @@ export function is_safe_identifier(expression, scope) {
} }
/** /**
* @param {Expression | Super} node * @param {Expression | Literal | Super} node
* @param {Context} context * @param {Context} context
* @returns {boolean} * @returns {boolean}
*/ */
export function is_pure(node, context) { export function is_pure(node, context) {
if (node.type === 'Literal') {
return true;
}
if (node.type === 'CallExpression') {
if (!is_pure(node.callee, context)) {
return false;
}
for (let arg of node.arguments) {
if (!is_pure(arg.type === 'SpreadElement' ? arg.argument : arg, context)) {
return false;
}
}
return true;
}
if (node.type !== 'Identifier' && node.type !== 'MemberExpression') { if (node.type !== 'Identifier' && node.type !== 'MemberExpression') {
return false; return false;
} }
const left = object(node); /** @type {Expression | Super | null} */
let left = node;
while (left.type === 'MemberExpression') {
left = left.object;
}
if (!left) return false; if (!left) return false;
if (left.type === 'Identifier') { if (left.type === 'Identifier') {
const binding = context.state.scope.get(left.name); const binding = context.state.scope.get(left.name);
if (binding === null) return true; // globals are assumed to be safe if (binding === null) return true; // globals are assumed to be safe
} else if (is_pure(left, context)) {
return true;
} }
// TODO add more cases (safe Svelte imports, etc) // TODO add more cases (safe Svelte imports, etc)

11
packages/svelte/tests/runtime-legacy/samples/inline-expressions-2/_config.js Normal file
View File

@ -0,0 +1,11 @@
import { test } from '../../test';
export default test({
html: `
<p>Without text expression: 7.36</p>
<p>With text expression: 7.36</p>
<p>With text expression and function call: 7.36</p>
<p>With text expression and property access: 4</p>
<h1>Hello name!</h1>
<p>4</p>`
});

6
packages/svelte/tests/runtime-legacy/samples/inline-expressions-2/main.svelte Normal file
View File

@ -0,0 +1,6 @@
<p>Without text expression: 7.36</p>
<p>With text expression: {7.36}</p>
<p>With text expression and function call: {(7.36).toLocaleString()}</p>
<p>With text expression and property access: {"test".length}</p>
<h1>Hello {('name').toUpperCase().toLowerCase()}!</h1>
<p>{"test".length}</p>