mirrors/svelte
mirrors/svelte
0
0
Fork 0
mirror of https://github.com/sveltejs/svelte.git synced 2024-12-01 17:30:59 +01:00
Code Issues Releases Wiki Activity

fix slot block lineage - fixes #2124

Browse Source
This commit is contained in:
Richard Harris 2019-02-21 23:34:27 -05:00
parent c494c05ebf
commit 24e09efec1
4 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compile/render-dom/wrappers/Element/index.ts
View File

@ -132,7 +132,7 @@ export default class ElementWrapper extends Wrapper {
const name = attribute.getStaticValue(); const name = attribute.getStaticValue();
if (!(owner as InlineComponentWrapper).slots.has(name)) { if (!(owner as InlineComponentWrapper).slots.has(name)) {
const child_block = block.parent.child({ const child_block = block.child({
comment: createDebuggingComment(node, this.renderer.component), comment: createDebuggingComment(node, this.renderer.component),
name: this.renderer.component.getUniqueName(`create_${sanitize(name)}_slot`) name: this.renderer.component.getUniqueName(`create_${sanitize(name)}_slot`)
}); });
@ -205,7 +205,8 @@ export default class ElementWrapper extends Wrapper {
block.parent.addDependencies(block.dependencies); block.parent.addDependencies(block.dependencies);
// appalling hack // appalling hack
block.parent.wrappers.splice(block.parent.wrappers.indexOf(this), 1); const index = block.parent.wrappers.indexOf(this);
block.parent.wrappers.splice(index, 1);
block.wrappers.push(this); block.wrappers.push(this);
} }
} }

1
test/runtime/samples/component-slot-named-c/Nested.svelte Normal file
View File

@ -0,0 +1 @@
<slot name="name"></slot>

6
test/runtime/samples/component-slot-named-c/_config.js Normal file
View File

@ -0,0 +1,6 @@
export default {
html: `
<span slot="name">Hello</span>
<span slot="name">world</span>
`
};

11
test/runtime/samples/component-slot-named-c/main.svelte Normal file
View File

@ -0,0 +1,11 @@
<script>
import Nested from './Nested.svelte';
</script>
<Nested>
<span slot="name">Hello</span>
</Nested>
<Nested>
<span slot="name">world</span>
</Nested>