0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 04:12:23 +01:00
posthog/ee
Harry Waye f43ad0334e
Fix IndexError in Retention endpoint: do not fail if there is more data than expected from clickhouse query (#5892)
* refactor(retention): add AppearanceRow dataclass to improve readability

This just makes it a little more clear what is being pulled out of the
database. Previously we were just getting a list of lists.

I haven't done anything else here but will follow up with a fix for
https://github.com/PostHog/posthog/issues/5443

* test(retention): reproduce retention marker index error

* fix(retention): make retention forgiving of too much data from query

This just makes the `appearance_to_markers` method not fail if the
underlying clickhouse query returns more data than expected. It should
just be less efficient than it could be and should still give the
correct results. Previously it would silently fail to include any data
in these cases.

Closes https://github.com/PostHog/posthog/issues/5443

Co-authored-by: Harry Waye <harry@scalexp.com>
2021-09-14 10:38:40 +01:00
..
api SAML auto provisioning (#5910) 2021-09-13 12:04:46 +02:00
bin Revert "Fix CH no data blocker (#5238)" (#5239) 2021-07-21 06:38:08 +00:00
certs Publish events to Kafka for consumption (#1644) 2020-09-15 20:04:38 -07:00
clickhouse Fix IndexError in Retention endpoint: do not fail if there is more data than expected from clickhouse query (#5892) 2021-09-14 10:38:40 +01:00
idl Delete omni_person.proto (#3014) 2021-01-21 14:13:04 +01:00
kafka_client Plugin log entries (#3482) 2021-05-06 10:54:32 +03:00
management/commands Move is_clickhouse_enabled from posthog.ee to posthog.utils (#5902) 2021-09-11 01:43:24 +02:00
migrations Event properties taxonomy (#4486) 2021-06-03 09:22:16 -04:00
models Refactor AvailableFeature from strings to an enum everywhere (#5856) 2021-09-09 12:19:55 +02:00
tasks Refactor AvailableFeature from strings to an enum everywhere (#5856) 2021-09-09 12:19:55 +02:00
__init__.py Add enterprise edition and licensing (#1390) 2020-08-14 11:23:55 +02:00
apps.py Add enterprise edition and licensing (#1390) 2020-08-14 11:23:55 +02:00
conftest.py Speed up EE tests by not destroying tables (#5715) 2021-08-25 10:58:09 +02:00
docker-compose.ch.arm64.yml ClickHouse M1 Docker (#5215) 2021-09-13 13:01:24 +02:00
docker-compose.ch.test.yml Conditional SAML dependencies (fix Heroku deploys) (#5870) 2021-09-09 14:09:15 +00:00
docker-compose.ch.yml Include users.xml config for dev/test clickhouse instance (#5732) 2021-08-25 01:47:15 +00:00
LICENSE Updated where our enterprise terms are found (#2881) 2021-01-08 12:09:27 +01:00
settings.py Conditional SAML dependencies (fix Heroku deploys) (#5870) 2021-09-09 14:09:15 +00:00
urls.py SAML support (#5681) 2021-08-27 07:20:49 -07:00