0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 04:12:23 +01:00
posthog/ee/api/test/test_dashboard.py
Michael Matloka b679bc3d68
Fix dashboard permissions (#8734)
* Fix dashboard permissions

* Use `===`
2022-02-23 10:33:21 +00:00

240 lines
11 KiB
Python

from rest_framework import status
from ee.api.test.base import APILicensedTest
from ee.models.explicit_team_membership import ExplicitTeamMembership
from ee.models.license import License
from posthog.models import OrganizationMembership
from posthog.models.dashboard import Dashboard
from posthog.models.user import User
class TestDashboardEnterpriseAPI(APILicensedTest):
def test_retrieve_dashboard_forbidden_for_project_outsider(self):
self.team.access_control = True
self.team.save()
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="private dashboard", created_by=self.user)
response = self.client.get(f"/api/projects/{self.team.id}/dashboards/{dashboard.id}")
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
def test_retrieve_dashboard_forbidden_for_org_admin(self):
self.team.access_control = True
self.team.save()
self.organization_membership.level = OrganizationMembership.Level.ADMIN
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="private dashboard", created_by=self.user)
response = self.client.get(f"/api/projects/{self.team.id}/dashboards/{dashboard.id}")
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_retrieve_dashboard_allowed_for_project_member(self):
self.team.access_control = True
self.team.save()
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
ExplicitTeamMembership.objects.create(team=self.team, parent_membership=self.organization_membership)
dashboard = Dashboard.objects.create(team=self.team, name="private dashboard", created_by=self.user)
response = self.client.get(f"/api/projects/{self.team.id}/dashboards/{dashboard.id}")
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_shared_dashboard_in_private_project(self):
self.team.access_control = True
self.team.save()
self.client.logout()
Dashboard.objects.create(
team=self.team, share_token="testtoken", name="public dashboard", is_shared=True,
)
response = self.client.get("/shared_dashboard/testtoken")
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_can_set_dashboard_to_restrict_editing_as_creator_who_is_project_member(self):
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard", created_by=self.user)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}",
{"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT},
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset(
{
"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
},
response_data,
)
def test_can_set_dashboard_to_restrict_editing_as_creator_who_is_project_admin(self):
self.organization_membership.level = OrganizationMembership.Level.ADMIN
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard", created_by=self.user)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}",
{"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT},
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset(
{
"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
},
response_data,
)
def test_cannot_set_dashboard_to_restrict_editing_as_other_user_who_is_project_member(self):
creator = User.objects.create_and_join(self.organization, "y@x.com", None)
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard", created_by=creator)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}",
{
"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
},
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEquals(
response_data,
self.permission_denied_response(
"Only the dashboard owner and project admins have the restriction rights required to change the dashboard's restriction level."
),
)
def test_can_set_dashboard_to_restrict_editing_as_other_user_who_is_project_admin(self):
creator = User.objects.create_and_join(self.organization, "y@x.com", None)
self.organization_membership.level = OrganizationMembership.Level.ADMIN
self.organization_membership.save()
dashboard = Dashboard.objects.create(team=self.team, name="Edit-restricted dashboard", created_by=creator)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}",
{"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT},
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset(
{
"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
},
response_data,
)
def test_can_edit_restricted_dashboard_as_creator_who_is_project_member(self):
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(
team=self.team,
name="Edit-restricted dashboard",
created_by=self.user,
restriction_level=Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}", {"name": "Gentle Antelope"}
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset(
{
"name": "Gentle Antelope",
"effective_restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_privilege_level": Dashboard.PrivilegeLevel.CAN_EDIT,
},
response_data,
)
def test_cannot_edit_restricted_dashboard_as_other_user_who_is_project_member(self):
creator = User.objects.create_and_join(self.organization, "y@x.com", None)
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(
team=self.team,
name="Edit-restricted dashboard",
created_by=creator,
restriction_level=Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}", {"name": "Gentle Antelope"}
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEquals(
response_data, self.permission_denied_response("You don't have edit permissions for this dashboard.")
)
def test_cannot_delete_restricted_dashboard_as_other_user_who_is_project_member(self):
creator = User.objects.create_and_join(self.organization, "y@x.com", None)
self.organization_membership.level = OrganizationMembership.Level.MEMBER
self.organization_membership.save()
dashboard = Dashboard.objects.create(
team=self.team,
name="Edit-restricted dashboard",
created_by=creator,
restriction_level=Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
)
response = self.client.delete(f"/api/projects/{self.team.id}/dashboards/{dashboard.id}")
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEquals(
response_data, self.permission_denied_response("You don't have edit permissions for this dashboard.")
)
def test_can_edit_restricted_dashboard_as_other_user_who_is_project_admin(self):
creator = User.objects.create_and_join(self.organization, "y@x.com", None)
self.organization_membership.level = OrganizationMembership.Level.ADMIN
self.organization_membership.save()
dashboard = Dashboard.objects.create(
team=self.team,
name="Edit-restricted dashboard",
created_by=creator,
restriction_level=Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
)
response = self.client.patch(
f"/api/projects/{self.team.id}/dashboards/{dashboard.id}", {"name": "Gentle Antelope"}
)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset({"name": "Gentle Antelope"}, response_data)
def test_dashboard_restrictions_have_no_effect_without_license(self):
dashboard = Dashboard.objects.create(
team=self.team,
name="Edit-restricted dashboard",
created_by=self.user,
restriction_level=Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
)
License.objects.all().delete()
self.organization.update_available_features()
self.organization.save()
response = self.client.get(f"/api/projects/{self.team.id}/dashboards/{dashboard.id}",)
response_data = response.json()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertDictContainsSubset(
{
"restriction_level": Dashboard.RestrictionLevel.ONLY_COLLABORATORS_CAN_EDIT,
"effective_restriction_level": Dashboard.RestrictionLevel.EVERYONE_IN_PROJECT_CAN_EDIT,
},
response_data,
)