Buddy Williams 7d045c86f3 Refactoring funnel trends (#4419) ... * checkpoint: refactoring funnel trends so that they work correctly * wip: refactoring funnel trends query to return the results we actually need * wip: added in new query for testing * wip: moved sql into a separate file, converted list to dictionary, and added several tests to check data quality * wip: with a better understaning of funnel trends I've refactored the query so that I can write a data transformer in python * moved code into funnel_trends for both logic and tests to isolate the concern * reordered methods for readability * wip: refactoring funnel trends to support filters * wip: added updated SQL which will replace the existing FUNNEL_TREND_SQL * correct column name so that it's clearer * added substitution variables to new query * fixed missing substitution variable * wip: integrating new query with correct params, added mixins for funnel_window, and working toward working test * several query corrections * summarize funnel trends * moved method down * removed unused code * added data quality checks * corrected cohort size for tests * test window size and incomplete status * corrected a few names * removed unnecessary comment * commented out old funnel trends tests * removed print statement * removed old funnel trend code * made funnel trends response match existing data structure layout * removed unused imports * removed more unused imports * fixed mypy errors * Added ClickhouseFunnelBase to extract common methods for both ClickhouseFunnelTrends and ClickhouseFunnel; this also fixes issues with tests; * removed unused type comment * corrected test to account for new funnel_window_days mixin * fixed clickhouse funnel tests * fixes for automated tests * changed team_id to use client substitution to avoid sql injection attempts in the future but since it's not user supplied it's not currently an issue * corrections prompted by PR review * corrected test to dict test with funnel_window_days		2021-06-03 17:06:08 -04:00
..
test	Refactoring funnel trends (#4419)	2021-06-03 17:06:08 -04:00
__init__.py
hooks.py
webhooks_ee.py	Include more clickhouse query metrics (#4256)	2021-05-10 10:47:54 +03:00