0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-24 09:14:46 +01:00
posthog/ee/tasks/materialized_columns.py
Karl-Aksel Puulmann 6cd14b712f
Quote ON CLUSTER statements (#8830)
Valid clickhouse clusters may contain dashes, which would cause syntax
errors without quoting
2022-03-03 13:29:39 +02:00

51 lines
2.1 KiB
Python

from celery.utils.log import get_task_logger
from ee.clickhouse.client import sync_execute
from ee.clickhouse.materialized_columns.columns import TRIM_AND_EXTRACT_PROPERTY, ColumnName, get_materialized_columns
from posthog.settings import CLICKHOUSE_CLUSTER, CLICKHOUSE_DATABASE, CLICKHOUSE_REPLICATION
logger = get_task_logger(__name__)
def mark_all_materialized() -> None:
if any_ongoing_mutations():
logger.info("There are running mutations, skipping marking as materialized")
return
for table, property_name, column_name in get_materialized_columns_with_default_expression():
updated_table = "sharded_events" if CLICKHOUSE_REPLICATION and table == "events" else table
# :TRICKY: On cloud, we ON CLUSTER updates to events/sharded_events but not to persons. Why? ¯\_(ツ)_/¯
execute_on_cluster = f"ON CLUSTER '{CLICKHOUSE_CLUSTER}'" if table == "events" else ""
sync_execute(
f"""
ALTER TABLE {updated_table}
{execute_on_cluster}
MODIFY COLUMN
{column_name} VARCHAR MATERIALIZED {TRIM_AND_EXTRACT_PROPERTY}
""",
{"property": property_name},
)
def get_materialized_columns_with_default_expression():
for table in ["events", "person"]:
materialized_columns = get_materialized_columns(table, use_cache=False)
for property_name, column_name in materialized_columns.items():
if is_default_expression(table, column_name):
yield table, property_name, column_name
def any_ongoing_mutations() -> bool:
running_mutations_count = sync_execute("SELECT count(*) FROM system.mutations WHERE is_done = 0")[0][0]
return running_mutations_count > 0
def is_default_expression(table: str, column_name: ColumnName) -> bool:
column_query = sync_execute(
"SELECT default_kind FROM system.columns WHERE table = %(table)s AND name = %(name)s AND database = %(database)s",
{"table": table, "name": column_name, "database": CLICKHOUSE_DATABASE,},
)
return len(column_query) > 0 and column_query[0][0] == "DEFAULT"