mirror of
https://github.com/PostHog/posthog.git
synced 2024-11-24 18:07:17 +01:00
d4508ed47a
* use lemon components for taxonomic property filters * add property value class * fix * use lemon select props instead * slightly less generic classname * add back classname for tests * do not use muted alt * label with classname * feat: Ungrid filter row to help with lemonizing (#11733) Co-authored-by: Ben White <ben@benjackwhite.co.uk>
152 lines
6.3 KiB
JavaScript
152 lines
6.3 KiB
JavaScript
import { dayjs } from 'lib/dayjs'
|
|
|
|
const interceptPropertyDefinitions = () => {
|
|
cy.intercept('api/projects/@current/property_definitions/?limit=5000', {
|
|
fixture: 'api/event/property_definitions',
|
|
})
|
|
|
|
cy.intercept('/api/projects/1/property_definitions?is_feature_flag=false&search=&*', {
|
|
fixture: 'api/event/property_definitions',
|
|
})
|
|
|
|
cy.intercept('/api/projects/1/property_definitions?is_feature_flag=false&search=%24time*', {
|
|
fixture: 'api/event/only_time_property_definition',
|
|
})
|
|
|
|
cy.intercept('/api/projects/1/property_definitions?is_feature_flag=false&search=%24browser*', {
|
|
fixture: 'api/event/only_browser_version_property_definition',
|
|
})
|
|
|
|
cy.intercept('/api/projects/1/property_definitions?is_feature_flag=true*', {
|
|
fixture: 'api/event/feature_flag_property_definition',
|
|
})
|
|
}
|
|
|
|
const selectNewTimestampPropertyFilter = () => {
|
|
cy.get('[data-attr=new-prop-filter-EventsTable]').click()
|
|
cy.get('[data-attr=taxonomic-filter-searchfield]').type('$time')
|
|
cy.get('.taxonomic-list-row').should('have.length', 1)
|
|
cy.get('[data-attr=prop-filter-event_properties-0]').click({ force: true })
|
|
}
|
|
|
|
const selectOperator = (operator, openPopUp) => {
|
|
if (openPopUp) {
|
|
cy.get('[data-attr="property-filter-0"] .property-filter .property-filter-button-label').click()
|
|
}
|
|
|
|
cy.get('[data-attr="taxonomic-operator"]').click()
|
|
cy.get('.operator-value-option').its('length').should('eql', 8)
|
|
cy.get('.operator-value-option').contains('< before').should('be.visible')
|
|
cy.get('.operator-value-option').contains('> after').should('be.visible')
|
|
|
|
cy.get('.operator-value-option').contains(operator).click()
|
|
}
|
|
|
|
const changeSecondPropertyFilterToDateAfter = () => {
|
|
selectOperator('> after', true)
|
|
}
|
|
|
|
describe('Events', () => {
|
|
beforeEach(() => {
|
|
interceptPropertyDefinitions()
|
|
|
|
cy.intercept('/api/event/values/?key=$browser_version', (req) => {
|
|
return req.reply([{ name: '96' }, { name: '97' }])
|
|
})
|
|
|
|
cy.visit('/events')
|
|
})
|
|
|
|
it('Events loaded', () => {
|
|
cy.get('[data-attr=events-table]').should('exist')
|
|
})
|
|
|
|
it('Click on an event', () => {
|
|
cy.get('[data-attr=events-table] .event-row:nth-child(2) td:first-child').click()
|
|
cy.get('[data-attr=event-details]').should('exist')
|
|
})
|
|
|
|
it('Apply 1 overall filter', () => {
|
|
cy.get('[data-attr=new-prop-filter-EventsTable]').click()
|
|
cy.get('[data-attr=taxonomic-filter-searchfield]').click()
|
|
cy.get('[data-attr=prop-filter-event_properties-0]').click({ force: true })
|
|
cy.get('[data-attr=prop-val]').click()
|
|
cy.get('[data-attr=prop-val-0]').click({ force: true })
|
|
cy.get('[data-attr=events-table]').should('exist')
|
|
})
|
|
|
|
it('separates feature flag properties into their own tab', () => {
|
|
cy.get('[data-attr=new-prop-filter-EventsTable]').click()
|
|
cy.get('[data-attr="taxonomic-tab-event_feature_flags"]').should('contain.text', 'Feature flags: 2').click()
|
|
// some virtualized rows remain in the dom, but hidden
|
|
cy.get('.taxonomic-list-row:visible').should('have.length', 2)
|
|
})
|
|
|
|
it('use before and after with a DateTime property', () => {
|
|
selectNewTimestampPropertyFilter()
|
|
|
|
cy.get('[data-attr="taxonomic-operator"]').click()
|
|
cy.get('.operator-value-option').should('contain.text', '> after')
|
|
cy.get('.operator-value-option').should('contain.text', '< before')
|
|
})
|
|
|
|
it('use less than and greater than with a numeric property', () => {
|
|
cy.get('[data-attr=new-prop-filter-EventsTable]').click()
|
|
cy.get('[data-attr=taxonomic-filter-searchfield]').type('$browser_version')
|
|
cy.get('.taxonomic-list-row').should('have.length', 1).click()
|
|
|
|
cy.get('[data-attr="taxonomic-operator"]').click()
|
|
cy.get('.operator-value-option').its('length').should('eql', 11) // 10 + 1 for the label in the LemonSelect button
|
|
cy.get('.operator-value-option').contains('< less than').should('be.visible')
|
|
cy.get('.operator-value-option').contains('> greater than').should('be.visible')
|
|
})
|
|
|
|
it('adds and removes an additional column', () => {
|
|
cy.get('[data-attr=events-table-column-selector]').click()
|
|
cy.get('[data-attr=taxonomic-filter-searchfield]').type('$browser_version')
|
|
cy.get('.taxonomic-list-row').should('have.length', 1).click()
|
|
cy.get('.column-display-item').should('have.length', 5)
|
|
cy.get('[data-attr=column-display-item-remove-icon').last().click()
|
|
cy.get('.column-display-item').should('have.length', 4)
|
|
})
|
|
|
|
/**
|
|
* Test fails because property filters act on properties.$time but not all events have that property
|
|
*
|
|
* Needs https://github.com/PostHog/posthog/issues/8250 before can query on timestamp
|
|
*/
|
|
it.skip('can filter after a date and can filter before it', () => {
|
|
cy.intercept(/api\/projects\/\d+\/events\/.*/).as('getEvents')
|
|
|
|
selectNewTimestampPropertyFilter()
|
|
|
|
const oneDayAgo = dayjs().hour(19).minute(1).subtract(1, 'day').format('YYYY-MM-DD HH:mm:ss')
|
|
selectOperator('< before', undefined)
|
|
cy.get('[data-attr=taxonomic-value-select]').click()
|
|
cy.get('.filter-date-picker').type(oneDayAgo)
|
|
cy.get('.ant-picker-ok').click()
|
|
cy.get('[data-attr="property-filter-0"]').should('include.text', 'Time < ')
|
|
|
|
cy.wait('@getEvents').then(() => {
|
|
cy.get('tr.event-row:first-child').should('contain.text', 'a day ago')
|
|
cy.get('tr.event-row').should((rows) => {
|
|
// test data setup is slightly random so...
|
|
expect(rows.length).to.be.greaterThan(50)
|
|
expect(rows.length).to.be.lessThan(110)
|
|
})
|
|
|
|
changeSecondPropertyFilterToDateAfter()
|
|
|
|
cy.wait('@getEvents').then(() => {
|
|
// as the seeded events are random(-ish) we can't assert on how long ago they will be
|
|
cy.get('tr.event-row:first-child').should('not.contain.text', 'a day ago')
|
|
cy.get('tr.event-row').should((rows) => {
|
|
// test data setup is slightly random so...
|
|
expect(rows.length).to.be.greaterThan(5)
|
|
expect(rows.length).to.be.lessThan(10)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|