mirror of
https://github.com/PostHog/posthog.git
synced 2024-11-28 09:16:49 +01:00
2550fb26c6
* test(funnel-people): add tests for converted/dropped people urls As per https://github.com/PostHog/posthog/issues/6935 we are adding urls to responses to attempt to improve consistency between insight responses and the people we display in the UI. This simply adds tests for these urls, just for funnel step response shape. The other two types of response will be handled separately. * feat(funnel-people): return converted/dropped people url in funnel Here I have simply added converted / dropped urls in the base funnel. This touches both clickhouse and postgres functionality, so I will probably add in tests for postgres also, or just disable to postgres. It doesn't pass yet as there is an issue in that the order appears to be ignored by the people endpoint. * fix(funnels): actually use strict/unordered persons querying Previously we were always using the standard `ClickhouseFunnelPersons` class for retrieving people from the `/api/persons/funnel/` endpoint. This change selects from the unordered and strict variants based on the `funnel_order_type` setting. Refers to https://github.com/PostHog/posthog/issues/7058 although there is a frontend component to add that will truely resolve the issue. * feat(funnel-people): add people urls for funnels with breakdown In this I have also removed any changes from the non-clickhouse code. Note that there are two places I've added the url generation code, one in the `ClickhouseFunnelBase` and another in the `ClickhouseFunnel` I think the former covers the unordered and strict cases, and the later for the breakdown case. I think there are further test that I'll need to add to validate e.g. if breakdown + strict work as expected. * Fix people urls for unordered funnels + breakdown * test: add test for strict breakdown with people urls * make funnel response assertions not check people url equality * fix typing * fix tests * remove new line in postgres funnel.py * clear cache on insight test start * no really, clear the cache * remove flakiness from strict funnel test * correct the unordered test * use absolute uris * use step.index not step.order * remove out of date comment * use step.index, not step.order * use step.index, remove unordered funnels comment * use journeys_for instead of create_events |
||
|---|---|---|
| .. | ||
| api | ||
| benchmarks | ||
| bin | ||
| certs | ||
| clickhouse | ||
| idl | ||
| kafka_client | ||
| management/commands | ||
| migrations | ||
| models | ||
| tasks | ||
| __init__.py | ||
| apps.py | ||
| conftest.py | ||
| docker-compose.ch.arm64.yml | ||
| docker-compose.ch.test.yml | ||
| docker-compose.ch.yml | ||
| LICENSE | ||
| settings.py | ||
| urls.py | ||