mirror of
https://github.com/PostHog/posthog.git
synced 2024-11-24 18:07:17 +01:00
303e88bbfc
* revert: #11552 * feat: save title and description on blur * allow undo when renaming insight * minimise change * minimise change * fix cancelling and add conditional updatedaashboard undo * no need to change saved insights logic * only save on blur if value has changed else cancel * add cypress test to rename insight * add a cypress test that you can change (and revert that change) an insight name * wait for insight save to complete
214 lines
9.2 KiB
JavaScript
214 lines
9.2 KiB
JavaScript
import { urls } from 'scenes/urls'
|
|
|
|
function applyFilter() {
|
|
cy.get('[data-attr=insight-filters-add-filter-group]').click()
|
|
cy.get('[data-attr=property-select-toggle-0]').click()
|
|
cy.get('[data-attr=taxonomic-filter-searchfield]').click()
|
|
cy.get('[data-attr=prop-filter-event_properties-1]').click({ force: true })
|
|
cy.get('[data-attr=prop-val]').click()
|
|
cy.get('[data-attr=prop-val-0]').click({ force: true })
|
|
}
|
|
|
|
function createANewInsight(insightName) {
|
|
cy.visit('/saved_insights/') // Should work with trailing slash just like without it
|
|
cy.get('[data-attr=saved-insights-new-insight-dropdown]').click()
|
|
cy.get('[data-attr-insight-type="TRENDS"').click()
|
|
|
|
applyFilter()
|
|
|
|
if (insightName) {
|
|
cy.get('[data-attr="insight-name"] [data-attr="edit-prop-name"]').click()
|
|
cy.get('[data-attr="insight-name"] input').type(insightName)
|
|
cy.get('[data-attr="insight-name"] [title="Save"]').click()
|
|
}
|
|
|
|
cy.get('[data-attr="insight-save-button"]').click()
|
|
// wait for save to complete and URL to change and include short id
|
|
cy.url().should('not.include', '/new')
|
|
}
|
|
|
|
// For tests related to trends please check trendsElements.js
|
|
describe('Insights', () => {
|
|
beforeEach(() => {
|
|
cy.visit(urls.insightNew())
|
|
})
|
|
|
|
it('Saving an insight sets breadcrumbs', () => {
|
|
createANewInsight()
|
|
|
|
cy.get('[data-attr=breadcrumb-0]').should('contain', 'Hogflix')
|
|
cy.get('[data-attr=breadcrumb-1]').should('contain', 'Hogflix Demo App')
|
|
cy.get('[data-attr=breadcrumb-2]').should('have.text', 'Insights')
|
|
cy.get('[data-attr=breadcrumb-3]').should('not.have.text', '')
|
|
})
|
|
|
|
it('Create new insight and save copy', () => {
|
|
createANewInsight()
|
|
|
|
cy.get('[data-attr="insight-edit-button"]').click()
|
|
|
|
cy.get('[data-attr="insight-save-dropdown"]').click()
|
|
cy.get('[data-attr="insight-save-as-new-insight"]').click()
|
|
cy.get('.ant-modal-content .ant-btn-primary').click()
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'Pageview count (copy)')
|
|
})
|
|
|
|
it('Can change insight name', () => {
|
|
createANewInsight('starting value')
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'starting value')
|
|
|
|
cy.get('[data-attr="insight-name"] [data-attr="edit-prop-name"]').click()
|
|
cy.get('[data-attr="insight-name"] input').type('edited value')
|
|
cy.get('[data-attr="insight-name"] [title="Save"]').click()
|
|
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'edited value')
|
|
})
|
|
|
|
it('Can undo a change of insight name', () => {
|
|
createANewInsight('starting value')
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'starting value')
|
|
|
|
cy.get('[data-attr="insight-name"]').scrollIntoView()
|
|
cy.get('[data-attr="insight-name"] [data-attr="edit-prop-name"]').click({ force: true })
|
|
cy.get('[data-attr="insight-name"] input').type('edited value')
|
|
cy.get('[data-attr="insight-name"] [title="Save"]').click()
|
|
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'edited value')
|
|
|
|
cy.get('[data-attr="edit-insight-undo"]').click()
|
|
|
|
cy.get('[data-attr="insight-name"]').should('not.contain', 'edited value')
|
|
cy.get('[data-attr="insight-name"]').should('contain', 'starting value')
|
|
})
|
|
|
|
it('Create new insight and save and continue editing', () => {
|
|
cy.intercept('PATCH', /\/api\/projects\/\d+\/insights\/\d+\/?/).as('patchInsight')
|
|
|
|
createANewInsight()
|
|
|
|
cy.get('[data-attr="insight-edit-button"]').click()
|
|
|
|
cy.get('.page-title').then(($pageTitle) => {
|
|
const pageTitle = $pageTitle.text()
|
|
|
|
cy.get('[data-attr="add-action-event-button"]').click()
|
|
cy.get('[data-attr="prop-filter-events-0"]').click()
|
|
cy.get('[data-attr="insight-save-dropdown"]').click()
|
|
cy.get('[data-attr="insight-save-and-continue"]').click()
|
|
cy.wait('@patchInsight')
|
|
// still on the insight edit page
|
|
expect(pageTitle).to.eq($pageTitle.text())
|
|
cy.get('[data-attr="insight-save-button"]').should('exist')
|
|
})
|
|
})
|
|
|
|
describe('unsaved insights confirmation', () => {
|
|
it('can move away from an unchanged new insight without confirm()', () => {
|
|
cy.get('[data-attr="menu-item-insight"]').click()
|
|
cy.log('Navigate away')
|
|
cy.get('[data-attr="menu-item-featureflags"]').click()
|
|
cy.log('We should be on the Feature Flags page now')
|
|
cy.url().should('include', '/feature_flags')
|
|
})
|
|
|
|
it('Can navigate away from unchanged saved insight without confirm()', () => {
|
|
cy.get('[data-attr="menu-item-insight"]').click()
|
|
cy.log('Add series')
|
|
cy.get('[data-attr=add-action-event-button]').click()
|
|
cy.log('Save')
|
|
cy.get('[data-attr="insight-save-button"]').click()
|
|
cy.wait(200)
|
|
cy.log('Navigate away')
|
|
cy.get('[data-attr="menu-item-annotations"]').click()
|
|
cy.log('We should be on the Annotations page now')
|
|
cy.url().should('include', '/annotations')
|
|
})
|
|
|
|
it('Can keep editing changed new insight after navigating away with confirm() rejection (case 1)', () => {
|
|
cy.on('window:confirm', () => {
|
|
return false
|
|
})
|
|
|
|
cy.get('[data-attr="menu-item-insight"]').click()
|
|
cy.log('Add series')
|
|
cy.get('[data-attr=add-action-event-button]').click()
|
|
cy.log('Navigate away')
|
|
cy.get('[data-attr="menu-item-featureflags"]').click()
|
|
cy.log('Save button should still be here because case 1 rejects confirm()')
|
|
cy.get('[data-attr="insight-save-button"]').should('exist')
|
|
})
|
|
|
|
it('Can navigate away from changed new insight with confirm() acceptance (case 2)', () => {
|
|
cy.on('window:confirm', () => {
|
|
return true
|
|
})
|
|
cy.get('[data-attr="menu-item-insight"]').click()
|
|
cy.log('Add series')
|
|
cy.get('[data-attr=add-action-event-button]').click()
|
|
cy.log('Navigate away')
|
|
cy.get('[data-attr="menu-item-featureflags"]').click()
|
|
cy.url().should('include', '/feature_flags')
|
|
})
|
|
})
|
|
|
|
it('Shows not found error with invalid short URL', () => {
|
|
cy.visit('/i/i_dont_exist')
|
|
cy.location('pathname').should('eq', '/insights/i_dont_exist')
|
|
cy.get('.LemonSkeleton').should('exist')
|
|
})
|
|
|
|
it('Stickiness graph', () => {
|
|
cy.get('.ant-tabs-tab').contains('Stickiness').click()
|
|
cy.get('[data-attr=add-action-event-button]').click()
|
|
cy.get('[data-attr=trend-element-subject-1]').should('exist')
|
|
cy.get('[data-attr=trend-line-graph]').should('exist')
|
|
cy.get('[data-attr=add-breakdown-button]').should('not.exist') // Can't do breakdown on this graph
|
|
})
|
|
|
|
it('Lifecycle graph', () => {
|
|
cy.get('[data-attr=trend-line-graph]').should('exist') // Wait until components are loaded
|
|
cy.get('.ant-tabs-tab').contains('Lifecycle').click()
|
|
cy.get('div').contains('Lifecycle Toggles').should('exist')
|
|
cy.get('[data-attr=trend-line-graph]').should('exist')
|
|
cy.get('[data-attr=add-breakdown-button]').should('not.exist') // Can't do breakdown on this graph
|
|
cy.get('[data-attr=add-action-event-button]').should('not.exist') // Can't add multiple series
|
|
})
|
|
|
|
it('Loads default filters correctly', () => {
|
|
// Test that default params are set correctly even if the app doesn't start on insights
|
|
cy.visit('/events/') // Should work with trailing slash just like without it
|
|
cy.reload()
|
|
|
|
cy.clickNavMenu('insight')
|
|
cy.get('[data-attr=trend-element-subject-0] span').should('contain', 'Pageview')
|
|
cy.get('[data-attr=trend-line-graph]').should('exist')
|
|
cy.contains('Add graph series').click()
|
|
cy.get('[data-attr=trend-element-subject-1]').should('exist')
|
|
cy.get('[data-attr=trend-line-graph]').should('exist')
|
|
})
|
|
|
|
it('Cannot see tags or description (non-FOSS feature)', () => {
|
|
cy.get('.insight-description').should('not.exist')
|
|
cy.get('[data-attr=insight-tags]').should('not.exist')
|
|
})
|
|
|
|
describe('insights date picker', () => {
|
|
it('Can set the date filter and show the right grouping interval', () => {
|
|
cy.get('[data-attr=date-filter]').click()
|
|
cy.get('div').contains('Yesterday').should('exist').click()
|
|
cy.get('[data-attr=interval-filter]').should('contain', 'Hour')
|
|
})
|
|
|
|
it('Can set a custom rolling date range', () => {
|
|
cy.get('[data-attr=date-filter]').click()
|
|
cy.get('[data-attr=rolling-date-range-input]').type('{selectall}5{enter}')
|
|
cy.get('[data-attr=rolling-date-range-date-options-selector]').click()
|
|
cy.get('.RollingDateRangeFilter__popup > div').contains('days').should('exist').click()
|
|
cy.get('.RollingDateRangeFilter__label').should('contain', 'In the last').click()
|
|
|
|
// Test that the button shows the correct formatted range
|
|
cy.get('[data-attr=date-filter]').get('span').contains('Last 5 days').should('exist')
|
|
})
|
|
})
|
|
})
|